mm/.github/pull_request_template.md at 151e098e48fcd779a296cfbdcedd8f4528f96232

mirror/mm

mirror of https://github.com/zeldaret/mm.git synced 2026-05-23 15:01:32 -04:00

Files

T

Zach Banks 8c62c102cf CONTRIBUTING.md (#157 )

* Draft CONTRIBUTING.md

* Expand PR process; mention KZ

* More TODO

* Add notes about documenting

* Address (most) PR comments

* Finish responding to PR comments; add PR template

* Fix grammar

* Add missing periods. More actor examples. Remove ref to booleans

* Add note about `NON_EQUIVALENT`; bold asset warning

* Condense PR template

* PR feedback from Kenix; Condense PR template

* Incorporate Thar0's feedback

2021-05-20 21:06:30 -04:00

492 B

Raw Blame History

Before opening this PR, ensure the following:

./format.sh was run to apply standard formatting.
make successfully builds a matching ROM.
No new compiler warnings were introduced during the build process.
- Can be verified locally by running tools/warnings_count/check_new_warnings.sh
New variables & functions should follow standard naming conventions.
Comments and variables have correct spelling.

492 B Raw Blame History

492 B

Raw Blame History