SERVER-112501 Enable full shutdown validation and remove doesNotSupportWTVerify (#43312)

Co-authored-by: Ruchitha Rajaghatta <77162985+ruchitharajaghatta@users.noreply.github.com>
GitOrigin-RevId: 7acab69a9d8ff0d1f49748d751c6459b12033feb
This commit is contained in:
Wei Hu 2025-11-05 14:24:45 -08:00 committed by MongoDB Bot
parent 2dca42f06a
commit 7315ea913e
4 changed files with 9 additions and 8 deletions

1
.github/CODEOWNERS vendored
View File

@ -997,6 +997,7 @@ WORKSPACE.bazel @10gen/devprod-build @svc-auto-approve-bot
/jstests/libs/override_methods/**/implicitly_retry_on_fcv_upgrade_downgrade.js @10gen/query-execution-query-settings @10gen/server-catalog-and-routing-routing-and-topology @10gen/server-replication-reviewers @svc-auto-approve-bot
/jstests/libs/override_methods/**/implicit_identity_views.js @10gen/query-optimization @svc-auto-approve-bot
/jstests/libs/override_methods/**/implicitly_retry_on_conflicting_operation_during_fuzztest.js @10gen/server-catalog-and-routing-routing-and-topology @svc-auto-approve-bot
/jstests/libs/override_methods/**/validate_collections_on_shutdown.js @10gen/server-validate @svc-auto-approve-bot
# The following patterns are parsed from ./jstests/libs/override_methods/collection_write_path/OWNERS.yml
/jstests/libs/override_methods/collection_write_path/**/* @10gen/server-collection-write-path @svc-auto-approve-bot

View File

@ -200,11 +200,13 @@ def validate_database(
"skipValidationOnInvalidViewDefinitions", False
)
skipValidationOnNamespaceNotFound = test_data.get("skipValidationOnNamespaceNotFound", True)
# TODO (SERVER-112502): Remove this and always set "full" to true.
doesNotSupportWTVerify = test_data.get("doesNotSupportWTVerify", False)
validate_opts = {
"full": not doesNotSupportWTVerify,
# Run non-full validation because certain test fixtures run validate while
# the oplog applier is still active, and full:true can cause the oplog applier
# thread to encounter ObjectIsBusy errors during internal finds.
"full": False,
"checkBSONConformance": True,
# TODO (SERVER-24266): Always enforce fast counts, once they are always accurate
"enforceFastCount": not skipEnforceFastCountOnValidate,
}

View File

@ -48,3 +48,6 @@ filters:
- "implicitly_retry_on_conflicting_operation_during_fuzztest.js":
approvers:
- 10gen/server-catalog-and-routing-routing-and-topology
- "validate_collections_on_shutdown.js":
approvers:
- 10gen/server-validate

View File

@ -146,11 +146,6 @@ MongoRunner.validateCollectionsCallback = function (port, options) {
validateOptions.enforceFastCount = false;
}
// TODO(SERVER-112502): Remove this check.
if (TestData.doesNotSupportWTVerify) {
validateOptions.full = false;
}
try {
const token = tenant ? _createTenantToken({tenant}) : undefined;
conn._setSecurityToken(token);