Revert "SERVER-93803 enable detect_stack_use_after_return in ASAN builds (#30429)" (#30516)

GitOrigin-RevId: bda0b261d73e489559855b59e8ef232449cf69b1

SConstruct

@@ -4514,8 +4514,6 @@ def doConfigure(myenv):
                 "handle_abort=1",
                 "strict_string_checks=true",
                 "detect_invalid_pointer_pairs=1",
-                "detect_stack_use_after_return=1",
-                "max_uar_stack_size_log=16",
             ]
             asan_options = ":".join(asan_options_clear)
             lsan_options = (

etc/asan.denylist

@@ -5,14 +5,3 @@ src:src/third_party/IntelRDFPMathLib20U1/TESTS/readtest.c
 # gRPC only supports sanitizers in the native Bazel build (https://github.com/grpc/grpc/issues/19224#issuecomment-610363882)
 # This file has a static init order fiasco.
 src:src/third_party/grpc/dist/src/cpp/util/status.cc
-
-# The following sources rely on a local variable being located on the stack, which is
-# not compatible with the implementation of detect_stack_use_after_return. ASAN does
-# not report a use-after-return, but breaks the correctness of the stack locator.
-# *MozRuntime* -> MozJSImplScope::MozRuntime::MozRuntime
-fun:*MozRuntime*
-src:src/mongo/platform/stack_locator_test.cpp
-src:src/mongo/stdx/sigaltstack_location_test.cpp
-
-# A stack use-after-return is reported by ASAN when running kafka_resolve_callback_test, SERVER-98554
-src:src/mongo/db/modules/enterprise/src/streams/exec/kafka_resolve_callback.cpp

etc/evergreen_yml_components/variants/sanitizer/test_dev.yml

@@ -131,7 +131,7 @@ variables:
   - aubsan_options: &aubsan_options >-
       UBSAN_OPTIONS="print_stacktrace=1:external_symbolizer_path=/opt/mongodbtoolchain/v4/bin/llvm-symbolizer"
       LSAN_OPTIONS="suppressions=etc/lsan.suppressions:report_objects=1"
-      ASAN_OPTIONS="detect_leaks=1:check_initialization_order=true:strict_init_order=true:abort_on_error=1:disable_coredump=0:handle_abort=1:strict_string_checks=true:detect_invalid_pointer_pairs=1:detect_stack_use_after_return=1:max_uar_stack_size_log=16:external_symbolizer_path=/opt/mongodbtoolchain/v4/bin/llvm-symbolizer"
+      ASAN_OPTIONS="detect_leaks=1:check_initialization_order=true:strict_init_order=true:abort_on_error=1:disable_coredump=0:handle_abort=1:strict_string_checks=true:detect_invalid_pointer_pairs=1:external_symbolizer_path=/opt/mongodbtoolchain/v4/bin/llvm-symbolizer"
 
   # THIS HAS COPIES IN:
   # - etc/evergreen_yml_components/variants/sanitizer/test_dev_master_branch_only.yml

etc/evergreen_yml_components/variants/sanitizer/test_dev_master_branch_only.yml

@@ -88,13 +88,13 @@ variables:
   - aubsan_options: &aubsan_options >-
       UBSAN_OPTIONS="print_stacktrace=1:external_symbolizer_path=/opt/mongodbtoolchain/v4/bin/llvm-symbolizer"
       LSAN_OPTIONS="suppressions=etc/lsan.suppressions:report_objects=1"
-      ASAN_OPTIONS="detect_leaks=1:check_initialization_order=true:strict_init_order=true:abort_on_error=1:disable_coredump=0:handle_abort=1:strict_string_checks=true:detect_invalid_pointer_pairs=1:detect_stack_use_after_return=1:max_uar_stack_size_log=16:external_symbolizer_path=/opt/mongodbtoolchain/v4/bin/llvm-symbolizer"
+      ASAN_OPTIONS="detect_leaks=1:check_initialization_order=true:strict_init_order=true:abort_on_error=1:disable_coredump=0:handle_abort=1:strict_string_checks=true:detect_invalid_pointer_pairs=1:external_symbolizer_path=/opt/mongodbtoolchain/v4/bin/llvm-symbolizer"
 
   # https://github.com/grpc/grpc/issues/21537 -- have to disable checking odr violations on gRPC if it is not in native Bazel build.
   - grpc_aubsan_options: &grpc_aubsan_options >-
       UBSAN_OPTIONS="print_stacktrace=1:external_symbolizer_path=/opt/mongodbtoolchain/v4/bin/llvm-symbolizer"
       LSAN_OPTIONS="suppressions=etc/lsan.suppressions:report_objects=1"
-      ASAN_OPTIONS="detect_odr_violation=0:detect_leaks=1:check_initialization_order=true:strict_init_order=true:abort_on_error=1:disable_coredump=0:handle_abort=1:strict_string_checks=true:detect_invalid_pointer_pairs=1:detect_stack_use_after_return=1:max_uar_stack_size_log=16:external_symbolizer_path=/opt/mongodbtoolchain/v4/bin/llvm-symbolizer"
+      ASAN_OPTIONS="detect_odr_violation=0:detect_leaks=1:check_initialization_order=true:strict_init_order=true:abort_on_error=1:disable_coredump=0:handle_abort=1:strict_string_checks=true:detect_invalid_pointer_pairs=1:external_symbolizer_path=/opt/mongodbtoolchain/v4/bin/llvm-symbolizer"
 
   - ubsan_options: &ubsan_options UBSAN_OPTIONS="print_stacktrace=1:external_symbolizer_path=/opt/mongodbtoolchain/v4/bin/llvm-symbolizer"
 

etc/evergreen_yml_components/variants/ubuntu/test_dev_master_and_lts_branches_only.yml

@@ -64,7 +64,7 @@ buildvariants:
         LIBS="voidstar"
       san_options: >-
         UBSAN_OPTIONS="print_stacktrace=1:external_symbolizer_path=/usr/lib/llvm-12/bin/llvm-symbolizer"
-        ASAN_OPTIONS="detect_leaks=1:check_initialization_order=true:strict_init_order=true:abort_on_error=1:disable_coredump=0:handle_abort=1:strict_string_checks=true:detect_invalid_pointer_pairs=1:detect_stack_use_after_return=1:max_uar_stack_size_log=16:verify_asan_link_order=0"
+        ASAN_OPTIONS="detect_leaks=1:check_initialization_order=true:strict_init_order=true:abort_on_error=1:disable_coredump=0:handle_abort=1:strict_string_checks=true:detect_invalid_pointer_pairs=1:verify_asan_link_order=0"
       test_flags: >-
         --excludeWithAnyTags=incompatible_aubsan
   # The v4 toolchain doesn't support the -shared-libsan option with TSAN, which is necessary for