mirror
/
mongo
mirror of https://github.com/mongodb/mongo
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SERVER-115205 DropIndexes must return the result field only if it matches with the coordinator completion status (#45043) 

GitOrigin-RevId: e421ba59c9ca2124d33a28729ec374910bdc7dbc
This commit is contained in:
Silvia Surroca 2025-12-10 14:37:59 +01:00 committed by MongoDB Bot
parent 0a43a8a3a3
commit a47df57a8d
1 changed files with 9 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/mongo/db/global_catalog/ddl/shardsvr_drop_indexes_command.cpp
View File

@ -222,24 +222,17 @@ ShardsvrDropIndexesCommand::Invocation::Response ShardsvrDropIndexesCommand::Inv
auto completionStatus = coordinator->getCompletionFuture().getNoThrow(opCtx);
auto result = coordinator->getResult(opCtx);
if (!result) {
if (!completionStatus.isOK()) {
// Return `completionStatus` if it differs from `result`'s error code; otherwise
// return `result` to preserve the `raw` field.
if (!result || !result->hasField("code") ||
result->getField("code").Int() != completionStatus.code()) {
uassertStatusOK(completionStatus);
}
}
// Result must be populated if the coordinator succeeded.
tassert(10710101, "DropIndexes result unavailable", result);
}
// If 'result' is set but not OK, we should avoid propagating the coordinator error;
// otherwise, the 'raw' field would not be returned to the user.
//
// However, if 'result' is set and OK, we should propagate the coordinator error.
// For example, in the case of a stepdown, the coordinator’s persistent document
// will not be deleted. In this scenario, we must return the stepdown error to the
// user even if the dropIndexes succeeded on all shards, since the dropIndexes command
// may be retried on the new primary node.
if (result->getField("ok").trueValue()) {
uassertStatusOK(completionStatus);
}
return Response(result->getOwned());
}