mirror
/
mongo
mirror of https://github.com/mongodb/mongo
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SERVER-102469 Invert pass/fail default in linter shim (#33645) 

GitOrigin-RevId: db8f10db669a747e3004e4032fae57ffd067d130
This commit is contained in:
Zack Winter 2025-03-17 17:53:11 -07:00 committed by MongoDB Bot
parent 8ce82d9463
commit d983587f36
32 changed files with 213 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
bazel/BUILD.bazel
View File

@ -9,6 +9,5 @@ exports_files([
sh_binary(
name = "lint",
srcs = ["lint.sh"],
args = ["//..."],
visibility = ["//visibility:public"],
)

8
bazel/lint.sh
View File

@ -1,2 +1,8 @@
# placeholder for bazel/wrapper_hook/lint.py
echo "No linter errors found!"
if [[ $1 == "ALL_PASSING" ]]; then
echo "No linter errors found!"
exit 0
fi
echo "Linter run failed, see details above"
exit 1

15
bazel/wrapper_hook/lint.py
View File

@ -186,25 +186,25 @@ def list_files_without_targets(
return True
def run_rules_lint(bazel_bin, args):
def run_rules_lint(bazel_bin, args) -> bool:
if platform.system() == "Windows":
print("eslint not supported on windows")
sys.exit(1)
return False
if "--fix" in args:
create_build_files_in_new_js_dirs()
files_with_targets = list_files_with_targets(bazel_bin)
if not list_files_without_targets(files_with_targets, "C++", "cpp", ["src/mongo"]):
sys.exit(1)
return False
if not list_files_without_targets(
files_with_targets, "javascript", "js", ["src/mongo", "jstests"]
):
sys.exit(1)
return False
if not check_for_missing_test_stubs():
exit(1)
return False
# Default to linting everything if no path was passed in
if len([arg for arg in args if not arg.startswith("--")]) == 0:
@ -313,6 +313,7 @@ def run_rules_lint(bazel_bin, args):
)
else:
print(f"ERROR: unknown fix type {fix}", file=sys.stderr)
sys.exit(1)
return False
elif failing_reports != 0:
sys.exit(1)
return False
return True

3
bazel/wrapper_hook/plus_interface.py
View File

@ -97,7 +97,8 @@ def test_runner_interface(args, autocomplete_query, get_buildozer_output=get_bui
if lint_target:
command_start_index = args.index("lint") + 1
run_rules_lint(args[0], args[command_start_index:])
if run_rules_lint(args[0], args[command_start_index:]):
return ["run", "lint", "--", "ALL_PASSING"]
return args[1:command_start_index]
if skip_plus_interface and not autocomplete_query:

6
jstests/aggregation/optimization/distinct_like_group_rooted_or.js
View File

@ -6,9 +6,9 @@
const collName = jsTestName();
const coll = db[collName];
coll.drop()
assert.commandWorked(coll.insert({}))
assert.commandWorked(coll.createIndex({t: 1, m: 1}))
coll.drop();
assert.commandWorked(coll.insert({}));
assert.commandWorked(coll.createIndex({t: 1, m: 1}));
assert.commandWorked(db.runCommand({
aggregate: jsTestName(),
pipeline:

2
jstests/aggregation/sources/agg_stages_basic_behavior_pbt.js
View File

@ -201,7 +201,7 @@ function makePropertyFn(checkResultsFn, failMsg) {
}
}
return {passed: true};
}
};
}
for (const {stageArb, checkResultsFn, failMsg} of testCases) {

6
jstests/auth/release_memory_base.js
View File

@ -70,7 +70,7 @@ export function runTest(conn) {
resource: {db: "release_memory_base_1", collection: "coll1"},
actions: ["releaseMemoryAnyCursor"],
}],
})
});
admin.createRole({
createRole: "releaseDatabase",
roles: ["readAnyDatabase"],
@ -78,12 +78,12 @@ export function runTest(conn) {
resource: {db: "release_memory_base_1", collection: ""},
actions: ["releaseMemoryAnyCursor"],
}],
})
});
admin.createRole({
createRole: "releaseCluster",
roles: ["readAnyDatabase"],
privileges: [{resource: {cluster: true}, actions: ["releaseMemoryAnyCursor"]}],
})
});
admin.createUser({user: "userCollection", pwd: "pass", roles: ["releaseCollection"]});
admin.createUser({user: "userDatabase", pwd: "pass", roles: ["releaseDatabase"]});

13
jstests/core/query/release_memory/BUILD.bazel Normal file
View File

@ -0,0 +1,13 @@
load("@aspect_rules_js//js:defs.bzl", "js_library")
js_library(
name = "all_javascript_files",
srcs = glob([
"*.js",
]),
target_compatible_with = select({
"//bazel/config:ppc_or_s390x": ["@platforms//:incompatible"],
"//conditions:default": [],
}),
visibility = ["//visibility:public"],
)

2
jstests/core/query/release_memory/release_memory_basic.js
View File

@ -31,7 +31,7 @@ function waitForLog(logId, cursorId) {
return true;
}
return false;
})
});
}
function makeParallelShellFunctionString(cursorId, collName, sessionId, txnNumber) {

9
jstests/libs/override_methods/query_shape_hash_stability.js
View File

@ -29,7 +29,7 @@ const topologyCache = {};
function getTopologyConnections(conn) {
if (!topologyCache.allConnections) {
jsTest.log.debug(`Discovering topology...`)
jsTest.log.debug(`Discovering topology...`);
topologyCache.allConnections =
getAllMongosConnections(conn)
.flatMap(connection => DiscoverTopology.findNonConfigNodes(connection, {connectFn}))
@ -40,7 +40,7 @@ function getTopologyConnections(conn) {
function getAllMongosConnections(conn) {
if (!topologyCache.mongosConnectionsArr) {
jsTest.log.debug(`Settings the mongos connections array...`)
jsTest.log.debug(`Settings the mongos connections array...`);
if (isMultiShardedClusterFixture) {
const connections =
conn.getDB("config").multiShardedClusterFixture.find().sort({_id: 1}).toArray();
@ -48,8 +48,7 @@ function getAllMongosConnections(conn) {
// Set the connections array to include both when using a multi-cluster fixture.
topologyCache.mongosConnectionsArr =
connections.map(doc => connectFn(doc.connectionString));
}
else {
} else {
topologyCache.mongosConnectionsArr = [conn];
}
}
@ -101,7 +100,7 @@ function runCommandOverride(conn, dbName, cmdName, cmdObj, clientFunction, makeF
const mongosConnArr = getAllMongosConnections(conn);
// In case we run the test using the two-cluster fixture, assert we have exactly two
// mongos connections.
assert.eq(mongosConnArr.length, 2)
assert.eq(mongosConnArr.length, 2);
// Mirror the command on the second cluster to ensure the collections exists.
// TODO SERVER-100658 Explain on non-existent collection returns empty results for
// sharded cluster aggregations - Assess if this is still needed.

2
jstests/libs/property_test_helpers/models/model_utils.js
View File

@ -7,4 +7,4 @@ import {fc} from "jstests/third_party/fast_check/fc-3.1.0.js";
// If additional options need to be passed, use `fc.oneof`.
export const oneof = function(...arbs) {
return fc.oneof({withCrossShrink: true}, ...arbs);
}
};

4
jstests/libs/write_concern_all_commands.js
View File

@ -10,7 +10,7 @@
*
*/
import {AllCommandsTest} from "jstests/libs/all_commands_test.js";
import {getCommandName} from "jstests/libs/cmd_object_utils.js"
import {getCommandName} from "jstests/libs/cmd_object_utils.js";
import {configureFailPoint} from "jstests/libs/fail_point_util.js";
import {FeatureFlagUtil} from "jstests/libs/feature_flag_util.js";
import {Thread} from "jstests/libs/parallelTester.js";
@ -2704,7 +2704,7 @@ let wcCommandsTests = {
assert.commandWorkedIgnoringWriteConcernErrors(res);
assert.eq(bsonWoCompare(getShardKey(coll, fullNs), {x: 1}), 0);
restartfAdditionalSecondariesIfSharded(clusterType, cluster, secondariesRunning);
restartAdditionalSecondariesIfSharded(clusterType, cluster, secondariesRunning);
},
admin: true,
},

2
jstests/noPassthrough/query/getmore_invalid_namespace.js
View File

@ -4,7 +4,7 @@
// TODO SERVER-102285: Run this test against a sharded cluster as well.
const conn = MongoRunner.runMongod({});
const dbName = 'getmore_cmd_test'
const dbName = 'getmore_cmd_test';
const collName = 'getmore_cmd_invalid_namespace';
const db = conn.getDB(dbName);
const coll = db[collName];

2
jstests/noPassthrough/query/query_planner_params_diagnostics.js
View File

@ -21,7 +21,7 @@ function setup(conn) {
coll.drop();
assert.commandWorked(coll.createIndex({a: 1}, {sparse: true, collation: {locale: "en"}}));
assert.commandWorked(coll.createIndex({b: 1}, {partialFilterExpression: {b: {$gte: 0}}}));
coll.insert({a: 1, b: [1]})
coll.insert({a: 1, b: [1]});
// Setup other collection
const otherColl = db[otherCollName];

13
jstests/noPassthrough/timeseries/bucket_reopening/BUILD.bazel Normal file
View File

@ -0,0 +1,13 @@
load("@aspect_rules_js//js:defs.bzl", "js_library")
js_library(
name = "all_javascript_files",
srcs = glob([
"*.js",
]),
target_compatible_with = select({
"//bazel/config:ppc_or_s390x": ["@platforms//:incompatible"],
"//conditions:default": [],
}),
visibility = ["//visibility:public"],
)

13
jstests/noPassthrough/timeseries/bulkwrite/BUILD.bazel Normal file
View File

@ -0,0 +1,13 @@
load("@aspect_rules_js//js:defs.bzl", "js_library")
js_library(
name = "all_javascript_files",
srcs = glob([
"*.js",
]),
target_compatible_with = select({
"//bazel/config:ppc_or_s390x": ["@platforms//:incompatible"],
"//conditions:default": [],
}),
visibility = ["//visibility:public"],
)

13
jstests/noPassthrough/timeseries/create/BUILD.bazel Normal file
View File

@ -0,0 +1,13 @@
load("@aspect_rules_js//js:defs.bzl", "js_library")
js_library(
name = "all_javascript_files",
srcs = glob([
"*.js",
]),
target_compatible_with = select({
"//bazel/config:ppc_or_s390x": ["@platforms//:incompatible"],
"//conditions:default": [],
}),
visibility = ["//visibility:public"],
)

13
jstests/noPassthrough/timeseries/data_integrity/BUILD.bazel Normal file
View File

@ -0,0 +1,13 @@
load("@aspect_rules_js//js:defs.bzl", "js_library")
js_library(
name = "all_javascript_files",
srcs = glob([
"*.js",
]),
target_compatible_with = select({
"//bazel/config:ppc_or_s390x": ["@platforms//:incompatible"],
"//conditions:default": [],
}),
visibility = ["//visibility:public"],
)

13
jstests/noPassthrough/timeseries/extended_range/BUILD.bazel Normal file
View File

@ -0,0 +1,13 @@
load("@aspect_rules_js//js:defs.bzl", "js_library")
js_library(
name = "all_javascript_files",
srcs = glob([
"*.js",
]),
target_compatible_with = select({
"//bazel/config:ppc_or_s390x": ["@platforms//:incompatible"],
"//conditions:default": [],
}),
visibility = ["//visibility:public"],
)

13
jstests/noPassthrough/timeseries/index_builds/BUILD.bazel Normal file
View File

@ -0,0 +1,13 @@
load("@aspect_rules_js//js:defs.bzl", "js_library")
js_library(
name = "all_javascript_files",
srcs = glob([
"*.js",
]),
target_compatible_with = select({
"//bazel/config:ppc_or_s390x": ["@platforms//:incompatible"],
"//conditions:default": [],
}),
visibility = ["//visibility:public"],
)

13
jstests/noPassthrough/timeseries/query/BUILD.bazel Normal file
View File

@ -0,0 +1,13 @@
load("@aspect_rules_js//js:defs.bzl", "js_library")
js_library(
name = "all_javascript_files",
srcs = glob([
"*.js",
]),
target_compatible_with = select({
"//bazel/config:ppc_or_s390x": ["@platforms//:incompatible"],
"//conditions:default": [],
}),
visibility = ["//visibility:public"],
)

13
jstests/noPassthrough/timeseries/stats/BUILD.bazel Normal file
View File

@ -0,0 +1,13 @@
load("@aspect_rules_js//js:defs.bzl", "js_library")
js_library(
name = "all_javascript_files",
srcs = glob([
"*.js",
]),
target_compatible_with = select({
"//bazel/config:ppc_or_s390x": ["@platforms//:incompatible"],
"//conditions:default": [],
}),
visibility = ["//visibility:public"],
)

13
jstests/noPassthrough/timeseries/ttl/BUILD.bazel Normal file
View File

@ -0,0 +1,13 @@
load("@aspect_rules_js//js:defs.bzl", "js_library")
js_library(
name = "all_javascript_files",
srcs = glob([
"*.js",
]),
target_compatible_with = select({
"//bazel/config:ppc_or_s390x": ["@platforms//:incompatible"],
"//conditions:default": [],
}),
visibility = ["//visibility:public"],
)

13
jstests/noPassthrough/timeseries/updates_deletes/BUILD.bazel Normal file
View File

@ -0,0 +1,13 @@
load("@aspect_rules_js//js:defs.bzl", "js_library")
js_library(
name = "all_javascript_files",
srcs = glob([
"*.js",
]),
target_compatible_with = select({
"//bazel/config:ppc_or_s390x": ["@platforms//:incompatible"],
"//conditions:default": [],
}),
visibility = ["//visibility:public"],
)

13
jstests/noPassthrough/timeseries/validate/BUILD.bazel Normal file
View File

@ -0,0 +1,13 @@
load("@aspect_rules_js//js:defs.bzl", "js_library")
js_library(
name = "all_javascript_files",
srcs = glob([
"*.js",
]),
target_compatible_with = select({
"//bazel/config:ppc_or_s390x": ["@platforms//:incompatible"],
"//conditions:default": [],
}),
visibility = ["//visibility:public"],
)

13
jstests/noPassthrough/timeseries/write/BUILD.bazel Normal file
View File

@ -0,0 +1,13 @@
load("@aspect_rules_js//js:defs.bzl", "js_library")
js_library(
name = "all_javascript_files",
srcs = glob([
"*.js",
]),
target_compatible_with = select({
"//bazel/config:ppc_or_s390x": ["@platforms//:incompatible"],
"//conditions:default": [],
}),
visibility = ["//visibility:public"],
)

2
jstests/sharding/add_shard_coordinator.js
View File

@ -169,7 +169,7 @@ const clusterParameter4 = {
const response = st.s.adminCommand({listShards: 1});
assert.commandWorked(response);
assert.eq(response.shards.length, 2);
assert(response.shards.some(shard => shard._id === "hagymasbab"))
assert(response.shards.some(shard => shard._id === "hagymasbab"));
}
jsTest.log("Non-first RS is unlocked after write");

6
jstests/sharding/query/release_memory.js
View File

@ -77,7 +77,7 @@ function testReleaseMemory({func, useSession, cursorsNum, pinCursor, unknownCurs
// Manually start a session so it can be continued from inside a parallel shell.
const sessionId = assert.commandWorked(mongosDB.adminCommand({startSession: 1})).id;
findCmd.lsid = sessionId;
sessionIdsArr.push(sessionId)
sessionIdsArr.push(sessionId);
}
jsTest.log(`Running find command ${i}`);
@ -86,7 +86,7 @@ function testReleaseMemory({func, useSession, cursorsNum, pinCursor, unknownCurs
let cursor = findRes.cursor;
assert.neq(cursor.id, NumberLong(0));
results.push(cursor.firstBatch);
cursorIdsArr.push(cursor.id)
cursorIdsArr.push(cursor.id);
}
let shard0DBFailpoint;
@ -122,7 +122,7 @@ function testReleaseMemory({func, useSession, cursorsNum, pinCursor, unknownCurs
assert.eq(cmdRes.cursorsAlive, []);
assert.eq(cmdRes.cursorsNotFound, []);
assert.eq(cmdRes.cursorsUnknown, []);
++cursorIdx
++cursorIdx;
}
// Use the function provided by the caller to call the releaseMemory command.

2
jstests/sharding/query/release_memory_fail.js
View File

@ -78,6 +78,6 @@ jsTest.log(`Running aggregate command`);
let aggregateRes = coll.aggregate([{$sort: {_id: 1}}], {cursor: {batchSize: 2}});
assertArrayEq({actual: aggregateRes._batch, expected: docs.slice(0, 2)});
assert.neq(aggregateRes._cursorid, NumberLong(0));
runTest(aggregateRes._cursorid, 2)
runTest(aggregateRes._cursorid, 2);
st.stop();

2
jstests/with_mongot/e2e/hybridSearch/ranked_fusion_lookup.js
View File

@ -16,7 +16,7 @@ import {
} from "jstests/with_mongot/e2e_lib/search_e2e_utils.js";
const collAName = "search_rank_fusion_collA";
const collBName = "search_rank_fusion_collB"
const collBName = "search_rank_fusion_collB";
const collA = db.getCollection(collAName);
const collB = db.getCollection(collBName);
collA.drop();

6
jstests/with_mongot/e2e/hybridSearch/ranked_fusion_on_view_rejected.js
View File

@ -18,9 +18,9 @@ const nDocs = 50;
let bulk = coll.initializeUnorderedBulkOp();
for (let i = 0; i < nDocs; i++) {
if (i % 2 === 0) {
bulk.insert({_id: i, a: "foo", x: i / 3})
bulk.insert({_id: i, a: "foo", x: i / 3});
} else {
bulk.insert({_id: i, a: "bar", x: i / 3})
bulk.insert({_id: i, a: "bar", x: i / 3});
}
}
assert.commandWorked(bulk.execute());
@ -76,7 +76,7 @@ const metaFieldName = "tags";
const timeseriesCollName = "rank_fusion_timeseries";
assert.commandWorked(db.createCollection(
timeseriesCollName, {timeseries: {timeField: timeFieldName, metaField: metaFieldName}}))
timeseriesCollName, {timeseries: {timeField: timeFieldName, metaField: metaFieldName}}));
const tsColl = db.getCollection(timeseriesCollName);
bulk = tsColl.initializeUnorderedBulkOp();

2
jstests/with_mongot/e2e/hybridSearch/ranked_fusion_union_with.js
View File

@ -18,7 +18,7 @@ import {
// Create multiple collections in order to correctly run an identity $unionWith query.
const collAName = "search_rank_fusion_collA";
const collBName = "search_rank_fusion_collB"
const collBName = "search_rank_fusion_collB";
const collA = db.getCollection(collAName);
const collB = db.getCollection(collBName);
collA.drop();