mirror
/
mongo
mirror of https://github.com/mongodb/mongo
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SERVER-93920: Final cleanup for enableMajorityReadConcern flag (#26455) 

GitOrigin-RevId: 6522f7217880ab960dfe300d8a2af5c4cb0da6a5
This commit is contained in:
Kishore Devireddy 2024-08-23 11:35:37 -07:00 committed by MongoDB Bot
parent a0d9444160
commit ec812cf73d
3 changed files with 0 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
debian/mongod.1 vendored
View File

@ -1854,18 +1854,6 @@ through a restart, update the value of
\fB\-\-oplogMinRetentionHours\f1\f1\&.
.RE
.PP
\fBmongod \-\-enableMajorityReadConcern\f1
.RS
.PP
\fIDefault\f1: true
.PP
Configures support for \fB"majority"\f1\f1 read concern.
.PP
Starting in MongoDB 5.0,
\fB\-\-enableMajorityReadConcern\f1\f1 cannot be changed
and is always set to \fBtrue\f1\&. In earlier versions of MongoDB,
\fB\-\-enableMajorityReadConcern\f1\f1 was configurable.
.PP
If you are using a three\-member primary\-secondary\-arbiter (PSA)
architecture, consider the following:
.RS

12
jstests/libs/replsettest.js
View File

@ -523,18 +523,6 @@ export class ReplSetTest {
this.awaitSecondaryNodes(timeout, secondaries, retryIntervalMS);
MongoRunner.runHangAnalyzer.enable();
} catch (originalEx) {
// There is a special case where we expect the (rare) possibility of unrecoverable
// rollbacks with EMRC:false in rollback suites with unclean shutdowns.
jsTestLog("Exception in 'awaitSecondaryNodes', checking for unrecoverable rollback");
if (connToCheckForUnrecoverableRollback) {
const conn = connToCheckForUnrecoverableRollback;
const statusRes = assert.commandWorked(conn.adminCommand({replSetGetStatus: 1}));
const isRecovering = (statusRes.myState === ReplSetTest.State.RECOVERING);
const hasNoSyncSource = (statusRes.syncSourceId === -1);
const cmdLineOptsRes = assert.commandWorked(conn.adminCommand("getCmdLineOpts"));
}
// Re-throw the original exception in all cases.
MongoRunner.runHangAnalyzer.enable();
throw originalEx;

2
src/mongo/db/repl/rollback_impl.cpp
View File

@ -1223,8 +1223,6 @@ StatusWith<RollBackLocalOperations::RollbackCommonPoint> RollbackImpl::_findComm
// Rollback common point should be >= the stable timestamp.
invariant(stableTimestamp);
if (commonPointOpTime.getTimestamp() < *stableTimestamp) {
// This is an fassert rather than an invariant, since it can happen if the server was
// recently upgraded to enableMajorityReadConcern=true.
LOGV2_FATAL_NOTRACE(51121,
"Common point must be at least stable timestamp",
"commonPoint"_attr = commonPointOpTime.getTimestamp(),