Commit Graph

11 Commits

Author SHA1 Message Date
stevegrossmongodb 68f755aff6 SERVER-90006 Fix up commit message validation logic (#21906)
Simplifies commit message validation to the simplest possible logic: a
straightforward regex on the PR title.

### Testing

* (Note: the testing procedure below is based on v6.0, not v5.0;
however, the logic at play will apply regardless of v5.0 vs v6.0)
* I spawned a new "parent" branch from `v6.0`:
(`stevegrossmongodb-v6.0-mq`)
* I established GitHub configuration and Evergreen project to match what
is used in v6.0.
* I created [this PR](https://github.com/10gen/mongo/pull/22012) to test
changes to the message validation logic.
* I ran this [PB for a commit with an invalid
title](https://spruce.mongodb.com/task/stevegrossmongodb_v6.0_mq_commit_queue_validate_commit_message_patch_834c3296202453d3e555b76f06e91eb505ebf006_663b98b0e2c04200074f34a4_24_05_08_15_22_29/logs?execution=0&logtype=all),
which correct failed
* I ran this [PB for commit with a valid
title](https://evergreen.mongodb.com/version/663b9f0b1542760007b768d2?redirect_spruce_users=true),
which correctly passed
* I ran the unit tests for validate_commit_message.py:
```
> python -m unittest buildscripts.tests.test_validate_commit_message
Found a commit without a ticket
SERVER-
Found a commit without a ticket
Revert SERVER-60
Found a commit without a ticket

Found a commit without a ticket
nonsense
.Must specify non-empty value for --message
..
----------------------------------------------------------------------
Ran 3 tests in 0.003s

OK
```

GitOrigin-RevId: ec0b8cfc4a6433b1ad4572e1b910e6ad71ee36fd
2024-05-08 18:25:27 +00:00
Juan Gu d3bba7af57 SERVER-82043 Enhancement of Commit Message Validation for 10gen/mongo Commits (#16160)
(cherry picked from commit 4dc9f17146)
2023-11-28 00:17:04 +00:00
David Bradford 305a7571c8 SERVER-59476: Allow for commit messages reverting wiredtiger imports
(cherry picked from commit 44ecd94334)
2021-09-20 17:43:32 +00:00
Lydia Stepanek 021430190c SERVER-48714 Send commit queue validation messages to stderr 2020-06-29 18:31:40 +00:00
Jim OLeary 09b9e93168 SERVER-45949 Update validate commit message client to work with new patch description standard 2020-04-30 09:21:47 +00:00
David Bradford 609270bc42 Revert "SERVER-45730 update commit queue message validation"
This reverts commit 54efb1c92a.
2020-04-29 00:59:49 +00:00
Jim OLeary 54efb1c92a SERVER-45730 update commit queue message validation 2020-04-28 10:33:12 +00:00
David Bradford 544cd7662f Revert "SERVER-45074 validate commit message against JIRA"
This reverts commit 1da2398abc.
2020-01-24 19:17:25 +00:00
Jim O'Leary 1da2398abc SERVER-45074 validate commit message against JIRA 2020-01-23 17:52:51 +00:00
Jim O'Leary 1f5591c7a0 SERVER-44338 validate commit message usability 2019-12-09 11:45:50 +00:00
Jim O'Leary 0ccd8da6ee SERVER-44338 validate commit message 2019-12-06 16:59:35 +00:00