mirror
/
nginx
mirror of https://github.com/nginx/nginx
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

HTTP/2: Fix window size calculation to consider data frames only. 

The frame type must be considered when subtracting the frame length from the window size. This code path can be reached if nginx receives an incomplete window update frame, where its length will be considered for the window size and an internal server error will occur along with the 'http2 negative window update' log, even if the remainder of the window update bytes arrives later.
This commit is contained in:
Micael Afonso 2025-11-25 14:03:45 +00:00
parent 6ed1188411
commit 1f07d7b7be
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/http/v2/ngx_http_v2.c
View File

@ -4342,7 +4342,9 @@ ngx_http_v2_read_client_request_body_handler(ngx_http_request_t *r)
window = buf->end - buf->start; window = buf->end - buf->start;
if (h2c->state.stream == stream) { if (h2c->state.stream == stream
&& h2c->state.handler == ngx_http_v2_state_read_data)
{
window -= h2c->state.length; window -= h2c->state.length;
} }