From 2dd029de129663f5529bbf82d22e844d46e46b6a Mon Sep 17 00:00:00 2001 From: Michael Yang Date: Tue, 16 Dec 2025 15:11:26 -0800 Subject: [PATCH] remove unnecessary code (#13502) slog is already lazily evaluated so this code is completely redundant --- model/bytepairencoding.go | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/model/bytepairencoding.go b/model/bytepairencoding.go index acb58743b..765331bf8 100644 --- a/model/bytepairencoding.go +++ b/model/bytepairencoding.go @@ -2,9 +2,7 @@ package model import ( "cmp" - "fmt" "iter" - "log/slog" "slices" "strings" @@ -245,14 +243,6 @@ func (bpe BytePairEncoding) Encode(s string, addSpecial bool) ([]int32, error) { return ids, nil } -type lazyIdsString struct { - ids []int32 -} - -func (l lazyIdsString) LogValue() slog.Value { - return slog.AnyValue(fmt.Sprint(l.ids)) -} - func (bpe BytePairEncoding) Decode(ids []int32) (string, error) { var sb strings.Builder for _, id := range ids { @@ -277,6 +267,6 @@ func (bpe BytePairEncoding) Decode(ids []int32) (string, error) { } } - logutil.Trace("decoded", "string", sb.String(), "from", lazyIdsString{ids: ids}) + logutil.Trace("decoded", "string", sb.String(), "from", ids) return sb.String(), nil }