Update clang-tidy configuration in format.sh and apply fixes for a new check (#1257)

* Update format.sh compiler options and add a check for clang-tidy

* Enable clang-tidy option to find inconsistent argument names

* Remove -Iassets from clang-tidy compiler options

src/code/audio_heap.c

@@ -1,7 +1,7 @@
 #include "ultra64.h"
 #include "global.h"
 
-void AudioHeap_InitSampleCaches(u32 persistentSize, u32 temporarySize);
+void AudioHeap_InitSampleCaches(u32 persistentSampleCacheSize, u32 temporarySampleCacheSize);
 SampleCacheEntry* AudioHeap_AllocTemporarySampleCacheEntry(u32 size);
 SampleCacheEntry* AudioHeap_AllocPersistentSampleCacheEntry(u32 size);
 void AudioHeap_DiscardSampleCacheEntry(SampleCacheEntry* entry);

src/code/code_800E4FE0.c

@@ -21,12 +21,12 @@ typedef enum {
     CHAN_UPD_STEREO           // 14
 } ChannelUpdateType;
 
-void func_800E6300(SequenceChannel* channel, AudioCmd* arg1);
+void func_800E6300(SequenceChannel* channel, AudioCmd* cmd);
 void func_800E59AC(s32 playerIdx, s32 fadeTimer);
 void Audio_InitMesgQueues(void);
 AudioTask* func_800E5000(void);
 void Audio_ProcessCmds(u32);
-void func_800E6128(SequencePlayer* seqPlayer, AudioCmd* arg1);
+void func_800E6128(SequencePlayer* seqPlayer, AudioCmd* cmd);
 void func_800E5958(s32 playerIdx, s32 fadeTimer);
 s32 func_800E66C0(s32 arg0);
 

src/overlays/actors/ovl_Boss_Dodongo/z_boss_dodongo.c

@@ -16,7 +16,7 @@ void BossDodongo_Walk(BossDodongo* this, PlayState* play);
 void BossDodongo_Inhale(BossDodongo* this, PlayState* play);
 void BossDodongo_BlowFire(BossDodongo* this, PlayState* play);
 void BossDodongo_Roll(BossDodongo* this, PlayState* play);
-void BossDodongo_SpawnFire(BossDodongo* this, PlayState* play, s16 arg2);
+void BossDodongo_SpawnFire(BossDodongo* this, PlayState* play, s16 params);
 void BossDodongo_Explode(BossDodongo* this, PlayState* play);
 void BossDodongo_LayDown(BossDodongo* this, PlayState* play);
 void BossDodongo_Vulnerable(BossDodongo* this, PlayState* play);

src/overlays/actors/ovl_Boss_Tw/z_boss_tw.c

@@ -65,7 +65,7 @@ void BossTw_Destroy(Actor* thisx, PlayState* play);
 void BossTw_Update(Actor* thisx, PlayState* play);
 void BossTw_Draw(Actor* thisx, PlayState* play);
 
-void BossTw_TwinrovaDamage(BossTw* this, PlayState* play, u8 arg2);
+void BossTw_TwinrovaDamage(BossTw* this, PlayState* play, u8 damage);
 void BossTw_TwinrovaSetupFly(BossTw* this, PlayState* play);
 void BossTw_DrawEffects(PlayState* play);
 void BossTw_TwinrovaLaugh(BossTw* this, PlayState* play);

src/overlays/actors/ovl_En_Horse/z_en_horse.c

@@ -929,7 +929,7 @@ void EnHorse_Freeze(EnHorse* this) {
     }
 }
 
-void EnHorse_ChangeIdleAnimation(EnHorse* this, s32 arg1, f32 arg2);
+void EnHorse_ChangeIdleAnimation(EnHorse* this, s32 anim, f32 morphFrames);
 void EnHorse_StartMountedIdleResetAnim(EnHorse* this);
 void EnHorse_StartMountedIdle(EnHorse* this);
 void EnHorse_StartGalloping(EnHorse* this);
@@ -1809,7 +1809,7 @@ void EnHorse_StartIdleRidable(EnHorse* this) {
     this->stateFlags &= ~ENHORSE_UNRIDEABLE;
 }
 
-void EnHorse_StartMovingAnimation(EnHorse* this, s32 arg1, f32 arg2, f32 arg3);
+void EnHorse_StartMovingAnimation(EnHorse* this, s32 animId, f32 morphFrames, f32 startFrame);
 
 void EnHorse_Idle(EnHorse* this, PlayState* play) {
     this->actor.speedXZ = 0.0f;

src/overlays/actors/ovl_En_Owl/z_en_owl.c

@@ -31,7 +31,7 @@ void func_80ACB3E0(EnOwl* this, PlayState* play);
 void EnOwl_WaitLWPreSaria(EnOwl* this, PlayState* play);
 void EnOwl_WaitLWPostSaria(EnOwl* this, PlayState* play);
 void func_80ACD4D4(EnOwl* this, PlayState* play);
-void func_80ACD130(EnOwl* this, PlayState* play, s32 arg2);
+void func_80ACD130(EnOwl* this, PlayState* play, s32 idx);
 void func_80ACBAB8(EnOwl* this, PlayState* play);
 void func_80ACD2CC(EnOwl* this, PlayState* play);
 void func_80ACAA54(EnOwl* this, PlayState* play);

src/overlays/actors/ovl_Object_Kankyo/z_object_kankyo.c

@@ -16,7 +16,7 @@ void ObjectKankyo_Destroy(Actor* thisx, PlayState* play);
 void ObjectKankyo_Update(Actor* thisx, PlayState* play);
 void ObjectKankyo_Draw(Actor* thisx, PlayState* play);
 
-void ObjectKankyo_SetupAction(ObjectKankyo* this, ObjectKankyoActionFunc func);
+void ObjectKankyo_SetupAction(ObjectKankyo* this, ObjectKankyoActionFunc action);
 void ObjectKankyo_Fairies(ObjectKankyo* this, PlayState* play);
 void ObjectKankyo_SunGraveSparkInit(ObjectKankyo* this, PlayState* play);
 void ObjectKankyo_Snow(ObjectKankyo* this, PlayState* play);