mirror/oot
1
0
Fork 0
mirror of https://github.com/zeldaret/oot synced 2026-09-04 02:19:37 -04:00
Code Issues Packages Projects Releases Wiki Activity

Document some bugs (#2806)

Browse Source 
* `@bug UB` in Item_Give and Item_CheckObtainability

* `@bug` on `envCtx->windSpeed` not initialized in Environment_Init
This commit is contained in:
Dragorn421
2026-08-29 16:14:49 +02:00
committed by GitHub
parent b4c29fa50b
commit 63e2ae59ec
2 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/code/z_kankyo.c
+1
View File
@@ -370,6 +370,7 @@ void Environment_Init(PlayState* play2, EnvironmentContext* envCtx, s32 unused)
envCtx->windDirection.x = 80;
envCtx->windDirection.y = 80;
envCtx->windDirection.z = 80;
//! @bug envCtx->windSpeed is not initialized.
envCtx->lightBlendEnabled = false;
envCtx->lightSettingOverride = LIGHT_SETTING_OVERRIDE_NONE;
src/code/z_parameter.c
+4 -1
View File
@@ -1399,6 +1399,7 @@ u8 Item_Give(PlayState* play, u8 item) {
s16 slot;
s16 temp;
//! @bug UB: For items that are not inventory items, the SLOT macro indexes gItemSlots out of bounds.
slot = SLOT(item);
if (item >= ITEM_DEKU_STICKS_5) {
slot = SLOT(sExtraItemBases[item - ITEM_DEKU_STICKS_5]);
@@ -1888,9 +1889,11 @@ u8 Item_Give(PlayState* play, u8 item) {
u8 Item_CheckObtainability(u8 item) {
s16 i;
s16 slot = SLOT(item);
s16 slot;
s16 temp;
//! @bug UB: For items that are not inventory items, the SLOT macro indexes gItemSlots out of bounds.
slot = SLOT(item);
if (item >= ITEM_DEKU_STICKS_5) {
slot = SLOT(sExtraItemBases[item - ITEM_DEKU_STICKS_5]);
}