mirror/oot
1
0
Fork 0
mirror of https://github.com/zeldaret/oot synced 2026-07-01 20:10:22 -04:00
Code Issues Packages Projects Releases Wiki Activity

Misc Cleanup 2 (#1007)

Browse Source 
* Cleanup `UNK_TYPE`, `UNK_PTR` usage

* Add some missing empty lines after declarations

* Remove some legacy comments from non-matching times

* Fix some grammar (mostly "it's"/"its")

* Use proper names for two symbols after ZAPD bugfix

* Cleanup `place_title_cards.xml`

* Use `NULL` to check against `D_8012D260` pointer

* Parentheses around some macro arguments

* wip proofread headers up to z64animation.h
This commit is contained in:
Dragorn421
2021-12-01 00:40:42 +01:00
committed by GitHub
parent 04a9d51e90
commit 669732abbe
104 changed files with 217 additions and 92 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/tutorial/other_functions.md
+1 -1
View File
@@ -154,7 +154,7 @@ typedef struct EnJj {
} EnJj; // size = 0x0314
```
We can eliminate the temp since it's use in a simple way one after the other. `this->unk308 = (s16) (this->unk308 - 0x66);` can be written as `this->unk308 -= 0x66;`.
We can eliminate the temp since it's used in a simple way one after the other. `this->unk308 = (s16) (this->unk308 - 0x66);` can be written as `this->unk308 -= 0x66;`.
In the `func_8003EBF8` we see that we should have at least made `this->childActor` a `DynaPolyActor*`, so that the last argument is its `bgId`. To avoid compiler warnings, we also need to cast the `Actor_SpawnAsChild` as such in Init,
```C