From 90c841c435463dc4601b371e2d19d7a6f7da4bac Mon Sep 17 00:00:00 2001 From: louist103 <35883445+louist103@users.noreply.github.com> Date: Wed, 8 Sep 2021 14:26:30 -0400 Subject: [PATCH] Mark a bug in En_Tana (#954) * bug * Re word the bug to be clearer * Small edits * Use Another wording --- src/overlays/actors/ovl_En_Tana/z_en_tana.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/overlays/actors/ovl_En_Tana/z_en_tana.c b/src/overlays/actors/ovl_En_Tana/z_en_tana.c index 30980a72a6..9e249a8f6a 100644 --- a/src/overlays/actors/ovl_En_Tana/z_en_tana.c +++ b/src/overlays/actors/ovl_En_Tana/z_en_tana.c @@ -29,7 +29,10 @@ const ActorInit En_Tana_InitVars = { NULL, }; -static char* sShelfTypes[] = { +//! @bug A third entry is missing here. When printing the string indexed by `params` for type 2, the +//! next data entry will be dereferenced and print garbage, stopping any future printing. +//! In a non-matching context, this can cause a crash if the next item isn't a valid pointer. +static const char* sShelfTypes[] = { "木の棚", // "Wooden Shelves" "石の棚", // "Stone Shelves" };