mirror/oot
1
0
Fork 0
mirror of https://github.com/zeldaret/oot synced 2026-09-07 03:09:59 -04:00
Code Issues Packages Projects Releases Wiki Activity

Cleanup NotePlaybackState (#1255)

Browse Source 
* Audio Cleanup

* more

* missed one

* Audio docs imported from MM

* Suggestions from Discord

* Small fix

* Fix sizes in z64audio.h

* numSamples

* Cleanup comments

* Revert overlap with soundFont PR

* revert Audio_AdsrUpdate cleanup (move to different PR)

* PR Suggestion

* Mainly typos

* PR suggestion, vol -> volume

* Better description

* Name sampling frequency

* A good number of PR suggestions

* Missed a suggestion

* More PR Suggestions

* Cleanup NotePlaybackState

* one more

* Add comments for new variable names

* Reverb samplePosInt

* Missed one

* Remove `Always set to 0`
This commit is contained in:
engineer124
2022-06-05 05:29:01 +10:00
committed by GitHub
parent 1a41694d58
commit bd4912a1bd
4 changed files with 15 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
include/z64audio.h
+4 -5
View File
@@ -496,8 +496,9 @@ typedef struct {
/* 0x18 */ SequenceLayer* wantedParentLayer;
/* 0x1C */ NoteAttributes attributes;
/* 0x40 */ AdsrState adsr;
// Majora's Mask suggests this struct contains portamento, vibratoState
} NotePlaybackState; // size = 0x60
/* 0x60 */ Portamento portamento;
/* 0x6C */ VibratoState vibratoState;
} NotePlaybackState; // size = 0x88
typedef struct {
struct {
@@ -539,10 +540,8 @@ typedef struct Note {
/* 0x00 */ AudioListItem listItem;
/* 0x10 */ NoteSynthesisState synthesisState;
/* 0x30 */ NotePlaybackState playbackState;
/* 0x90 */ Portamento portamento;
/* 0x9C */ VibratoState vibratoState;
/* 0xB8 */ char unk_B8[0x4];
/* 0xBC */ u32 unk_BC;
/* 0xBC */ u32 startSamplePos; // initial position/index to start processing s16 samples
/* 0xC0 */ NoteSubEu noteSubEu;
} Note; // size = 0xE0