1adf696588
Document z_horse.c and related actors ( #2278 )
...
* document z_horse.h
* .bss
* suggestions and more comments
* bss
* INGORACE -> INGO_RACE
* format header macros
* FIx incorrect type comparision
* EnInMode -> EnInStartMode
* R_EXITED_SCENE_RIDING_HORSE
2024-12-17 10:51:56 -05:00
0f27d2fea3
document func_8002F368 ( #2358 )
2024-12-14 14:59:22 -05:00
016aef482b
Document Culling ( #2318 )
...
* document culling
* format
* depth -> distance
* format
* var name
* new graph link
* rephrase actor flags
* tharo's comments + some more tweaks
* is this causing the problem?
* change wording
* cant scope the temp
* format
* dragorn review
* bad merge
* player -> camera in descriptions
* more its
* cadmic review
* goddamn it why do i have that habit
* projected
2024-12-13 08:12:52 -05:00
c21c3fe3da
Renamed EVENTCHKINF_33 ( #2326 )
...
* Renamed EVENTCHKINF_33
* Rename: Gave letter to King Zora
2024-12-09 23:53:41 -05:00
9305a71458
Document Mido functions, fields, and animations ( #2289 )
...
* Document `func_80AAA250`
new name: `EnMd_ReverseAnimation`
* rename `enum EnMdAnimation` > `enum EnMdAnimIndex`
* Document `struct EnMd` fields (and functions)
the list:
* `func_80AAAC78` -> `EnMd_TrackMessageState`
* `func_80AAAA24` -> `EnMd_UpdateAnimState_WithTalking`
* `func_80AAA92C` -> `EnMd_SetAnimState`
* `func_80AAA93C` -> `EnMd_UpdateAnimState`
* `func_80AAA274` -> `EnMd_UpdateAnimState1`
* `func_80AAA308` -> `EnMd_UpdateAnimState2`
* `func_80AAA39C` -> `EnMd_UpdateAnimState3`
* `func_80AAA474` -> `EnMd_UpdateAnimState4`
* `func_80AAA508` -> `EnMd_UpdateAnimState5`
* `func_80AAA5A4` -> `EnMd_UpdateAnimState6`
* `func_80AAA638` -> `EnMd_UpdateAnimState7`
* `func_80AAA6D4` -> `EnMd_UpdateAnimState8`
* `func_80AAA768` -> `EnMd_UpdateAnimState9`
* `func_80AAA7FC` -> `EnMd_UpdateAnimState10`
* `func_80AAA890` -> `EnMd_UpdateAnimState11`
* Document `func_80AAB158`
new name: `EnMd_UpdateTalking`
* Document `func_80034DD4` @ `z_actor.c`
new name: `Actor_SmoothStep_Attention`
* Document `func_80AAB5A4`
new name: `EnMd_SmoothStep_Attention`
* Document Mido's action functions
the list:
* `func_80AAB874` -> `EnMd_Idle`
* `func_80AAB8F8` -> `EnMd_Watch`
* `func_80AAB948` -> `EnMd_BlockPath`
* `func_80AABC10` -> `EnMd_ListenToOcarina`
* `func_80AABD0C` -> `EnMd_Walk`
* rename flag `temp2` -> `canUpdateTalking`
* (re)document Mido's animations
via blender and fast64
* marginally improve comments
* marginally improve comments
* actually, yes, let's name action functions as such
* Document eye textures as an enum
to clarify for `EnMd_UpdateEyes`
* rename `eyeIdx` -> `eyeTexIndex`
Mido has two eyes and different textures for them
* Undocument eye textures as an enum
i was wrong: `_Draw` function might not follow the eyes texture order
it is its own thing, like `enum EnMdBlinking` or nothing at all, yeah
* ugh, and fix a typo with blinking
rushing is no good
* drop the `Action` suffix
https://github.com/zeldaret/oot/pull/2289#discussion_r1837272286
* rename animation states as sequences
https://github.com/zeldaret/oot/pull/2289#discussion_r1837274923
* `func_80034DD4` -> `Actor_FadeInOut`
https://github.com/zeldaret/oot/pull/2289#discussion_r1837267267
* rename animation states as sequences
a continuation of b11a9e9942https://github.com/zeldaret/oot/pull/2289#discussion_r1838398475
* clarify a comment
* Document `actor.params` bits allocation
* apply review suggestions
* apply review suggestions
* apply review suggestions
* apply review suggestions
* apply review suggestions
2024-12-09 08:06:05 -05:00
bda5e94ded
Document Player Params ( #2307 )
...
* document player params
* better bgcamindex comment
* cant use -1 for condition
* fix match
* define for default bgcam
* doesnt work
* matches
* better comment
2024-12-08 14:56:01 -05:00
6735eb25d6
Rename EVENTCHKINF_02 ( #2322 )
...
* Rename EVENTCHKINF_02
* Rename to EVENTCHKINF_MIDO_DENIED_DEKU_TREE_ACCESS
2024-12-07 17:01:21 -05:00
3f703a39d9
Fix some more GCC warnings, mark some bugs based on GCC warnings ( #2309 )
...
* Fix some more GCC warnings, mark some bugs based on GCC warnings
* Weird formatting
* Suggested changes
* More weird indentation I guess
* UNREACHABLE() macro, add missing NORETURNs to fault_n64.c
* AVOID_UB for PAL path in z_file_nameset.c
* Remove comments about return types
* Remove temp no longer needed
2024-12-02 04:40:49 -05:00
53962a2cd8
Document Actor "Fidget Tables" ( #2287 )
...
* Document `func_80034F54` and related data
new name: `UpdateLimbOverrides`
reason:
- `0x814` and `0x940` constants
- `*_OverrideLimbDraw` functions
additionally:
- move constants into `z64animation.h`
- use these constant for existing formulas
- properly name corresponding actors' fields
- add occasional explicit limbs limit constants
* port over the MM "fidget" naming
* remove redundant comments
* move and rename `FIDGET_*` constants
* introduce a `FIDGET_SCALE` constant, as no other value is applied
* remove generally unrelated changes
* apply PR suggestion
Co-authored-by: mzxrules <mzxrules@gmail.com >
* fix (?) fidgetTable size
following the https://github.com/zeldaret/oot/pull/2287#discussion_r1832371833 suggestion
* remove an unused `struct EnMu` field @ `0x024A`
a continuation to the 211263295chttps://github.com/zeldaret/oot/pull/2287#discussion_r1833470468
* rename `overridePerLimb` -> `fidgetFrequency`
https://github.com/zeldaret/oot/pull/2287#discussion_r1837211873
* give better names to the constants
https://github.com/zeldaret/oot/pull/2287#discussion_r1837211873
* remove unnecesasry braces from a comment
https://github.com/zeldaret/oot/pull/2287#discussion_r1842642196
* make the comment multiline "officially"
* restore `limbIndex` naming for this PR
https://github.com/zeldaret/oot/pull/2287/commits/43afb7b7cb54aa7b086d8cb7fca4cffaa7d145bf#r1842644602
* apply a PR suggestion
https://github.com/zeldaret/oot/pull/2287#discussion_r1842787653
---------
Co-authored-by: mzxrules <mzxrules@gmail.com >
2024-11-27 13:50:44 -05:00
6239f8e0b3
Document Hookshot Attachment ( #2300 )
...
* document hookshot attachment
* change comment
* swap hookshot function comment
* remove comments
2024-11-21 19:46:49 -05:00
17edb82c0d
Decouple Debug Features From gc-eu-mq-dbg ( #2296 )
...
* rename OOT_DEBUG to DEBUG_FEATURES
* makefile changes
* add DEBUG_ASSETS
* fix DEBUG_FEATURES usages
* format
* fix errors
* review
* fix problem and review2
* review
* add DEBUG_FEATURES to DEBUG_ASSETS check
* review
* whoops
* format
2024-11-17 17:02:07 -05:00
8ce69c3ac9
Completely match ntsc-1.0/1.1 bss and add to CI ( #2294 )
2024-11-12 17:39:08 -05:00
f4210323a2
Document ACTOR_FLAG_SFX_FOR_PLAYER_BODY_HIT ( #2276 )
...
* name ACTOR_FLAG_HIT_PLAYER_THUMP_SFX
* ACTOR_FLAG_HIT_PLAYER_THUMP_SFX -> ACTOR_FLAG_SFX_FOR_PLAYER_BODY_HIT
2024-10-20 22:29:50 -04:00
e55e909477
Document ACTOR_FLAG_UPDATE_DURING_OCARINA and PLAYER_STATE2_USING_OCARINA ( #2277 )
...
* Document ACTOR_FLAG_UPDATE_DURING_OCARINA
* document PLAYER_STATE2_USING_OCARINA
* format
* comment tweak
* treat var as flag
2024-10-17 21:44:35 -04:00
2f54db142e
Rename RoomBehaviorType1 to RoomType ( #2271 )
...
* Rename RoomBehaviorType1 to RoomType
* suggestions
* Update include/z64scene.h
---------
Co-authored-by: fig02 <fig02srl@gmail.com >
2024-10-14 15:23:50 -04:00
53c57599a4
Name talking action related things ( #2260 )
...
* name talking related things
* Player_Action_TalkExchangeItem -> Player_Action_ExchangeItem
* splitting action stuff to new PR
* format
2024-10-10 22:04:30 -04:00
ba9c60552b
Player doc: some rotation logic/data ( #1443 )
...
* Docs: some player rotation logic/data
* Improve misleading comment
* rename temps
* unk_6AE_rotFlags
* format
* disasm metadata
2024-10-09 20:22:52 -04:00
bdc11c2894
[ntsc-1.0/1.1] Match "game engine" files ( #2244 )
...
* [ntsc-1.0/1.1] Match "game engine" files
* Use R_START_BTN_X/R_START_BTN_Y
* Comment obvious bugs
* Move Magic_Fill comments
* Move EVENTINF_HORSES_INDEX printf inside #if
* Replace "this function"
2024-09-30 15:52:38 -04:00
f7f38ff874
[PAL N64] Completely match pal-1.0 and pal-1.1 and add to CI ( #2246 )
...
* [PAL N64] Match pal-1.0 and pal-1.1 and add to CI
* bss fixes from Jenkins
2024-09-28 20:52:45 -04:00
3cea46a6c1
Z-Targeting Loose Ends ( #2217 )
...
* Z-Targeting loose ends
* format
* add stateflag comment
* typo
* unname PLAYER_STATE1_19 for now
* tweak parallel comment
* one more tweak
2024-09-24 05:00:38 -04:00
56981d5297
Document Player Knockback related functions ( #1601 )
...
* document knockback related functions
* rotation -> yRot
* implement some changes
* Renames and comments
* mq bss
* format
* Intangibility and Invulnerability
* bss
* .bss
* add #pragma increment_block_number to z_en_item00.c
* .bss
2024-09-23 18:31:00 -04:00
fcd5745d40
PLAYER_STATE1_ACTOR_CARRY -> PLAYER_STATE1_CARRYING_ACTOR ( #2213 )
2024-09-21 18:25:19 -04:00
cc0b1bb127
PLAYER_STATE1_DEAD (#2204 )
...
* PLAYER_STATE1_DEAD
* change comment
* format
2024-09-17 08:21:47 -04:00
8f0e2fc29c
Name PLAYER_STATE1_CHARGING_SPIN_ATTACK ( #2203 )
...
* name charge state flag
* format
2024-09-16 17:14:29 -04:00
c91e62f000
Document zTargetActiveTimer ( #2200 )
...
* document zTargetActiveTimer
* edit comments
* Update src/overlays/actors/ovl_player_actor/z_player.c
Co-authored-by: cadmic <cadmic24@gmail.com >
* capitalization
---------
Co-authored-by: cadmic <cadmic24@gmail.com >
2024-09-16 12:34:23 -04:00
e658bed27e
Hostile Lock-On ( #2193 )
...
* document flag and functions
* format
* adjust comment
* make the comment more public-facing-friendly
2024-09-13 14:49:55 -04:00
f089adf20c
[ntsc-1.2] Match ntsc-1.2 BSS and add to CI ( #2187 )
...
* Match ntsc-1.2
* Add ntsc-1.2 to CI
* Apply fixes from Jenkins
* Promote ntsc-1.2 to "supported" in Makefile
* Declare D_80858AD8 as a u64 array
* Tweak wording
* Hopefully make ntsc-1.2 bss more stable
* Restore segmented_address.h include
2024-09-12 14:10:43 -04:00
09c1816e2d
Add OOT_PAL_N64 and move other shorthands to versions.h ( #2188 )
...
* Move definitions of OOT_NTSC/OOT_PAL/OOT_MQ to versions.h
* Add PAL_N64 shorthand
2024-09-12 05:24:31 -04:00
5441559b30
Cleanup gSPMatrix, rename Matrix_New -> Matrix_Finalize, add MATRIX_FINALIZE_AND_LOAD ( #1983 )
...
* clean up gSPMatrix usage
* add weird hybrid macro gSPMATRIX_SET_NEW
* Matrix_NewMtx, MATRIX_NEW -> Matrix_Finalize, MATRIX_FINALIZE
* gSPMATRIX_SET_NEW -> MATRIX_FINALIZE_AND_LOAD
* format
2024-09-11 16:59:23 +09:00
900c2f0f68
Name PLAYER_STATE1_ACTOR_CARRY ( #2173 )
...
* actor carry flag
* format and add comments
* comment changes
2024-09-08 17:43:27 -04:00
c7ec814d78
[headers 9] Add src/libc64/ and new "z64" rand.h ( #2164 )
...
* rand.h -> libc64/qrand.h
* Add rand.h with z64 rand wrappers
* yeet comment
* code/rand.c -> libc64/qrand.c
* fixup
* move libc64 source to src/libc64/
* fix
* bss
* update file splits disasm metadata
2024-09-08 17:11:41 -04:00
a903f8b8bc
Document ACTOR_FLAG_SFX_ flags and functions ( #2162 )
...
* Document `ACTOR_FLAG_SFX_` flags and functions
* format
2024-09-08 16:26:01 -04:00
2056ae5f1a
Document Attention/Lock-on Related Actor Flags ( #2161 )
...
* document actor flags 0, 2, 3, and 27
* format
* fly -> hover
* wodring
2024-09-07 17:53:48 -04:00
88c4475967
Target -> Attention (System Rename) ( #2149 )
...
* TargetContext -> Attention
* targetCtx -> attention
* Target_ -> Attention_
* FindTargetableActor -> FindActor
* targetableActorP -> attentionActorP
* data vars (and 1 function I missed)
* targetMode -> attentionRangeType
* attention range enum comments
* ATTENTION_RANGE_
* attention range data
* TargetColor -> AttentionColor
* missed one
* fixup color variables
* targetArrowOffset -> lockOnArrowOffset
* focus pos comment
* targetPriority -> attentionPriority
* assets
* loose-ends
* Attention System Description
* format
* skj range type
* enemy bgm
2024-09-07 09:23:04 -04:00
ed870e051d
[ntsc-1.2] Match more draw functions ( #2145 )
...
* Match z_vr_box.c
* Match TitleCard_Draw
* Match z_player_lib.c?
* Match Lights_Draw
2024-09-06 22:48:17 -04:00
02816c410c
T() macro 8 ( #2142 )
...
* T() macro in fault
* T() macro in game.c, gfxprint.c
* T() macro in ucode_disas.c
* T() macro in z_actor.c
* T() macro in z_message.c
* push fault key combo T()
* z_message T: koko -> "here"
* format
2024-09-06 22:00:12 -04:00
bb6177e936
Document Target_ShouldReleaseLockOn [Target Docs 8/8] ( #2135 )
...
* target range and leash docs
* format
2024-09-05 12:44:06 -04:00
acb5c7f20c
Update Room Documentation ( #2015 )
...
* Update Room Documentation
* Write more complete documentation, implement suggestions.
* Function name changes; minor comment tweaks
* nit
* Resolve Dragorn fixes
* Resolve Fig suggestions, fix comment wording
* fix bss, fig suggestion
* bss
2024-09-05 21:08:21 +09:00
dbb059c6a7
Target Mode Enum [Target Docs 7/?] ( #2133 )
...
* TargetMode Enum
* format
* add default comment
* bss
* bss 2
* fix bss 3
2024-09-04 23:46:03 -04:00
6051251c92
istargeted -> islockedon ( #2132 )
2024-09-04 19:26:23 -04:00
907e440f3a
unk_664 -> focusActor [Target Docs 5/?] ( #2126 )
...
* unk_664 -> focusActor
* capitalization
* missed a temp
2024-09-05 03:33:30 +09:00
c8cafdc93e
Rename FaultDrawer_ functions to Fault_ ( #2113 )
...
* Rename FaultDrawer_ functions to Fault_
* Rename FaultDrawer_Init to Fault_InitDrawer
2024-09-03 23:43:06 -04:00
45158f57d6
Document Target_Update [Target Docs 4/?] ( #2123 )
...
* document Target_Update
* add comments
* try CLAMP (dbg is ok but ci will check retail)
2024-09-03 20:58:39 -04:00
6f396e7cc8
Target System Docs: Actor Searching [3/?] ( #2120 )
...
* document target actor searching
* missed something
* review
* mzx review
2024-09-03 00:02:24 -04:00
2b25c31588
Document Target_Draw [Target Docs 2/?] ( #2115 )
...
* document Target_Draw
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com >
* fix missed renames
* retail fix
* another fix
---------
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com >
2024-09-01 16:02:13 -04:00
a21a59c4b5
Target Docs [1/?] ( #2110 )
...
* Target Docs Part 1
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com >
* review
---------
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com >
2024-08-31 15:10:25 -04:00
68818044db
[ntsc-1.2] Decompile fault.c ( #2046 )
...
* wip decomp ntsc-1.2 fault.c
* more ntsc-1.2 fault.c
* decompiled fault_v1.c
* name fault_v1 functions, wip
* try to clean up build system (two versions of the fault system coexisting)
* cleanup
* cleanup2
* fix build gc-eu-mq-dbg
* match 2 more, ty anon
* matched
* review
* more review
* fixup spec
* `(uintptr_t)ptr op int` instead of `ptr op (type*)int`
* move fault.h out of global headers, properly include fault.h and versions.h
* compile all fault_*.c files regardless of version by overriding FAULT_VERSION
* n64 FaultMgr.framebuffer s32 -> u16*
* FaultMgr.framebuffer -> FaultMgr.fb
* make gc FaultMgr.fb u16* (yes, thats everything)
* bss
* fix Fault_Printf return type
* noop FaultDrawer_SetFontColor, FaultDrawer_SetCharPad in fault_n64
* fault_color_ stuff is only for fault_gc
* rm empty line in makefile
* I guess `D_80105A90_unknown` is `[sg]TotalAllocFailures`
* bss
* `Fault_WaitInput` -> `Fault_WaitForInput`
* use named fault funcs in pointers array
* FAULT_OOT{N64,GC} -> FAULT_{N64,GC}
* Apply suggestions from code review
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com >
Co-authored-by: Anghelo Carvajal <angheloalf95@gmail.com >
* review, sync fault_{gc,n64}
* Apply `FPCSR_CE` suggestions from code review
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com >
---------
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com >
Co-authored-by: Anghelo Carvajal <angheloalf95@gmail.com >
2024-08-28 09:38:42 +02:00
3e516f48f3
Match more ntsc-1.2 overlay draw functions ( #2061 )
...
* Match more overlay draw functions
* Review
2024-08-20 16:22:05 -04:00
d191e8714e
Allow building the Debug ROM without debug features ( #2052 )
...
* Allow building the Debug ROM without debug features
* Fix bss
* Add comment
* Reword again
* Fix bss
2024-08-19 23:58:31 +02:00
fda0e6ad4b
[ntsc-1.2] Match z_construct.c, z_draw.c, z_kaleido_setup.c and partially z_actor.c ( #2039 )
...
* func_80033C30
* Interface_Init
* z_draw.c
* KaleidoSetup_Destroy , n64dd.h
* z_kaleido_setup.c
* add n64dd files to spec
according to tools/disasm/ntsc-1.2/files_code.csv , they're between irqmgr.o and fault.o
putting them before or after malloc_debug.o in the spec is an arbitrary choice
2024-08-14 22:05:41 -04:00
mzxrules