From 4a9075d9f72b3584e0edc18e44e7203bf9b1559c Mon Sep 17 00:00:00 2001
From: Ryan Dwyer <ryandwyer1@gmail.com>
Date: Mon, 8 May 2023 21:29:42 +1000
Subject: [PATCH] Replace strcpy(buf, "")

---
 src/game/activemenu.c      | 6 +++---
 src/game/menuitem.c        | 1 -
 src/game/mplayer/mplayer.c | 2 +-
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/game/activemenu.c b/src/game/activemenu.c
index e06dee195..d99cf625b 100644
--- a/src/game/activemenu.c
+++ b/src/game/activemenu.c
@@ -432,7 +432,7 @@ void amGetSlotDetails(s32 slot, u32 *flags, char *label)
 		}
 
 		if (g_AmMenus[g_AmIndex].invindexes[slot] >= invGetCount()) {
-			strcpy(label, "");
+			label[0] = '\0';
 		} else {
 			if (invGetWeaponNumByIndex(g_AmMenus[g_AmIndex].invindexes[slot]) == WEAPON_CLOAKINGDEVICE) {
 				// Special case: "Cloak %d"
@@ -458,7 +458,7 @@ void amGetSlotDetails(s32 slot, u32 *flags, char *label)
 		}
 		break;
 	case 1: // Function screen
-		strcpy(label, "");
+		label[0] = '\0';
 
 		if (slot == 4) {
 			strcpy(label, langGet(L_MISC_171)); // "Function"
@@ -486,7 +486,7 @@ void amGetSlotDetails(s32 slot, u32 *flags, char *label)
 		}
 		break;
 	default: // Orders screen
-		strcpy(label, "");
+		label[0] = '\0';
 
 		if (g_MissionConfig.iscoop) {
 			if (slot == 4) {
diff --git a/src/game/menuitem.c b/src/game/menuitem.c
index 15479b32f..2d77bcf18 100644
--- a/src/game/menuitem.c
+++ b/src/game/menuitem.c
@@ -2248,7 +2248,6 @@ static Gfx *menuitemSliderRender(Gfx *gdl, struct menurendercontext *context)
 	gdl = textRenderProjected(gdl, &x, &y, label, g_CharsHandelGothicSm, g_FontHandelGothicSm, colour, context->width, context->height, 0, 0);
 
 	if ((context->item->flags & MENUITEMFLAG_SLIDER_HIDEVALUE) == 0) {
-		strcpy(buffer, "");
 		sprintf(buffer, "%d\n", slidervalue);
 
 		if (context->item->handler != NULL) {
diff --git a/src/game/mplayer/mplayer.c b/src/game/mplayer/mplayer.c
index dec57340c..a064ecb02 100644
--- a/src/game/mplayer/mplayer.c
+++ b/src/game/mplayer/mplayer.c
@@ -468,7 +468,7 @@ void mpInit(void)
 	g_MpSetup.fileguid.fileid = 0;
 	g_MpSetup.fileguid.deviceserial = 0;
 
-	strcpy(g_MpSetup.name, "");
+	g_MpSetup.name[0] = '\0';
 
 	for (i = 0; i < 6; i++) {
 		mpPlayerSetDefaults(i, false);