From 2577871c94a173768503c15eade891269acdd348 Mon Sep 17 00:00:00 2001 From: Yanis42 <35189056+Yanis42@users.noreply.github.com> Date: Tue, 16 Apr 2024 00:58:58 +0200 Subject: [PATCH] improved vfunc_20 a bit --- src/14_Land/Actor/ActorRupee.cpp | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/14_Land/Actor/ActorRupee.cpp b/src/14_Land/Actor/ActorRupee.cpp index 0fb129d7..60fac224 100644 --- a/src/14_Land/Actor/ActorRupee.cpp +++ b/src/14_Land/Actor/ActorRupee.cpp @@ -355,15 +355,10 @@ void ActorRupee::vfunc_18(bool param1) { func_ov00_0207a1c8(&mUnk_0a4.mUnk_00, param1, &mPos); } +#define VFUNC20_COND (param1 ? mUnk_0a4.mUnk_01 : mUnk_0a4.mUnk_00) void ActorRupee::vfunc_20(bool param1) { - if (param1 ? mUnk_0a4.mUnk_01 : mUnk_0a4.mUnk_00) { - if (mUnk_130 == 2 && mActiveFrames % 8 < 4) { - return; - } - - if (param1 ? mUnk_0a4.mUnk_01 : mUnk_0a4.mUnk_00) { - func_ov14_0213b5f4(mRupeeId, param1, &mPos, true); - } + if (VFUNC20_COND && !(mUnk_130 == 2 && mActiveFrames % 8 < 4) && VFUNC20_COND) { + func_ov14_0213b5f4(mRupeeId, param1, &mPos, true); } }