f559fac24e
Merge pull request #2347 from mrgriffin/pret-text-260720
...
Minor text cleanups
2026-09-01 02:26:56 -04:00
633b1c9c2f
Replace item define list with enum
2026-09-01 02:04:27 -04:00
c65e93f20a
Move StartMonScrollingBgMask to battle_anim_utility_func.c ( #2330 )
...
So we don't need to do any extern shenanigans.
2026-08-26 11:40:45 +01:00
f92fa0b803
text.h brace style
2026-07-20 13:42:59 +01:00
01a274bb10
s/SKIP/SKIP_TO
...
CLEAR: takes number of pixels to clear
CLEAR_TO: takes x position to clear until
Therefore:
SKIP_TO: takes x position to skip until
2026-07-20 13:42:58 +01:00
c948da6df8
Remove PokenavListSub ( #2317 )
2026-06-26 22:50:18 -04:00
ebd27892ff
comparison operators now use enum instead of raw numbers ( #2334 )
2026-06-24 13:43:43 -04:00
ac35f6695d
Generate ENCOUNTER_CHANCE constants separately from encounter data
2026-06-23 23:27:02 -04:00
24596b0aa9
Merge pull request #2282 from ketsuban/how-many-status1-bits-are-there-again
...
Mention the width of RAM variables in constants/battle.h
2026-06-23 23:23:05 -04:00
e56dfdbc2b
s/Pp/PP/g
2026-06-19 09:26:15 +01:00
5a9f566bbd
Minor cleanups ( #2318 )
...
* Cleanup commas in .macro
* Cleanup src/item_use.c post #2313
* Cleanup src/fieldmap.c post #2314
* s/int/s32/g in fieldmap.h/fieldmap.c
* Cleanup src/battle_pyramid.c post #2310
* Cleanup src/battle_anim_effects_2.c post #2266
2026-06-17 15:36:35 +01:00
5b621f1819
Fix MoveItemSlotInList fakematch ( #2260 )
...
Co-authored-by: AZero13 <83477269+SiliconA-Z@users.noreply.github.com >
2026-06-17 14:48:29 +01:00
059268950f
s/int/s32/g in fieldmap.h/fieldmap.c
2026-06-17 14:35:40 +01:00
80f23292d2
Make data1 and learnMoveState an array to prevent UB ( #2284 )
...
Fixes https://github.com/pret/pokeemerald/issues/2102
2026-06-17 14:09:24 +01:00
305a831b2d
Use DMA Macros more consistently ( #2309 )
...
I also had to move the check to first for some places to match.
Co-authored-by: Mike-Goutokuji <83477269+mike-goutokuji@users.noreply.github.com >
2026-06-17 11:51:53 +01:00
2da84f7e3c
Simplify and const-correct fieldmap.c ( #2314 )
...
Changing MapGridGetMetatileIdAt to output int also reduces number of casts
Co-authored-by: Mike-Goutokuji <83477269+mike-goutokuji@users.noreply.github.com >
2026-06-17 11:37:16 +01:00
0eda6d14e9
Add TextPrinterCallback ( #2306 )
2026-06-11 18:54:19 +01:00
4b6a69ae24
Rename daycare special to account for string side effects ( #2287 )
2026-06-04 12:08:01 +01:00
0d3100185e
Rename mass outbreak show to distinguish from savefile outbreakDaysLeft ( #2288 )
2026-05-15 21:51:57 -04:00
98ed1a6e6e
Merge pull request #2140 from AsparagusEduardo/_pret/BtlController_EmitTwoReturnValues
...
`BtlController_EmitTwoReturnValues` cleanup
2026-04-21 16:01:35 +01:00
c314cc1e52
Merge pull request #2231 from GriffinRichards/match-call-rematch
...
Document gym leader match call texts
2026-04-21 15:57:49 +01:00
1dcb9c75b9
Merge pull request #2212 from Mitsunee/ismondisobedient-enum
...
Added enum for IsMonDisobedient
2026-04-21 15:57:06 +01:00
a09b745176
Extract GiveGiftRibbonToParty from file about size records ( #2240 )
2026-04-21 15:52:51 +01:00
31552457e0
Merge pull request #2241 from rayrobdod/compare_size_return_names
...
Name values used by CompareMonSize
2026-04-21 15:52:36 +01:00
0661846d65
Mention the width of RAM variables in constants/battle.h
...
Something I've found myself needing to know when fiddling with status conditions and weather is how many additional bits I have available to me. Having it mentioned explicitly in the header itself would be convenient to save chasing through a layer of indirection to find out.
2026-04-08 21:17:35 +01:00
25ffb2c12c
Add enum for Elevations ( #2233 )
2026-02-20 01:17:42 -05:00
064ca5c243
Added macro for Surf/Muddy Water's animation ( #2232 )
2026-02-06 10:08:20 -05:00
926488b69a
Document gym leader match call texts
2026-02-01 13:36:33 -05:00
e09423fadf
Document battle_anim_normal.c
2026-01-19 09:16:37 +00:00
a5ee0f2727
ItemTMHMOrEvolutionStone enum ( #2192 )
2026-01-02 20:59:12 +00:00
b11741855d
Add enum for battle script opcodes ( #2222 )
2026-01-02 20:19:01 +00:00
349da0484b
Document m4a xcmd_0C
2025-12-27 01:11:40 +00:00
02c44242f8
Added bugfix for missing no weather case in Cmd_weather_get ( #2203 )
2025-12-09 22:22:08 -05:00
f0e351b33d
Merge pull request #2171 from ShinyDragonHunter/unused_funcs
...
Label unused functions in siirtc.c, m4a.c & rtc.c with the "UNUSED" attribute
2025-12-09 22:14:57 -05:00
bcd5735f76
Merge pull request #2176 from NTx86/gba-fix-object-event-range-type
...
Change rangeX and rangeY to u8 in ObjectEvent struct
2025-12-09 21:57:06 -05:00
83b05d5efa
Merge pull request #2201 from mrgriffin/pret-flag-registered-wally
...
Fix FLAG_REGISTERED_WALLY
2025-12-09 21:43:30 -05:00
8797a07e55
Added enum for IsMonDisobedient
2025-11-29 11:22:16 +01:00
c0569cd529
Standardize spelling of "synchronize"
2025-11-19 21:14:45 +01:00
73ec0813e1
Standardize spelling of "canceler"
...
just a quick grep -r and regex substitution, but didn't see anything wrong in the diffs during a quick proofread
2025-11-15 12:11:32 +01:00
c466dce996
Fix FLAG_REGISTERED_WALLY
2025-11-06 13:40:22 +00:00
d1d5435487
Improve undefined map assembler messages ( #2196 )
2025-10-29 21:34:03 -04:00
7fd0029ed7
Add typedefs for MAPSEC and METLOC values ( #2183 )
...
Added typedefs: mapsec_t, metloc_t, and variants for MAPSEC and METLOC values. There are some rough edges that could do with smoothing out, but for now, this gets us close to ideal with a ROM that compares equal.
Per feedback, all typedefs to mention the underlying type within the typedef name. The documentation comments reflect and explain the naming convention.
Updated comments to reflect the fact that we're no longer using SET8 for a Pokemon's met locations, in favor of a new macro (added by this PR) that adjusts to match the width of whatever is being set.
2025-10-19 17:37:13 +01:00
0965dffe70
Use TaskFunc wherever posible ( #2188 )
2025-10-18 17:53:50 +01:00
f4f7c38255
Use MainCallback wherever posible ( #2184 )
2025-10-14 09:41:27 +01:00
d6714add6f
Change rangeX and rangeY to u8 in ObjectEvent struct
2025-08-31 20:36:09 +03:00
208f97e1e3
Rename passive damage hitmarker ( #2174 )
2025-08-21 13:43:19 +01:00
6cc878919d
Identify unused functions in siirtc.c, m4a.c & rtc.c
...
"SiiRtcSetAlarm" in siirtc.c, the "FormatHex" functions in rtc.c and "UnusedDummyFunc", m4aSongNumStartOrContinue", m4aSongNumContinue", "MusicPlayerJumpTableCopy" in m4a.c are all unused in vanilla so they've been changed to use the "UNUSED" attribute.
2025-08-09 20:57:59 +01:00
0dfec24967
Allow names for voicegroups and use a macro for use with drumsets ( #2149 )
...
mid2agb has been modified to allow more than just numbers when naming voicegroups and voicegroups have been renamed to match. A "voice_group" macro has been set up with a optional parameter for the starting note will shift the offset by the specified amount * 0xC which is the length of 1 voice in a voicegroup. All drumset voicegroups have a "starting_note" of 36.
2025-07-30 19:43:08 +01:00
6f8a1bbdb8
Add pack/unpack for data masks ( #2163 )
2025-07-23 09:28:34 +01:00
80b9c23d0a
Fix RL compressed data alignment
...
`RLUnComp`, like `LZ77UnComp`, expects the source data to be word-aligned.
So, to mirror how lz-compressed data is defined as `u32[]` to enforce
word-alignment, this changes rl-compressed data to be defined as `u32[]`
to enforce word-alignment.
2025-07-06 13:49:47 -04:00
GriffinR