psxrecomp

mirror/psxrecomp

Fork 0

mirror of https://github.com/RetroPortingToolKit/psxrecomp synced 2026-10-26 02:11:36 -04:00

Commit Graph

Author	SHA1	Message	Date
Matthew Stanley	3787120488	Recover saturated horizontal projections in opt-in native-wide rendering	2026-10-02 16:00:02 -07:00
Matthew Stanley	e6ce5006b4	docs: move root and stale docs into docs/ and docs/internal/ The repository root carried seven markdown files that were not onboarding material, plus two that had been superseded by the code they described. This sorts them: reader-facing docs to docs/, working notes to docs/internal/, and the two superseded ones merged into the docs that replaced them. Moved to docs/: WIDESCREEN.md, ENHANCEMENTS.md, TCP_COMMANDS.md Moved to docs/internal/: PRINCIPLES.md, ISSUES.md, DEBUG.md, GTE_LM_FIX.md, and from docs/: bios-hardening.md, overlay-status.md, overlay-plan.md, overlay-recompilation-design.md, overlay-discovery.md, TOMBA2_EXC_CONSULT_RESPONSE.md, CASE_A_AOT_GAP.md, audit_inventory.md Moved to docs/internal/upstream/: UPSTREAM_2026-08-20.md The root keeps only what belongs there: README.md, CONTRIBUTING.md, LICENSE, CLAUDE.md, THIRD_PARTY_ATTRIBUTION.md, RELEASE_NOTES.md, the dotfiles and psxrecomp_cli.py. MERGES SPLITGEN_MIGRATION.md folded into docs/BUILDING.md as "Split generated C". Its migration instructions were stale in a way that mattered: it told every game repo to hand-edit its CMakeLists and add a file(GLOB ...) over <serial>_full.c, but runtime/runtime.cmake now does that itself. GEN_FULL_GLOB is a multi-value argument of psxrecomp_add_game_runtime(); the loop at runtime.cmake:1985 makes each pattern absolute against CMAKE_CURRENT_SOURCE_DIR, expands it with file(GLOB), and concatenates the hits into GAME_GENERATED_FULL_C. So a title names the pattern and gets however many shards a regeneration produced. The rewritten section describes that, the two-step fallback when the globs match nothing (GEN_FULL_FALLBACK, else <serial>_full.c derived from the dispatch marker by substituting _dispatch.c), and the one caveat the code actually has: that file(GLOB) is plain, not CONFIGURE_DEPENDS, so a regeneration which changes the shard COUNT needs a re-configure to be seen. psxrecomp-toml-readme.md folded into docs/GAME_PROJECT_SETUP.md as "EXE-only autofill (psxrecomp-toml)", placed after "Disc autofill (probe_disc.py)" and before "Project Studio" so the two autofill paths sit together. Its documented flags were checked against the usage text in recompiler/src/main_toml.cpp:28-42 and against the argument parser at :150-165 -- all seven options match with no drift, so the flag list is reproduced as-is. Added a pointer that probe_disc.py is preferable when a cue exists, since that tool does the same EXE-header work plus disc identity and netplay gates. FUNCTIONAL FIXES tools/gen_tcp_commands.py wrote to REPO/"TCP_COMMANDS.md". After the move that path does not exist, so the generator would have created a new stray root file and --check would have failed against it forever. Retargeted to REPO/"docs"/"TCP_COMMANDS.md", along with the seven docstring and message strings that name the path. Running it surfaced two further problems, both fixed here: The doc was genuinely stale -- pre-existing drift, not introduced by this commit (the moved file is byte-identical to origin/master, and no debug-server command table is touched here). Four commands registered since the last regeneration were missing from the index -- cdrom_timing_dump, savestate_status, ws_ui_groups, xprobe_watch -- and scanline had gained a backend. Regenerated: 307 -> 311 commands, and the change is confined to the AUTOGEN block (the hand-written head and tail are byte-identical to master). tools/gen_tcp_commands.py --check now exits 0. * DOC.write_text() has no newline argument, so Python translated every newline to os.linesep. On Windows that rewrote all 585 lines of the file to CRLF and turned a four-line index update into a whole-file diff -- measured: 589 CRLF / 0 LF after a run, against 0 CRLF / 585 LF in the repo. Now written through an explicit newline="" handle, verified to leave the file at 0 CRLF. runtime/include/debug_server.h:9 and runtime/src/debug_server.c:8 cited "TCP.md and DEBUG.md". TCP.md has never existed in this repo under that name; both now name docs/TCP_COMMANDS.md and docs/internal/DEBUG.md. LINK AND REFERENCE FIXES Every inbound reference to a moved file was located by grepping each basename across the whole tracked tree, not just the markdown. Markdown hrefs in README.md, CONTRIBUTING.md, docs/ARCHITECTURE.md, docs/COMPILING_OVERLAYS.md, docs/AOT_OVERLAY_PLAN.md, docs/RELOCATION_MANIFEST_FORMAT.md, docs/config_schema.md, docs/OVERLAY_XREF.md, docs/TCP_COMMANDS.md and several docs/internal/ files now point at the new locations; where two files became siblings under docs/internal/ the path was shortened rather than lengthened (bios-hardening.md's reference to overlay-discovery.md, for instance). docs/COMPILING_OVERLAYS.md's "in this folder" phrasing was wrong once two of the three files it listed moved, so it now names internal/ explicitly. 24 source-comment mentions of ENHANCEMENTS.md sections G1.x across 19 files (recompiler, runtime, cmake) were retargeted to docs/ENHANCEMENTS.md with the section numbers untouched. docs/SHADOW_ENHANCEMENTS.md is a DIFFERENT file and was deliberately excluded. 20 rationale strings citing docs/CASE_A_AOT_GAP.md across the four recompiler/seeds/.json files were updated. Done as a byte-level substring replacement rather than a JSON round-trip: two of those files are stored with CRLF endings and two with LF, and re-serializing them reformatted 5,700 lines. The byte-level version changes exactly 20 lines and each file still parses. References that look similar but point elsewhere were deliberately left alone, and are worth naming so a future pass does not "fix" them: "recomp-template PRINCIPLES.md" / "NES recomp template PRINCIPLES.md" in CLAUDE.md:43, docs/SHADOW_ENHANCEMENTS.md:28, docs/internal/HLE_SCHEDULER_CARVEOUT_PLAN.md:5, runtime/src/debug_server.c:4934 and tools/parity_diff.py:8 are a different repository's file. Only the five that mean this repo's PRINCIPLES.md were updated. * Every remaining bare ISSUES.md mention is a GAME repo's tracker (MegaManX6Recomp 2/7/8/9, TombaRecomp 6), not this repo's. * docs/disc-speed.md:4,54,56 and docs/internal/bios-hardening.md:5 name overlay-discovery as a BRANCH, not a file, so no path applies. INDEXES README.md's "New here?" table gains rows for docs/WIDESCREEN.md, docs/ENHANCEMENTS.md and docs/TCP_COMMANDS.md. docs/internal/README.md gains sections indexing all fourteen documents that moved in, plus an "Upstream contributor reviews" section describing upstream/ and the new sweep file, plus a "Removed" bullet for CYCLE_TIMING_ARCH.md (deleted in the previous commit) pointing at FAITHFUL_TIMING_PLAN.md, CYCLE_MODEL_BEETLE.md and PRECISE_IRQ_SLICE.md -- following the SLJIT_PERSIST_CACHE.md precedent already in that file. docs/ENHANCEMENTS.md:7 claimed framework bugs live in "game repos' ISSUES.md until a framework tracker exists". A framework tracker does exist; it now says so and names the Beads epic. VERIFICATION A link checker was written to scan every tracked .md for relative links, resolving each against the tree being scanned. Baseline at origin/master: 129 files, 137 relative links, 3 broken. After both commits: 127 files, 159 relative links, 3 broken -- the SAME three, all pre-existing and untouched here: docs/DATA_SHARDS.md -> INSTANT_LOADS_PARKED.md (never existed) docs/DATA_SHARDS.md -> INSTANT_LOADS_SPIKE2.md (never existed) docs/NETPLAY.md -> ../lib/recomp-net/README.md (inside a submodule) Zero new broken links. The checker's own coverage was checked against a raw grep for markdown link openers: the 3-link difference is C++ lambdas inside code blocks, correctly not treated as links. Also verified: py_compile over all 113 tracked tools/.py plus psxrecomp_cli.py; all four seed JSONs still parse; the test-registration guard still reports 123 test files all registered; recompiler/tests/test_coverage_vault.py still passes; and no file in this commit had its line endings flipped (checked mechanically across all 50 modified files, after two files were caught and redone). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>	2026-09-03 07:39:07 -07:00
Matthew Stanley	2ba74f3b4b	pgxp: land clean-room value-propagation engine (phases 0+1, issue #92 ) The G1.2/G1.3 mechanism: per-word RAM/scratchpad + per-GPR + per-GTE-reg shadows carrying sub-pixel projections BY PROVENANCE, validated against the actual guest word on every read (never guessed from rounded position - the measured 93.1%-ambiguous G1.4 dead end). Clean-room from psx-spx + public design docs; vendored duckstation (CC BY-NC-ND) and beetle-psx (GPL) trees remain black-box oracles only - no code ported. - runtime/src/pgxp.cpp + pgxp.h: engine, per-vertex GetPreciseVertex (dataflow -> ambiguity-gated position cache -> native) with truncation agreement + tolerance safeguards; stats; test accessors. - pgxp_hooks.h: 5-entry hook funnel; PGXP_() macros no-op unless -DPSX_PGXP=1 (codegen-time gate over ONE generated tree); appended PGXPHooks table member in OverlayCallbacks (ABI bump ships with the Phase-2 emitter change). - Both interpreters wired: loads/stores/COP2 + precision-carrying arithmetic (moves, add/sub, or-merge, 16-bit shifts, LUI, HI/LO). - gte.cpp: RTPS feeds the GTE reg shadows; retired s_precise_sxy FIFO, hashed s_precision_store, and plain-store invalidation (redundant under validate-on-read; store hot path gets 3 calls back). - gpu.c: prepare_precise_triangle rewritten per-vertex; perspective UVs share the same provenance and compose per triangle. - [video] pgxp_cpu_mode / pgxp_tolerance keys; TCP pgxp verb live- toggles geometry/texture/cpu_mode/tolerance; geom_correction census grew the pgxp dataflow counters (G1.9 gate metric). - tests: new pgxp_test (registered); gte_register_access_test updated to precise invalidation contract. 33/33 enabled tests green. Also fixed while landing (both broke a fresh master tree): - runtime.cmake: once-only psx_game_version.txt stamp (multi-target file(GENERATE) collision broke every fresh single-config configure). - test_overlay_capture_retry: SDL3 rot (SDL_SetMainReady gone, inverted SDL_Init check) -> psx_sdl_init. Tracked as beads-eio.3.48; postmortem + this landing: ENHANCEMENTS.md G1-G1.10. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-08-15 18:34:47 -07:00

Author

SHA1

Message

Date

Matthew Stanley

3787120488

Recover saturated horizontal projections in opt-in native-wide rendering

2026-10-02 16:00:02 -07:00

Matthew Stanley

e6ce5006b4

docs: move root and stale docs into docs/ and docs/internal/

The repository root carried seven markdown files that were not onboarding
material, plus two that had been superseded by the code they described. This
sorts them: reader-facing docs to docs/, working notes to docs/internal/, and
the two superseded ones merged into the docs that replaced them.

Moved to docs/:            WIDESCREEN.md, ENHANCEMENTS.md, TCP_COMMANDS.md
Moved to docs/internal/:   PRINCIPLES.md, ISSUES.md, DEBUG.md, GTE_LM_FIX.md,
                           and from docs/: bios-hardening.md, overlay-status.md,
                           overlay-plan.md, overlay-recompilation-design.md,
                           overlay-discovery.md, TOMBA2_EXC_CONSULT_RESPONSE.md,
                           CASE_A_AOT_GAP.md, audit_inventory.md
Moved to docs/internal/upstream/: UPSTREAM_2026-08-20.md

The root keeps only what belongs there: README.md, CONTRIBUTING.md, LICENSE,
CLAUDE.md, THIRD_PARTY_ATTRIBUTION.md, RELEASE_NOTES.md, the dotfiles and
psxrecomp_cli.py.

MERGES

SPLITGEN_MIGRATION.md folded into docs/BUILDING.md as "Split generated C". Its
migration instructions were stale in a way that mattered: it told every game
repo to hand-edit its CMakeLists and add a file(GLOB ...) over
<serial>_full*.c, but runtime/runtime.cmake now does that itself. GEN_FULL_GLOB
is a multi-value argument of psxrecomp_add_game_runtime(); the loop at
runtime.cmake:1985 makes each pattern absolute against CMAKE_CURRENT_SOURCE_DIR,
expands it with file(GLOB), and concatenates the hits into
GAME_GENERATED_FULL_C. So a title names the pattern and gets however many shards
a regeneration produced. The rewritten section describes that, the two-step
fallback when the globs match nothing (GEN_FULL_FALLBACK, else <serial>_full.c
derived from the dispatch marker by substituting _dispatch.c), and the one
caveat the code actually has: that file(GLOB) is plain, not CONFIGURE_DEPENDS,
so a regeneration which changes the shard COUNT needs a re-configure to be seen.

psxrecomp-toml-readme.md folded into docs/GAME_PROJECT_SETUP.md as "EXE-only
autofill (psxrecomp-toml)", placed after "Disc autofill (probe_disc.py)" and
before "Project Studio" so the two autofill paths sit together. Its documented
flags were checked against the usage text in recompiler/src/main_toml.cpp:28-42
and against the argument parser at :150-165 -- all seven options match with no
drift, so the flag list is reproduced as-is. Added a pointer that probe_disc.py
is preferable when a cue exists, since that tool does the same EXE-header work
plus disc identity and netplay gates.

FUNCTIONAL FIXES

tools/gen_tcp_commands.py wrote to REPO/"TCP_COMMANDS.md". After the move that
path does not exist, so the generator would have created a new stray root file
and --check would have failed against it forever. Retargeted to
REPO/"docs"/"TCP_COMMANDS.md", along with the seven docstring and message
strings that name the path.

Running it surfaced two further problems, both fixed here:

  * The doc was genuinely stale -- pre-existing drift, not introduced by this
    commit (the moved file is byte-identical to origin/master, and no
    debug-server command table is touched here). Four commands registered since
    the last regeneration were missing from the index -- cdrom_timing_dump,
    savestate_status, ws_ui_groups, xprobe_watch -- and scanline had gained a
    backend. Regenerated: 307 -> 311 commands, and the change is confined to the
    AUTOGEN block (the hand-written head and tail are byte-identical to master).
    tools/gen_tcp_commands.py --check now exits 0.
  * DOC.write_text() has no newline argument, so Python translated every newline
    to os.linesep. On Windows that rewrote all 585 lines of the file to CRLF and
    turned a four-line index update into a whole-file diff -- measured: 589 CRLF
    / 0 LF after a run, against 0 CRLF / 585 LF in the repo. Now written through
    an explicit newline="" handle, verified to leave the file at 0 CRLF.

runtime/include/debug_server.h:9 and runtime/src/debug_server.c:8 cited "TCP.md
and DEBUG.md". TCP.md has never existed in this repo under that name; both now
name docs/TCP_COMMANDS.md and docs/internal/DEBUG.md.

LINK AND REFERENCE FIXES

Every inbound reference to a moved file was located by grepping each basename
across the whole tracked tree, not just the markdown. Markdown hrefs in
README.md, CONTRIBUTING.md, docs/ARCHITECTURE.md, docs/COMPILING_OVERLAYS.md,
docs/AOT_OVERLAY_PLAN.md, docs/RELOCATION_MANIFEST_FORMAT.md,
docs/config_schema.md, docs/OVERLAY_XREF.md, docs/TCP_COMMANDS.md and several
docs/internal/ files now point at the new locations; where two files became
siblings under docs/internal/ the path was shortened rather than lengthened
(bios-hardening.md's reference to overlay-discovery.md, for instance).
docs/COMPILING_OVERLAYS.md's "in this folder" phrasing was wrong once two of the
three files it listed moved, so it now names internal/ explicitly.

24 source-comment mentions of ENHANCEMENTS.md sections G1.x across 19 files
(recompiler, runtime, cmake) were retargeted to docs/ENHANCEMENTS.md with the
section numbers untouched. docs/SHADOW_ENHANCEMENTS.md is a DIFFERENT file and
was deliberately excluded.

20 rationale strings citing docs/CASE_A_AOT_GAP.md across the four
recompiler/seeds/*.json files were updated. Done as a byte-level substring
replacement rather than a JSON round-trip: two of those files are stored with
CRLF endings and two with LF, and re-serializing them reformatted 5,700 lines.
The byte-level version changes exactly 20 lines and each file still parses.

References that look similar but point elsewhere were deliberately left alone,
and are worth naming so a future pass does not "fix" them:

  * "recomp-template PRINCIPLES.md" / "NES recomp template PRINCIPLES.md" in
    CLAUDE.md:43, docs/SHADOW_ENHANCEMENTS.md:28,
    docs/internal/HLE_SCHEDULER_CARVEOUT_PLAN.md:5,
    runtime/src/debug_server.c:4934 and tools/parity_diff.py:8 are a different
    repository's file. Only the five that mean this repo's PRINCIPLES.md were
    updated.
  * Every remaining bare ISSUES.md mention is a GAME repo's tracker
    (MegaManX6Recomp 2/7/8/9, TombaRecomp 6), not this repo's.
  * docs/disc-speed.md:4,54,56 and docs/internal/bios-hardening.md:5 name
    overlay-discovery as a BRANCH, not a file, so no path applies.

INDEXES

README.md's "New here?" table gains rows for docs/WIDESCREEN.md,
docs/ENHANCEMENTS.md and docs/TCP_COMMANDS.md. docs/internal/README.md gains
sections indexing all fourteen documents that moved in, plus an "Upstream
contributor reviews" section describing upstream/ and the new sweep file, plus a
"Removed" bullet for CYCLE_TIMING_ARCH.md (deleted in the previous commit)
pointing at FAITHFUL_TIMING_PLAN.md, CYCLE_MODEL_BEETLE.md and
PRECISE_IRQ_SLICE.md -- following the SLJIT_PERSIST_CACHE.md precedent already
in that file.

docs/ENHANCEMENTS.md:7 claimed framework bugs live in "game repos' ISSUES.md
until a framework tracker exists". A framework tracker does exist; it now says
so and names the Beads epic.

VERIFICATION

A link checker was written to scan every tracked *.md for relative links,
resolving each against the tree being scanned. Baseline at origin/master: 129
files, 137 relative links, 3 broken. After both commits: 127 files, 159 relative
links, 3 broken -- the SAME three, all pre-existing and untouched here:

    docs/DATA_SHARDS.md -> INSTANT_LOADS_PARKED.md   (never existed)
    docs/DATA_SHARDS.md -> INSTANT_LOADS_SPIKE2.md   (never existed)
    docs/NETPLAY.md     -> ../lib/recomp-net/README.md  (inside a submodule)

Zero new broken links. The checker's own coverage was checked against a raw grep
for markdown link openers: the 3-link difference is C++ lambdas inside code
blocks, correctly not treated as links.

Also verified: py_compile over all 113 tracked tools/*.py plus psxrecomp_cli.py;
all four seed JSONs still parse; the test-registration guard still reports 123
test files all registered; recompiler/tests/test_coverage_vault.py still passes;
and no file in this commit had its line endings flipped (checked mechanically
across all 50 modified files, after two files were caught and redone).

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

2026-09-03 07:39:07 -07:00

Matthew Stanley

2ba74f3b4b

pgxp: land clean-room value-propagation engine (phases 0+1, issue #92 )

The G1.2/G1.3 mechanism: per-word RAM/scratchpad + per-GPR + per-GTE-reg
shadows carrying sub-pixel projections BY PROVENANCE, validated against
the actual guest word on every read (never guessed from rounded position
- the measured 93.1%-ambiguous G1.4 dead end). Clean-room from psx-spx +
public design docs; vendored duckstation (CC BY-NC-ND) and beetle-psx
(GPL) trees remain black-box oracles only - no code ported.

- runtime/src/pgxp.cpp + pgxp.h: engine, per-vertex GetPreciseVertex
  (dataflow -> ambiguity-gated position cache -> native) with truncation
  agreement + tolerance safeguards; stats; test accessors.
- pgxp_hooks.h: 5-entry hook funnel; PGXP_*() macros no-op unless
  -DPSX_PGXP=1 (codegen-time gate over ONE generated tree); appended
  PGXPHooks* table member in OverlayCallbacks (ABI bump ships with the
  Phase-2 emitter change).
- Both interpreters wired: loads/stores/COP2 + precision-carrying
  arithmetic (moves, add/sub, or-merge, 16-bit shifts, LUI, HI/LO).
- gte.cpp: RTPS feeds the GTE reg shadows; retired s_precise_sxy FIFO,
  hashed s_precision_store, and plain-store invalidation (redundant
  under validate-on-read; store hot path gets 3 calls back).
- gpu.c: prepare_precise_triangle rewritten per-vertex; perspective UVs
  share the same provenance and compose per triangle.
- [video] pgxp_cpu_mode / pgxp_tolerance keys; TCP pgxp verb live-
  toggles geometry/texture/cpu_mode/tolerance; geom_correction census
  grew the pgxp dataflow counters (G1.9 gate metric).
- tests: new pgxp_test (registered); gte_register_access_test updated
  to precise invalidation contract. 33/33 enabled tests green.

Also fixed while landing (both broke a fresh master tree):
- runtime.cmake: once-only psx_game_version.txt stamp (multi-target
  file(GENERATE) collision broke every fresh single-config configure).
- test_overlay_capture_retry: SDL3 rot (SDL_SetMainReady gone, inverted
  SDL_Init check) -> psx_sdl_init.

Tracked as beads-eio.3.48; postmortem + this landing: ENHANCEMENTS.md
G1-G1.10.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

2026-08-15 18:34:47 -07:00

3 Commits