Matthew Stanley 08bb5a2728 fix(mdec): truncate 15bpp channel to uint8 before RGB555 (the rainbow bug) ...

The faithful dequant/IDCT/YUV transcription was correct, but the 15bpp pack did
(c+4)>>3 on `r ^ 0x80` as a SIGNED int. For negative Mask9ClampS8 results that
yields a negative int (r=-1 → -129) → garbage 5-bit channel → B saturated, R/G
doubled = the rainbow fringing on real FMV. Beetle's RGB_to_RGB555 takes uint8
params (truncates to 0..255); the 24bpp path already cast to uint8_t. Fix:
rgb_to_555_chan(uint8_t) so the caller's int truncates on the call.

Caught only by comparing our VRAM to the REAL Beetle process (new vram_peek on
the Beetle side, held-FMV diff) — both standalone pins shared the bug in their
self-transcribed reference and falsely passed. After the fix the per-channel VRAM
delta vs Beetle collapsed from mean (12,16,27) to (0.7,0.9,1.3) and the FMV renders
natural colours. Full-path pin (mdec_e2e, corrected uint8 oracle) is byte-exact.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

2026-06-27 21:06:04 -07:00

..

FINDING.md

fix(mdec): truncate 15bpp channel to uint8 before RGB555 (the rainbow bug)

2026-06-27 21:06:04 -07:00

mdec_e2e.c

fix(mdec): truncate 15bpp channel to uint8 before RGB555 (the rainbow bug)

2026-06-27 21:06:04 -07:00

mdec_pin.c

test(mdec): numeric pin (byte-exact vs Beetle) + integration-regression finding

2026-06-27 20:39:34 -07:00