Yves
b491a3597f
Adapted from the original feature commits, retaining their author credit: [6d44e21d](https://github.com/FractalEngineer/psxrecomp/commit/6d44e21df7ccedd1acbfa31844a53bf8bd8b316e) [35b209d4](https://github.com/FractalEngineer/psxrecomp/commit/35b209d406c168e14f51bb8bbd549742473c7388) Source scope and current-master validation: docs/internal/upstream/render-pass-mod-callback-rollback.md Co-authored-by: Yves <calibratedbeats@gmail.com>
3.4 KiB
Render-pass callback rollback: source and validation
Reconstructed from FractalEngineer/psxrecomp, developed on
vr-dev at 9976567eb8e95510ca7eeeeccd9af3a260885de5.
Exact source commits:
Original author: Yves calibratedbeats@gmail.com. The feature commit retains
that exact human author identity. The focused port consolidates the selected
source hunks and corrections. Its commit also cites these sources and carries
the original human contributor's Co-authored-by: Yves <calibratedbeats@gmail.com> trailer.
Adapted: Callback depth/owner snapshot and restore on the existing render transaction, normal-return imbalance detection and focused recovery documentation.
Deliberately excluded: Paired-eye extension tests (included with stereo), game save files and scene-specific replay setup.
The feature was reconstructed on upstream master
db62eec15f81c88aef3d6dab51d4e566a7167d23, retaining current upstream APIs,
renderer/input policy and build integration. Validation after reconstruction:
Nested callback/owner rollback, nonzero outer callback, normal-return imbalance and watchdog recovery regressions.
The motivating consumer is Medal of Honor, SLUS-00974 (NTSC-U). Game-specific integration remains in that repository. Consuming this change requires a deliberate framework pin update in the game repo and a rebuild. This is a host/runtime/tool change; it requires no BIOS or game C regeneration.
Historical alpha acceptance used the older framework checkpoint above. It is separate from current-master branch verification. Fresh game, renderer and headset checks, where applicable, are recorded in the PR validation notes; uncertain hardware/runtime behavior must not be inferred from a clean link.
Current-master integration validation
Windows, GCC 13.2, Ninja, Release. Runtime test checks remain active with NDEBUG enabled.
Release abort/sandbox tests pass for nested callback depth/owner, nonzero outer context, mod-only normal-return imbalance and watchdog recovery. Fresh integrated flat gameplay is reachable after save/load. Historical slot-load recovery after an in-game watchdog is recorded separately.
Integration: Medal of Honor, SLUS-00974 NTSC-U, built against the corrected framework stack with PSXRECOMP_ROOT. Bundled OpenBIOS LLE cold boot, menu navigation, mission gameplay, fresh savestate creation/loading and post-load input/frame advancement were checked with screenshots. An older alpha slot-5 savestate was refused; compatibility with historical states is not established. Memory-card round trips, attract-demo completion, other games and fresh headset visuals were not tested.
The registered recompiler suite reports 132 passes, four failures and three disabled tests. The four failures reproduce on unchanged upstream master in this Windows toolchain: portable_settings_paths_test, optional_netplay_auth, compile_overlays_static_tail and aot_overlay_discovery. The introduced BIOS-fingerprint and GL-guard failures are fixed.