Matthew Stanley
f55c731c5f
Removes 204 tools/ scripts (203 .py/.sh plus tools/_missing_funcs.json) that
no tracked file references. Verified mechanically, not by eye: for each of the
204 stems, a word-boundary grep across every tracked text file in the repo,
excluding files that are themselves being deleted, returns zero hits. So
nothing kept imports, execs, or documents any of them. Most are the
underscore-prefixed one-shot probes the .gitignore convention already treats
as scratch (tools/_*.py is ignored; these predate that rule and were force-
added), plus a long tail of session-specific dump/decode/poll scripts with
hardcoded local paths and addresses.
Also removed at the root:
* card2.mcd.bak.before_beetle_copy -- a stray backup of a memcard.
* .mcp.json -- local MCP server wiring, not repo configuration.
* SCPH1001.toml -- a root duplicate of bios/SCPH1001.toml, still on the
pre-refactor [[recompiler.bios_vectors]] schema while the bios/ copy has
moved to [recompiler.address_model]. Every reference in the tree already
names bios/SCPH1001.toml, so the root copy was a stale trap: editing it
would have had no effect on any build.
* docs/CYCLE_TIMING_ARCH.md -- superseded by
docs/internal/FAITHFUL_TIMING_PLAN.md, CYCLE_MODEL_BEETLE.md and
PRECISE_IRQ_SLICE.md; nothing linked to it.
Memcard fixtures move out of the repo root into
runtime/tests/fixtures/memcards/ with a README recording what each of the
four images actually contains (directory entries read out of the images, not
guessed). Nothing in the build read them from a fixed path -- the four
hardcoded consumers (tools/check_card.py, inspect_card.py, peek_cards.py,
verify_card_buffer.py) are all in the deletion above.
.gitignore is corrected to match: runtime memcards a session creates stay
ignored (*.mcr anywhere, /*.mcd at the root, which is where the runtime drops
card1.mcd/card2.mcd when no path is configured), while the tracked fixtures
are re-included. The old !dummy.*.mcr negation existed only to keep the two
root oracle cards tracked and is replaced by
!runtime/tests/fixtures/memcards/*. Verified with git check-ignore --no-index
on each moved file, on the pre-existing runtime/tests/test_card_synth.mcd and
runtime/tests/test_dir/card1.mcd fixtures (all not-ignored), and on
hypothetical root card1.mcd / card2.mcd / saves/card1.mcr (all ignored).
beetle_libretro.cpp's warn-only memcard sanity check keeps its behaviour; its
WARNING now names where populated fixtures can be copied from. The cards are
opened relative to the process's working directory because the libretro
GET_SAVE_DIRECTORY environment callback answers "." (same file, line 419), so
the message says to copy them into the CWD rather than implying a repo path.
BIOS profiles SCPH101.toml and SCPH5552.toml move from the root into bios/,
joining OpenBIOS.toml and SCPH1001.toml so that bios/*.toml is the whole set.
Behaviour-preserving: config paths inside a profile resolve against
find_project_root() (config_loader.cpp:821), which walks up from the profile's
directory for .gitignore/.git/CMakeLists.txt -- bios/ has none of those, so it
lands on the same repo root as before, and bios/SCPH1001.toml already relied
on exactly that. tools/build_cli.py's staging map is updated to the new
sources; it already copied them to framework/bios/, so the packaged layout is
unchanged. recompiler/src/main_cli.cpp's bios/-first lookup keeps its root
fallback (harmless, and it is what makes older layouts still resolve).
Fixes a real latent break while in bios/SCPH5552.toml: seeds pointed at
"seeds/phase2_ghidra_seeds_SCPH5552.json", but there is no seeds/ directory at
the repo root -- the file lives at
recompiler/seeds/phase2_ghidra_seeds_SCPH5552.json, which is what SCPH101.toml
already named. Porting these two profiles to the address_model schema is
deliberately NOT done here; it is a separate tracked follow-up.
Test files that no build system knew about:
* tools/test_coverage_vault.py PASSES (8/8). Moved to
recompiler/tests/test_coverage_vault.py and registered as the ctest
coverage_vault, which puts it inside runtime/check_test_registration.cmake's
glob so it can never silently rot again. Its ROOT is adjusted from
parents[1] to parents[2] for the new depth, matching every other python
test in that directory. Re-run from the new location and from an unrelated
CWD: 8/8. The registration guard was run standalone before and after, and
with the add_test() deliberately broken as a negative control -- it does
name recompiler/tests/test_coverage_vault.py as an orphan when
unregistered, so the registration is load-bearing rather than decorative.
* tools/test_compile_overlays_additive.py FAILS, 10 of 14 tests erroring
against an API that has moved on, so it is removed rather than wired up.
It calls four module attributes that no longer exist in
tools/compile_overlays.py -- load_additive_captures,
validated_cached_bundle_ids, cached_bundle_pairs, compile_and_publish_dll
(zero occurrences each) -- and two signatures have changed under it:
parse_overlay_func_ids() no longer takes require_stored_crc, and
load_region_coverage() now takes 2-3 positional arguments where the test
passes 5. Reviving it means rewriting it against the current additive
capture API, which is a change to overlay-cache test coverage and needs its
own commit and its own evidence, not a rename.
Verification: py_compile over all 113 remaining tracked tools/*.py plus
psxrecomp_cli.py passes; bash -n over every remaining tracked tools/*.sh
passes; importing sdk_progress, pad_delivery and cursor_writers from tools/
succeeds.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Memory-card test fixtures
Four pre-populated 128 KiB PlayStation memory-card images, used to exercise the
memcard read/write paths with a card that already has saves on it. Every image
is exactly 131072 bytes and starts with the MC header magic; every directory
entry below is state 0x51 (in use, first block of its file).
These lived at the repo root until they were moved here — nothing in the build reads them from a fixed path, so they are inert data a human or a test copies where it needs them.
| File | Consumer | Directory entries |
|---|---|---|
card1.mcd |
recomp runtime, slot 1 | BISLPS-01234SAVE00, BASLUS-56789DATA01, BESLES-11111SLOT02 |
card2.mcd |
recomp runtime, slot 2 | BESLES-11111SLOT02 |
dummy.0.mcr |
Beetle-PSX oracle, slot 1 | BISLPS-01234SAVE00, BASLUS-56789DATA01, BESLES-11111SLOT02, BASLUS-0125100000-00 |
dummy.1.mcr |
Beetle-PSX oracle, slot 2 | BISLPS-01234SAVE00, BASLUS-0125100000-00 |
The BI/BA/BE prefixes are the standard region byte pairs; the synthetic
SLPS-01234 / SLUS-56789 / SLES-11111 product codes are fabricated test
data. SLUS-01251 (Tomba! 2) is a real code, retained because the oracle cards
were captured while driving that title.
Using them with the Beetle oracle
runtime/src/beetle_libretro.cpp asks the libretro core for its save directory
and answers "." (see the RETRO_ENVIRONMENT_GET_SAVE_DIRECTORY case), so the
core opens dummy.0.mcr / dummy.1.mcr relative to the oracle process's
working directory, not relative to this repo. To boot the oracle with
populated cards, copy them next to where you launch it:
cp runtime/tests/fixtures/memcards/dummy.[01].mcr <psx-beetle-cwd>/
Without them the core still boots; it prints a warn-only
WARNING: dummy.N.mcr missing — slot N will be blank line (same file, the
memcard sanity-check block) and both slots come up empty.
Using them with the recomp runtime
card1.mcd / card2.mcd are the recomp-side counterparts. Copy them to
whichever card paths the run is configured with — memcard paths resolve against
the project root, not the executable, so an unconfigured run writes
card1.mcd / card2.mcd at the root (which .gitignore deliberately ignores,
so a run can never dirty the tree by touching these fixtures).