mirror of
https://github.com/RetroPortingToolKit/psxrecomp
synced 2026-10-26 02:11:36 -04:00
e6ce5006b4
The repository root carried seven markdown files that were not onboarding
material, plus two that had been superseded by the code they described. This
sorts them: reader-facing docs to docs/, working notes to docs/internal/, and
the two superseded ones merged into the docs that replaced them.
Moved to docs/: WIDESCREEN.md, ENHANCEMENTS.md, TCP_COMMANDS.md
Moved to docs/internal/: PRINCIPLES.md, ISSUES.md, DEBUG.md, GTE_LM_FIX.md,
and from docs/: bios-hardening.md, overlay-status.md,
overlay-plan.md, overlay-recompilation-design.md,
overlay-discovery.md, TOMBA2_EXC_CONSULT_RESPONSE.md,
CASE_A_AOT_GAP.md, audit_inventory.md
Moved to docs/internal/upstream/: UPSTREAM_2026-08-20.md
The root keeps only what belongs there: README.md, CONTRIBUTING.md, LICENSE,
CLAUDE.md, THIRD_PARTY_ATTRIBUTION.md, RELEASE_NOTES.md, the dotfiles and
psxrecomp_cli.py.
MERGES
SPLITGEN_MIGRATION.md folded into docs/BUILDING.md as "Split generated C". Its
migration instructions were stale in a way that mattered: it told every game
repo to hand-edit its CMakeLists and add a file(GLOB ...) over
<serial>_full*.c, but runtime/runtime.cmake now does that itself. GEN_FULL_GLOB
is a multi-value argument of psxrecomp_add_game_runtime(); the loop at
runtime.cmake:1985 makes each pattern absolute against CMAKE_CURRENT_SOURCE_DIR,
expands it with file(GLOB), and concatenates the hits into
GAME_GENERATED_FULL_C. So a title names the pattern and gets however many shards
a regeneration produced. The rewritten section describes that, the two-step
fallback when the globs match nothing (GEN_FULL_FALLBACK, else <serial>_full.c
derived from the dispatch marker by substituting _dispatch.c), and the one
caveat the code actually has: that file(GLOB) is plain, not CONFIGURE_DEPENDS,
so a regeneration which changes the shard COUNT needs a re-configure to be seen.
psxrecomp-toml-readme.md folded into docs/GAME_PROJECT_SETUP.md as "EXE-only
autofill (psxrecomp-toml)", placed after "Disc autofill (probe_disc.py)" and
before "Project Studio" so the two autofill paths sit together. Its documented
flags were checked against the usage text in recompiler/src/main_toml.cpp:28-42
and against the argument parser at :150-165 -- all seven options match with no
drift, so the flag list is reproduced as-is. Added a pointer that probe_disc.py
is preferable when a cue exists, since that tool does the same EXE-header work
plus disc identity and netplay gates.
FUNCTIONAL FIXES
tools/gen_tcp_commands.py wrote to REPO/"TCP_COMMANDS.md". After the move that
path does not exist, so the generator would have created a new stray root file
and --check would have failed against it forever. Retargeted to
REPO/"docs"/"TCP_COMMANDS.md", along with the seven docstring and message
strings that name the path.
Running it surfaced two further problems, both fixed here:
* The doc was genuinely stale -- pre-existing drift, not introduced by this
commit (the moved file is byte-identical to origin/master, and no
debug-server command table is touched here). Four commands registered since
the last regeneration were missing from the index -- cdrom_timing_dump,
savestate_status, ws_ui_groups, xprobe_watch -- and scanline had gained a
backend. Regenerated: 307 -> 311 commands, and the change is confined to the
AUTOGEN block (the hand-written head and tail are byte-identical to master).
tools/gen_tcp_commands.py --check now exits 0.
* DOC.write_text() has no newline argument, so Python translated every newline
to os.linesep. On Windows that rewrote all 585 lines of the file to CRLF and
turned a four-line index update into a whole-file diff -- measured: 589 CRLF
/ 0 LF after a run, against 0 CRLF / 585 LF in the repo. Now written through
an explicit newline="" handle, verified to leave the file at 0 CRLF.
runtime/include/debug_server.h:9 and runtime/src/debug_server.c:8 cited "TCP.md
and DEBUG.md". TCP.md has never existed in this repo under that name; both now
name docs/TCP_COMMANDS.md and docs/internal/DEBUG.md.
LINK AND REFERENCE FIXES
Every inbound reference to a moved file was located by grepping each basename
across the whole tracked tree, not just the markdown. Markdown hrefs in
README.md, CONTRIBUTING.md, docs/ARCHITECTURE.md, docs/COMPILING_OVERLAYS.md,
docs/AOT_OVERLAY_PLAN.md, docs/RELOCATION_MANIFEST_FORMAT.md,
docs/config_schema.md, docs/OVERLAY_XREF.md, docs/TCP_COMMANDS.md and several
docs/internal/ files now point at the new locations; where two files became
siblings under docs/internal/ the path was shortened rather than lengthened
(bios-hardening.md's reference to overlay-discovery.md, for instance).
docs/COMPILING_OVERLAYS.md's "in this folder" phrasing was wrong once two of the
three files it listed moved, so it now names internal/ explicitly.
24 source-comment mentions of ENHANCEMENTS.md sections G1.x across 19 files
(recompiler, runtime, cmake) were retargeted to docs/ENHANCEMENTS.md with the
section numbers untouched. docs/SHADOW_ENHANCEMENTS.md is a DIFFERENT file and
was deliberately excluded.
20 rationale strings citing docs/CASE_A_AOT_GAP.md across the four
recompiler/seeds/*.json files were updated. Done as a byte-level substring
replacement rather than a JSON round-trip: two of those files are stored with
CRLF endings and two with LF, and re-serializing them reformatted 5,700 lines.
The byte-level version changes exactly 20 lines and each file still parses.
References that look similar but point elsewhere were deliberately left alone,
and are worth naming so a future pass does not "fix" them:
* "recomp-template PRINCIPLES.md" / "NES recomp template PRINCIPLES.md" in
CLAUDE.md:43, docs/SHADOW_ENHANCEMENTS.md:28,
docs/internal/HLE_SCHEDULER_CARVEOUT_PLAN.md:5,
runtime/src/debug_server.c:4934 and tools/parity_diff.py:8 are a different
repository's file. Only the five that mean this repo's PRINCIPLES.md were
updated.
* Every remaining bare ISSUES.md mention is a GAME repo's tracker
(MegaManX6Recomp 2/7/8/9, TombaRecomp 6), not this repo's.
* docs/disc-speed.md:4,54,56 and docs/internal/bios-hardening.md:5 name
overlay-discovery as a BRANCH, not a file, so no path applies.
INDEXES
README.md's "New here?" table gains rows for docs/WIDESCREEN.md,
docs/ENHANCEMENTS.md and docs/TCP_COMMANDS.md. docs/internal/README.md gains
sections indexing all fourteen documents that moved in, plus an "Upstream
contributor reviews" section describing upstream/ and the new sweep file, plus a
"Removed" bullet for CYCLE_TIMING_ARCH.md (deleted in the previous commit)
pointing at FAITHFUL_TIMING_PLAN.md, CYCLE_MODEL_BEETLE.md and
PRECISE_IRQ_SLICE.md -- following the SLJIT_PERSIST_CACHE.md precedent already
in that file.
docs/ENHANCEMENTS.md:7 claimed framework bugs live in "game repos' ISSUES.md
until a framework tracker exists". A framework tracker does exist; it now says
so and names the Beads epic.
VERIFICATION
A link checker was written to scan every tracked *.md for relative links,
resolving each against the tree being scanned. Baseline at origin/master: 129
files, 137 relative links, 3 broken. After both commits: 127 files, 159 relative
links, 3 broken -- the SAME three, all pre-existing and untouched here:
docs/DATA_SHARDS.md -> INSTANT_LOADS_PARKED.md (never existed)
docs/DATA_SHARDS.md -> INSTANT_LOADS_SPIKE2.md (never existed)
docs/NETPLAY.md -> ../lib/recomp-net/README.md (inside a submodule)
Zero new broken links. The checker's own coverage was checked against a raw grep
for markdown link openers: the 3-link difference is C++ lambdas inside code
blocks, correctly not treated as links.
Also verified: py_compile over all 113 tracked tools/*.py plus psxrecomp_cli.py;
all four seed JSONs still parse; the test-registration guard still reports 123
test files all registered; recompiler/tests/test_coverage_vault.py still passes;
and no file in this commit had its line endings flipped (checked mechanically
across all 50 modified files, after two files were caught and redone).
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
145 lines
5.6 KiB
Python
145 lines
5.6 KiB
Python
"""gte_audit — audit COP2/GTE instruction coverage.
|
|
|
|
Generic across any PSX program. For each declared code region in the
|
|
config, scans the ROM for COP2 (GTE command) and LWC2/SWC2 (GTE
|
|
load/store) instructions and confirms each one has a matching emit in
|
|
the generated C file.
|
|
|
|
Migration note: the original BIOS-only version scanned the entire ROM
|
|
including data regions, producing false positives in `0xBFC75xxx+`.
|
|
This version filters to declared code regions only — which closes the
|
|
data-region false-positive bug class noted in `docs/internal/audit_inventory.md`.
|
|
|
|
Usage:
|
|
python tools/gte_audit.py --config bios/SCPH1001.toml
|
|
python tools/gte_audit.py --config /path/to/game.toml
|
|
|
|
Exit code:
|
|
0 no missing GTE emits
|
|
1 at least one missing GTE / LWC2 / SWC2 emit
|
|
"""
|
|
import re
|
|
import struct
|
|
import sys
|
|
from collections import defaultdict
|
|
from pathlib import Path
|
|
|
|
sys.path.insert(0, str(Path(__file__).parent))
|
|
import audit_config
|
|
|
|
|
|
def main():
|
|
cfg = audit_config.from_argv(sys.argv)
|
|
print(f"# gte audit: {cfg.name}")
|
|
print(f" rom = {cfg.rom}")
|
|
print(f" full_c = {cfg.full_c}")
|
|
print()
|
|
|
|
if not cfg.rom.exists():
|
|
print(f"ERROR: rom not found: {cfg.rom}", file=sys.stderr)
|
|
return 2
|
|
if not cfg.full_c.exists():
|
|
print(f"ERROR: full_c not found: {cfg.full_c}", file=sys.stderr)
|
|
return 2
|
|
|
|
rom_bytes = cfg.rom.read_bytes()
|
|
|
|
# ── 1. Scan ROM code regions for COP2 commands, LWC2, SWC2 ─────────────
|
|
|
|
rom_gte = [] # (vaddr, word)
|
|
rom_lwc2_swc2 = [] # (vaddr, word)
|
|
|
|
for region in cfg.regions:
|
|
if region.rom_end > len(rom_bytes):
|
|
print(f"WARNING: region {region.name} extends past ROM file "
|
|
f"(rom_end=0x{region.rom_end:X} > size=0x{len(rom_bytes):X})",
|
|
file=sys.stderr)
|
|
continue
|
|
for off in range(region.rom_start, region.rom_end, 4):
|
|
word = struct.unpack_from("<I", rom_bytes, off)[0]
|
|
opcode = (word >> 26) & 0x3F
|
|
vaddr = region.vaddr_base + (off - region.rom_start)
|
|
|
|
if opcode == 0x12: # COP2
|
|
bit25 = (word >> 25) & 1
|
|
if bit25 == 1: # GTE command (not MFC2/MTC2/CFC2/CTC2)
|
|
rom_gte.append((vaddr, word))
|
|
elif opcode in (0x32, 0x3A): # LWC2 or SWC2
|
|
rom_lwc2_swc2.append((vaddr, word))
|
|
|
|
# ── 2. Scan generated C for matching emits ─────────────────────────────
|
|
|
|
gen_gte_addrs = set()
|
|
gen_cop2_load_addrs = set()
|
|
|
|
# Address comment pattern: /* 0xXXXXXXXX: ...
|
|
addr_re = re.compile(r'/\* 0x([0-9A-Fa-f]{8}):')
|
|
|
|
with open(cfg.full_c, "r", encoding="utf-8", errors="replace") as f:
|
|
prev_addr = None
|
|
for line in f:
|
|
m = addr_re.search(line)
|
|
if m:
|
|
prev_addr = int(m.group(1), 16)
|
|
if "gte_execute" in line and prev_addr is not None:
|
|
gen_gte_addrs.add(prev_addr)
|
|
if ("lwc2" in line.lower() or "swc2" in line.lower()) and prev_addr is not None:
|
|
if m: # this line has the address comment
|
|
gen_cop2_load_addrs.add(prev_addr)
|
|
|
|
# ── 3. Diff and report ─────────────────────────────────────────────────
|
|
|
|
print(f"ROM code regions scanned : {len(cfg.regions)}")
|
|
print(f"ROM GTE commands (COP2 bit25=1): {len(rom_gte)}")
|
|
print(f"ROM LWC2/SWC2 instructions : {len(rom_lwc2_swc2)}")
|
|
print(f"Generated gte_execute calls : {len(gen_gte_addrs)}")
|
|
print(f"Generated lwc2/swc2 accesses : {len(gen_cop2_load_addrs)}")
|
|
print()
|
|
|
|
missing_gte = [(addr, word) for addr, word in rom_gte
|
|
if addr not in gen_gte_addrs]
|
|
missing_loads = [(addr, word) for addr, word in rom_lwc2_swc2
|
|
if addr not in gen_cop2_load_addrs]
|
|
|
|
if missing_gte:
|
|
print(f"MISSING GTE commands: {len(missing_gte)}")
|
|
regions = defaultdict(list)
|
|
for addr, word in missing_gte:
|
|
regions[addr & ~0xFF].append((addr, word, word & 0x3F))
|
|
print(f"Missing spread across {len(regions)} 256B clusters:")
|
|
for region in sorted(regions):
|
|
entries = regions[region]
|
|
codes = ", ".join(f"0x{e[2]:02X}" for e in entries)
|
|
print(f" 0x{region:08X}: {len(entries)} missing — funct: {codes}")
|
|
for a, w, c in entries[:5]:
|
|
print(f" 0x{a:08X}: 0x{w:08X} (funct {c:#04x})")
|
|
if len(entries) > 5:
|
|
print(f" ... and {len(entries) - 5} more")
|
|
else:
|
|
print("MISSING GTE commands: 0 OK")
|
|
|
|
print()
|
|
if missing_loads:
|
|
print(f"MISSING LWC2/SWC2: {len(missing_loads)} of {len(rom_lwc2_swc2)}")
|
|
load_regions = defaultdict(list)
|
|
for addr, word in missing_loads:
|
|
load_regions[addr & ~0xFF].append(addr)
|
|
for region in sorted(load_regions):
|
|
print(f" 0x{region:08X}: {len(load_regions[region])} missing")
|
|
else:
|
|
print(f"MISSING LWC2/SWC2: 0 OK (of {len(rom_lwc2_swc2)} total)")
|
|
|
|
print()
|
|
real_misses = len(missing_gte) + len(missing_loads)
|
|
print(f"[summary] {cfg.name}")
|
|
print(f" missing gte_execute emits : {len(missing_gte)}")
|
|
print(f" missing lwc2/swc2 emits : {len(missing_loads)}")
|
|
print(f" total real-bug findings : {real_misses}")
|
|
print(f" STATUS : {'CLEAN' if real_misses == 0 else 'ISSUES FOUND'}")
|
|
|
|
return 0 if real_misses == 0 else 1
|
|
|
|
|
|
if __name__ == "__main__":
|
|
sys.exit(main())
|