fix: report malformed application evidence as input errors

src/application/javascript/JavaScriptSemanticTraceService.ts

@@ -5,6 +5,10 @@ import {
   AnalysisProtocolError,
 } from "../../domain/analysisErrorCore.js";
 import { type AnalysisError } from "../../domain/analysisErrorBase.js";
+import {
+  applicationGraphEvidenceInputError,
+  parseApplicationGraphEvidence,
+} from "./JavaScriptApplicationEvidenceGraph.js";
 import type { Evidence } from "../../domain/evidence.js";
 import { jsonValueSchema } from "../../domain/jsonValue.js";
 import { queryJavaScriptSemanticGraph } from "../../domain/javascript/javascriptSemanticQuery.js";
@@ -13,7 +17,6 @@ import {
   traceJavaScriptSemanticsInputSchema,
 } from "../../domain/javascript/javascriptSemanticTraceSchemas.js";
 import { err, ok, type Result } from "../../domain/result.js";
-import { parseApplicationGraphEvidence } from "./JavaScriptApplicationEvidenceGraph.js";
 import { createJavaScriptSemanticTraceEvidence } from "./JavaScriptApplicationWorkflowEvidence.js";
 
 const OPERATION = "trace_javascript_semantics" as const;
@@ -22,19 +25,26 @@ const OPERATION = "trace_javascript_semantics" as const;
 export const traceJavaScriptSemanticsEvidenceValidated = (
   input: z.output<typeof traceJavaScriptSemanticsInputSchema>,
 ): Result<Evidence, AnalysisError> => {
+  const sourceResult = parseApplicationGraphEvidence(input.application, [
+    "application",
+  ]);
+  if (!sourceResult.ok)
+    return err(
+      applicationGraphEvidenceInputError(OPERATION, sourceResult.error),
+    );
+  const source = sourceResult.value;
+  if (source.semanticGraph === null)
+    return err(
+      new AnalysisInputError(OPERATION, undefined, [
+        {
+          path: ["application"],
+          reason: "invalid_value",
+          expected:
+            "inline Evidence from analyze_javascript_application with a semantic graph",
+        },
+      ]),
+    );
   try {
-    const source = parseApplicationGraphEvidence(input.application);
-    if (source.semanticGraph === null)
-      return err(
-        new AnalysisInputError(OPERATION, undefined, [
-          {
-            path: ["application"],
-            reason: "invalid_value",
-            expected:
-              "inline Evidence from analyze_javascript_application with a semantic graph",
-          },
-        ]),
-      );
     const query = queryJavaScriptSemanticGraph(
       source.semanticGraph,
       input.query,