fix(domain): classify TypeScript parameter properties as declarations rather than identifier reads (#4465)

* fix(domain): classify TypeScript parameter properties as declarations rather than identifier reads

Recognize TSParameterProperty in isPatternOwnerDeclaration, isDeclarationIdentifier, and patternContains so parameter property definitions are not emitted as identifier reads, while retaining valid initializer reads. Fixes #4371

* test(domain): assert constructor body parameter property reads survive
This commit is contained in:
Kevin Joshua L
2026-10-16 21:49:40 +05:30
committed by GitHub
parent ffeba6aae0
commit 2bba39bc2b
2 changed files with 43 additions and 0 deletions
@@ -670,6 +670,7 @@ const isDeleteSite = (site: t.Node): boolean =>
t.isUnaryExpression(site, { operator: "delete" });
const isPatternOwnerDeclaration = (node: t.Node): boolean =>
t.isTSParameterProperty(node) ||
(t.isVariableDeclarator(node) && t.isPattern(node.id)) ||
(t.isFunction(node) &&
node.params.some((value): value is t.Pattern => t.isPattern(value))) ||
@@ -699,6 +700,8 @@ const isDeclarationIdentifier = (
): boolean => {
if (t.isTSImportEqualsDeclaration(parent)) return parent.id === node;
return (
(t.isTSParameterProperty(parent) &&
patternContains(parent.parameter, node)) ||
(t.isVariableDeclarator(parent) && patternContains(parent.id, node)) ||
((t.isFunctionDeclaration(parent) || t.isFunctionExpression(parent)) &&
parent.id === node) ||
@@ -747,6 +750,8 @@ const patternNames = (pattern: t.Node): string[] => {
const patternContains = (pattern: t.Node, target: t.Identifier): boolean =>
pattern === target ||
(t.isTSParameterProperty(pattern) &&
patternContains(pattern.parameter, target)) ||
(t.isAssignmentPattern(pattern) && patternContains(pattern.left, target)) ||
(t.isRestElement(pattern) && patternContains(pattern.argument, target)) ||
(t.isObjectPattern(pattern) &&