mirror/rea
1
0
Fork 0
mirror of https://github.com/morluto/rea synced 2026-10-26 22:28:27 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(javascript): preserve graph facts across omissions and versions

Browse Source 
Omit absent inventory facts without erasing explicit unknowns. Compare canonical file occurrences by source path and digest while preserving complete container provenance in observations and Evidence.

Consolidate candidate-capacity fixtures around unresolved alternatives and update inventory coverage and source-occurrence oracles. Preserve resource, identity, relationship uncertainty, cancellation, and transfer regressions.
This commit is contained in:
morluto
2026-10-24 06:19:05 +08:00
parent 9dde3fd6a4
commit 30db499db3
9 changed files with 243 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/boundary/filesystem/javascript-applications/javascriptModuleRelationships.test.ts
+33 -8
View File
@@ -9,6 +9,7 @@ import { parseJavaScriptApplicationGraph } from "../../../../src/domain/javascri
import { compareJavaScriptApplicationVersions } from "../../../../src/domain/javascript/javascriptApplicationVersionComparison.js";
import { semanticResourceLimitReason } from "../../../../src/domain/javascript/javascriptSemanticResourceLimits.js";
import { getterExpansionSource } from "../../../fixtures/javascriptGetterExpansion.js";
import { primitiveCandidateExpansionExpression } from "../../../fixtures/javascriptPrimitiveExpansion.js";
import { scanCanonicalArtifactInventory } from "../../../fixtures/artifactInventory.js";
import { readJavaScriptArtifactFiles } from "../../../support/javascriptApplicationScope.js";
import { createJavaScriptArtifactReader } from "../../../../src/artifacts/javascript/JavaScriptArtifactReader.js";
@@ -95,7 +96,7 @@ it.each([
["getter-expansion", getterExpansionSource()],
[
"primitive-candidates",
`const result = ${Array.from({ length: 20 }, () => '(true ? "a" : "b")').join(" + ")};`,
`const result = ${primitiveCandidateExpansionExpression()};`,
],
] as const)(
"deduplicates %s limitations on import and export relationships",
@@ -137,11 +138,13 @@ it.each([
describe("cross-version source module identity", () => {
it("keeps exact source identity without claiming unchanged unresolved relationships", async () => {
const root = await createTestTempDirectory("rea-source-module-sibling-");
const mainSource = 'require("./util.js");\n';
const sourceSha256 = createHash("sha256").update(mainSource).digest("hex");
const versions = await Promise.all(
["left", "right"].map(async (name) => {
const path = join(root, name);
await writeFixtureFiles(path, {
"main.js": 'require("./util.js");\n',
"main.js": mainSource,
"util.js": `module.exports = ${JSON.stringify(name)};\n`,
});
return reconstructJavaScriptFixture(path);
@@ -160,12 +163,34 @@ describe("cross-version source module identity", () => {
const rightObservation = rightModule.observations.find(
({ properties }) => properties.semantic_role === "source-module",
);
expect(leftObservation?.properties).not.toHaveProperty("container_sha256");
expect(rightObservation?.properties).not.toHaveProperty("container_sha256");
expect(leftObservation?.properties).toEqual(rightObservation?.properties);
expect(leftObservation?.properties.source_sha256).toBe(
rightObservation?.properties.source_sha256,
);
if (leftObservation === undefined || rightObservation === undefined)
throw new Error("Missing main source observation");
expect(left.root_artifact_sha256).not.toBe(right.root_artifact_sha256);
expect(leftModule.node_id).not.toBe(rightModule.node_id);
expect(leftObservation.properties).not.toHaveProperty("container_sha256");
expect(rightObservation.properties).not.toHaveProperty("container_sha256");
const { file_occurrence: leftOccurrence, ...leftSourceFacts } =
leftObservation.properties;
const { file_occurrence: rightOccurrence, ...rightSourceFacts } =
rightObservation.properties;
expect(leftOccurrence).toEqual({
container_sha256: left.root_artifact_sha256,
path: "main.js",
sha256: sourceSha256,
});
expect(rightOccurrence).toEqual({
container_sha256: right.root_artifact_sha256,
path: "main.js",
sha256: sourceSha256,
});
expect(leftSourceFacts).toEqual(rightSourceFacts);
expect(leftSourceFacts.source_sha256).toBe(sourceSha256);
expect(leftObservation.evidence).toEqual(rightObservation.evidence);
expect(leftObservation.evidence.artifact).toMatchObject({
available: true,
artifact_id: `art_${sourceSha256}`,
sha256: sourceSha256,
});
const comparison = compareJavaScriptApplicationVersions({
left: {