From 4d8ef3f35022f286e5a6b2ee250cfb336e14a4ad Mon Sep 17 00:00:00 2001
From: Ysopwnable <161784452+N0zoM1z0@users.noreply.github.com>
Date: Sat, 10 Oct 2026 11:30:42 +0800
Subject: [PATCH] perf(javascript): aggregate semantic family coverage once
 (#1410)

Reduce repeated semantic relation and unknown family scans while preserving exact complete Evidence and coverage.
---
 .../JavaScriptSemanticGraphBuilder.ts         | 26 ++++++++++++-------
 1 file changed, 17 insertions(+), 9 deletions(-)

diff --git a/src/application/javascript/JavaScriptSemanticGraphBuilder.ts b/src/application/javascript/JavaScriptSemanticGraphBuilder.ts
index a951a7a55e..45ded50518 100644
--- a/src/application/javascript/JavaScriptSemanticGraphBuilder.ts
+++ b/src/application/javascript/JavaScriptSemanticGraphBuilder.ts
@@ -175,7 +175,21 @@ export const createJavaScriptSemanticGraphProjection =
     ): Value => {
       bindSemanticGraphApplicationNodes(state, applicationGraph);
       if (state.roots.size === 0) addFallbackRoot(rootArtifactSha256, state);
+      const relations = [...state.relations.values()];
       const unknowns = [...state.unknowns.values()];
+      type Family = (typeof JAVASCRIPT_SEMANTIC_RELATION_FAMILIES)[number];
+      const retainedByFamily = new Map<Family, number>();
+      const unknownIdsByFamily = new Map<Family, string[]>();
+      for (const relation of relations) {
+        const family = JAVASCRIPT_SEMANTIC_RELATION_FAMILY[relation.relation];
+        retainedByFamily.set(family, (retainedByFamily.get(family) ?? 0) + 1);
+      }
+      for (const unknown of unknowns) {
+        const identifiers = unknownIdsByFamily.get(unknown.family);
+        if (identifiers === undefined)
+          unknownIdsByFamily.set(unknown.family, [unknown.unknown_id]);
+        else identifiers.push(unknown.unknown_id);
+      }
       const graph = factory({
         schema: "JavaScriptSemanticRelationGraph",
         root_artifact_sha256: rootArtifactSha256,
@@ -183,7 +197,7 @@ export const createJavaScriptSemanticGraphProjection =
         root_node_ids: [...state.roots],
         evidence_contexts: state.evidenceContexts.contexts,
         nodes: [...state.nodes.values()],
-        relations: [...state.relations.values()],
+        relations,
         fingerprints,
         unknowns,
         coverage: {
@@ -204,15 +218,9 @@ export const createJavaScriptSemanticGraphProjection =
           families: JAVASCRIPT_SEMANTIC_RELATION_FAMILIES.map((family) => ({
             family,
             status: semanticFamilyStatus(family),
-            retained_relations: [...state.relations.values()].filter(
-              (relation) =>
-                JAVASCRIPT_SEMANTIC_RELATION_FAMILY[relation.relation] ===
-                family,
-            ).length,
+            retained_relations: retainedByFamily.get(family) ?? 0,
             omitted_relations: truncatedFiles > 0 ? null : 0,
-            unknown_ids: unknowns
-              .filter((unknown) => unknown.family === family)
-              .map(({ unknown_id: identifier }) => identifier),
+            unknown_ids: unknownIdsByFamily.get(family) ?? [],
           })),
         },
         limitations: [