mirror/rea
1
0
Fork 0
mirror of https://github.com/morluto/rea synced 2026-10-26 14:25:49 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(javascript): preserve alias and container uncertainty

Browse Source
This commit is contained in:
morluto
2026-10-09 22:43:21 +08:00
parent 99f257bbf0
commit 73e98b2516
8 changed files with 374 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/domain/javascript/javascriptSemanticAnalysis.dataflow.test.ts
+41 -15
View File
@@ -209,6 +209,17 @@ describe("JavaScript semantic analysis: read-modify-write", () => {
"read",
]);
});
it("does not model a compound binding write as a competing replacement", () => {
const ir = analyzeJavaScriptSemantics(`
let count = 1;
count += 2;
`);
expect(topLevelBinding(ir, "count").value).toMatchObject({
status: "unknown",
});
});
});
describe("JavaScript semantic analysis: dataflow 2", () => {
@@ -448,21 +459,36 @@ describe("nonfinite static values", () => {
describe("binding write invalidation", () => {
it.each([
"let value = 1; value++; const observed = value;",
"let value = 1; --value; const observed = value;",
'let value = "old"; [value] = ["new"]; const observed = value;',
'let value = "old"; ({key: value} = {key: "new"}); const observed = value;',
'let value = "old"; for (value of ["new"]) {} const observed = value;',
'let value = "old"; for (value in {new: true}) {} const observed = value;',
])("does not retain an exact initializer across %s", (source) => {
const ir = analyzeJavaScriptSemantics(source);
expect(topLevelBinding(ir, "observed").value.status).toBe("ambiguous");
expect(
topLevelBinding(ir, "value").definitions.some(
({ kind }) => kind === "assignment",
),
).toBe(true);
});
["let value = 1; value++; const observed = value;", "unknown"],
["let value = 1; --value; const observed = value;", "unknown"],
[
'let value = "old"; [value] = ["new"]; const observed = value;',
"ambiguous",
],
[
'let value = "old"; ({key: value} = {key: "new"}); const observed = value;',
"ambiguous",
],
[
'let value = "old"; for (value of ["new"]) {} const observed = value;',
"ambiguous",
],
[
'let value = "old"; for (value in {new: true}) {} const observed = value;',
"ambiguous",
],
] as const)(
"does not retain an exact initializer across %s",
(source, status) => {
const ir = analyzeJavaScriptSemantics(source);
expect(topLevelBinding(ir, "observed").value.status).toBe(status);
expect(
topLevelBinding(ir, "value").definitions.some(
({ kind }) => kind === "assignment",
),
).toBe(true);
},
);
it("does not treat destructuring keys or member owners as assigned bindings", () => {
const ir = analyzeJavaScriptSemantics(`