mirror/rea
1
0
Fork 0
mirror of https://github.com/morluto/rea synced 2026-10-27 06:33:32 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor(javascript): share computed-key callable ownership

Browse Source 
Give calls, captures, object operations, promises and effects one callable-owner tracker. Suspend a method while its computed key is evaluated in the enclosing callable; remove the capture-only downstream repair.

Co-authored-by: Alex Desir <adesir089@gmail.com>
This commit is contained in:
morluto
2026-10-14 15:20:07 +08:00
parent 6396851958
commit 76fa5304a8
8 changed files with 245 additions and 107 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/domain/javascript/javascriptSemanticChildProcesses.ts
+11 -20
View File
@@ -5,7 +5,7 @@ import type {
JavaScriptSemanticChildProcessInteraction,
JavaScriptSemanticChildProcessSpawn,
} from "./javascriptSemanticIr.js";
import { semanticCallableIdForNode } from "./javascriptSemanticProjection.js";
import { createSemanticCallableIdStack } from "./javascriptSemanticCallableStack.js";
import {
semanticStaticPropertyName,
unwrapJavaScriptExpression,
@@ -84,13 +84,11 @@ const collectSpawns = (
const admittedCallables = new Set(
callables.map(({ callableId }) => callableId),
);
const callableStack: string[] = [];
const callableStack = createSemanticCallableIdStack(admittedCallables);
const ancestors: t.Node[] = [];
traverseJavaScriptAst(program, {
enter: (node) => {
const callableId = semanticCallableIdForNode(node);
if (callableId !== null && admittedCallables.has(callableId))
callableStack.push(callableId);
enter: (node, parent) => {
callableStack.enter(node, parent);
if (t.isCallExpression(node) || t.isOptionalCallExpression(node)) {
const method = childProcessMethod(node.callee, state);
if (method !== null) {
@@ -102,7 +100,7 @@ const collectSpawns = (
output.push({
node,
method,
ownerCallableId: callableStack.at(-1) ?? null,
ownerCallableId: callableStack.callables.at(-1) ?? null,
resultBindingId: scalarAssignedResultBinding(
projectedResultBindings,
),
@@ -118,7 +116,7 @@ const collectSpawns = (
},
exit: (node) => {
ancestors.pop();
popCallable(node, callableStack);
callableStack.exit(node);
},
});
return output;
@@ -152,7 +150,7 @@ const collectInteractions = (
): JavaScriptSemanticChildProcessInteraction[] => {
const output: JavaScriptSemanticChildProcessInteraction[] = [];
const callableIds = new Set(callables.map(({ callableId }) => callableId));
const callableStack: string[] = [];
const callableStack = createSemanticCallableIdStack(callableIds);
const spawnByNode = new WeakMap<t.Node, SpawnCandidate>();
const spawnsByBinding = new Map<string, SpawnCandidate[]>();
for (const spawn of spawns) {
@@ -173,21 +171,19 @@ const collectInteractions = (
spawnsByBinding,
};
traverseJavaScriptAst(program, {
enter: (node) => {
const callableId = semanticCallableIdForNode(node);
if (callableId !== null && callableIds.has(callableId))
callableStack.push(callableId);
enter: (node, parent) => {
callableStack.enter(node, parent);
if (!t.isCallExpression(node) && !t.isOptionalCallExpression(node))
return;
const interaction = childInteraction(
node,
callableStack.at(-1) ?? null,
callableStack.callables.at(-1) ?? null,
context,
);
if (interaction === null) return;
output.push(interaction);
},
exit: (node) => popCallable(node, callableStack),
exit: (node) => callableStack.exit(node),
});
return output;
};
@@ -359,10 +355,5 @@ const objectBinding = (
? resolveSemanticBindingState(state, node, node.name)
: undefined;
const popCallable = (node: t.Node, stack: string[]): void => {
const callableId = semanticCallableIdForNode(node);
if (callableId !== null && stack.at(-1) === callableId) stack.pop();
};
const spawnId = (candidate: SpawnCandidate): string =>
`child:spawn:${String(candidate.node.start ?? -1)}:${String(candidate.node.end ?? -1)}`;