mirror/rea
1
0
Fork 0
mirror of https://github.com/morluto/rea synced 2026-10-27 06:33:32 -04:00
Code Issues Packages Projects Releases Wiki Activity

test: remove duplicate result assertions before throwing guards

Browse Source
This commit is contained in:
morluto
2026-10-09 02:33:01 +08:00
parent 5945915f91
commit a1b7d40bb0
33 changed files with 0 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/application/javascript/JavaScriptApplicationCancellation.test.ts
-2
View File
@@ -43,7 +43,6 @@ describe("JavaScript analysis cancellation before publication", () => {
},
);
expect(requested).toBe(true);
expect(result.ok).toBe(false);
if (result.ok)
throw new Error("Cancelled analysis must not publish Evidence");
expect(projectAnalysisError(result.error)).toMatchObject({
@@ -68,7 +67,6 @@ describe("JavaScript analysis cancellation before publication", () => {
},
},
);
expect(result.ok).toBe(false);
if (result.ok) throw new Error("Expected cancellation before admission");
expect(projectAnalysisError(result.error)).toMatchObject({
details: { reason: "cancelled" },
src/application/javascript/JavaScriptApplicationService.test.ts
-5
View File
@@ -30,7 +30,6 @@ describe("JavaScript application failure diagnostics", () => {
},
);
expect(result.ok).toBe(false);
if (result.ok) throw new Error("Expected analysis failure");
expect(result.error.cause).toBe(cause);
expect(projectAnalysisError(result.error)).toMatchObject({
@@ -59,7 +58,6 @@ describe("JavaScript application failure diagnostics", () => {
},
},
);
expect(result.ok).toBe(false);
if (result.ok) throw new Error("Expected analysis failure");
expect(result.error.cause).toBe(cause);
expect(projectAnalysisError(result.error)).toMatchObject({
@@ -84,7 +82,6 @@ describe("JavaScript application failure diagnostics", () => {
input_path: join(root, "missing"),
format: "directory",
});
expect(result.ok).toBe(false);
if (result.ok) throw new Error("Expected missing artifact failure");
expect(projectAnalysisError(result.error)).toMatchObject({
code: "artifact_operation_failed",
@@ -107,7 +104,6 @@ describe("JavaScript application failure diagnostics", () => {
},
},
);
expect(result.ok).toBe(false);
if (result.ok) throw new Error("Expected analysis failure");
expect(projectAnalysisError(result.error)).toMatchObject({
code: "execution_failure",
@@ -140,7 +136,6 @@ describe("JavaScript application failure diagnostics", () => {
},
},
);
expect(result.ok).toBe(false);
if (result.ok) throw new Error("Expected analysis failure");
expect(projectAnalysisError(result.error)).toMatchObject({
code: "execution_failure",
src/application/javascript/JavaScriptFileUrlPaths.test.ts
-1
View File
@@ -61,7 +61,6 @@ describe("source-relative file URL paths", () => {
input_path: root,
format: "directory",
});
expect(result.ok).toBe(true);
if (!result.ok) throw result.error;
const { graph } = javascriptApplicationAnalysisResultSchema.parse(
result.value.normalized_result,
src/application/javascript/JavaScriptModuleSpecifierPaths.test.ts
-2
View File
@@ -124,7 +124,6 @@ describe("ESM module URL decoding", () => {
input_path: root,
format: "directory",
});
expect(result.ok).toBe(true);
if (!result.ok) throw result.error;
const { graph } = javascriptApplicationAnalysisResultSchema.parse(
result.value.normalized_result,
@@ -235,7 +234,6 @@ describe("package exports URL paths", () => {
input_path: root,
format: "directory",
});
expect(result.ok).toBe(true);
if (!result.ok) throw result.error;
const { graph } = javascriptApplicationAnalysisResultSchema.parse(
result.value.normalized_result,
src/application/javascript/JavaScriptRecoveryService.test.ts
-1
View File
@@ -111,7 +111,6 @@ describe("JavaScript recovery workflow", () => {
),
});
const result = await service.recover(input);
expect(result.ok).toBe(false);
if (result.ok) throw new Error("expected invalid port output");
expect(result.error._tag).toBe("AnalysisOutputError");
});