mirror of
https://github.com/morluto/rea
synced 2026-10-26 22:28:27 -04:00
fix(javascript): align module lookup and source evidence
Preserve CommonJS literal paths and confined ESM URL semantics, including package main fallback, directory intent, Unicode identity, and present opaque modules. Parse extraction inputs at their AST/source owner, retain skipped HTML and source-map coverage, and distinguish endpoint candidates from proven receiver facts. Version structural fingerprints with computed literal contents and propagate them through worker contracts. Reviewed fixes include #1810, #1840, #2642, #2700, #2702, #2714, #2803, #2960, #2968, #2986, #3035, and #3036. Validation: 158 resolver tests passed; public CLI/MCP module lookup controls, package-main/Unicode workflows, and six builtin workflows passed in the current compiled lane. Worker schema/fingerprint regressions passed. Large public pdf.js completion and real Electron analysis remain unverified.
This commit is contained in:
@@ -2,6 +2,7 @@ import { parse } from "@babel/parser";
|
||||
import { describe, expect, it } from "vitest";
|
||||
|
||||
import { fingerprintJavaScriptAst } from "./javascriptAstFingerprint.js";
|
||||
import { analyzeJavaScriptStaticSource } from "./javascriptStaticAnalysis.js";
|
||||
|
||||
describe("JavaScript AST fingerprints", () => {
|
||||
it("includes complete literal values in the fingerprint", () => {
|
||||
@@ -14,3 +15,62 @@ describe("JavaScript AST fingerprints", () => {
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
it.each(["obj[key]", "obj?.[key]"])(
|
||||
"ignores a local computed key binding in %s",
|
||||
(expression) => {
|
||||
const left = parse(`function read(obj, key) { return ${expression}; }`);
|
||||
const renamed = expression
|
||||
.replace("obj", "value")
|
||||
.replace("key", "selector");
|
||||
const right = parse(
|
||||
`function read(value, selector) { return ${renamed}; }`,
|
||||
);
|
||||
expect(fingerprintJavaScriptAst(left)).toBe(
|
||||
fingerprintJavaScriptAst(right),
|
||||
);
|
||||
},
|
||||
);
|
||||
|
||||
it("distinguishes computed reads from fixed named members", () => {
|
||||
expect(fingerprintJavaScriptAst(parse("obj[key]"))).not.toBe(
|
||||
fingerprintJavaScriptAst(parse("obj.key")),
|
||||
);
|
||||
expect(fingerprintJavaScriptAst(parse("obj.key"))).not.toBe(
|
||||
fingerprintJavaScriptAst(parse("obj.other")),
|
||||
);
|
||||
expect(fingerprintJavaScriptAst(parse('obj["key"]'))).not.toBe(
|
||||
fingerprintJavaScriptAst(parse('obj["other"]')),
|
||||
);
|
||||
});
|
||||
|
||||
it.each([
|
||||
["obj[`left`]", "obj[`right`]"],
|
||||
["obj[``]", "obj[`right`]"],
|
||||
["obj[true]", "obj[false]"],
|
||||
["obj[null]", "obj[false]"],
|
||||
['obj["" ]', 'obj["right"]'],
|
||||
["obj[`prefix-${key}`]", "obj[`changed-${key}`]"],
|
||||
])("retains computed literal contents in %s", (left, right) => {
|
||||
expect(fingerprintJavaScriptAst(parse(left))).not.toBe(
|
||||
fingerprintJavaScriptAst(parse(right)),
|
||||
);
|
||||
});
|
||||
|
||||
it("keeps renamed computed-key bundle modules structurally matchable", () => {
|
||||
const source = (name: string) => `globalThis.webpackChunkApp.push([[1], {
|
||||
17(module, exports) { const ${name} = selectKey(); exports.read = value[${name}]; }
|
||||
}]);`;
|
||||
const before = analyzeJavaScriptStaticSource(source("key"))
|
||||
.bundler_registrations[0]?.modules[0];
|
||||
const after = analyzeJavaScriptStaticSource(source("selector"))
|
||||
.bundler_registrations[0]?.modules[0];
|
||||
expect(before).toBeDefined();
|
||||
expect(after).toBeDefined();
|
||||
expect(before?.structural_fingerprint_algorithm).toBe("babel-ast-v2");
|
||||
expect(before?.source_sha256).not.toBe(after?.source_sha256);
|
||||
expect(before?.structural_fingerprint_sha256).toMatch(/^[a-f0-9]{64}$/u);
|
||||
expect(before?.structural_fingerprint_sha256).toBe(
|
||||
after?.structural_fingerprint_sha256,
|
||||
);
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user