fix(javascript): preserve runtime path bytes and Electron ownership (#4941)

* fix(javascript): preserve literal percent runtime paths * fix(javascript): ignore resolve prefixes before the final anchor * fix(electron): retain application roots for loadFile declarations * fix(electron): resolve loadFile from enclosing application package * fix(electron): retain outer application root across package scopes * fix(electron): derive application ownership from inventoried packages * fix(electron): retain resolved package entrypoint ownership * fix(electron): preserve competing application ownership * fix(electron): retain invalid and omitted runtime ownership * fix(electron): preserve omitted module ownership and runtime paths * fix(electron): preserve proven roots before confining page paths * fix(electron): retain possible owners behind missing imports * fix(electron): distinguish absent imports and owned page candidates * fix(electron): keep unavailable JSON out of owner gaps * fix(electron): retain exact loader formats and default entry status * fix(electron): retain unavailable entrypoint ownership candidates * test(ghidra): preserve Windows Node probe prerequisites * test(ghidra): assert cancellation during profile shutdown * fix(electron): separate examined imports from frontend ownership * fix(electron): retain unavailable directory entrypoint owners * test(jeb): retain Linux ownership prerequisite in isolation * fix(javascript): retain unchecked loader ownership and literal main paths * fix(javascript): preserve runtime paths and call-site module aliases * fix(javascript): bound module alias traversal and preserve projections * fix(javascript): retain host module and nested artifact path boundaries * fix(javascript): preserve ESM and archive module loader provenance * test(javascript): distinguish unmapped containers from missing exports * fix: retain default module aliases and Electron builtin imports * fix: preserve host file URL and inward ASAR ownership * fix: preserve CommonJS file URL classification in CI fixtures * fix: retain bound module loaders and Windows entrypoint uncertainty * fix: retain ASAR uncertainty and invalidate changed Electron app roots * fix(javascript): retain ownership uncertainty across loader boundaries * fix(javascript): preserve loader sources and bound alias queries * fix(javascript): retain destructured loader sources * fix(javascript): preserve loader uncertainty at resolution boundaries * fix(javascript): preserve callable and package launch ownership * fix(javascript): preserve captured values across member reads * test(process): assert tagged filesystem cancellation failures * fix(javascript): preserve inventory bases and invocation read timing * fix(javascript): preserve ownership across indirect and unread loads * test(javascript): order fixture directory creation on Windows * test(javascript): share ordered filesystem fixture writer * fix(javascript): unify loader provenance and package validation * fix(javascript): preserve captured Node require loader values * fix(javascript): preserve loader invocation authority * fix(javascript): verify generic loader invocation authority * fix(javascript): preserve conditional loader method alternatives * fix(javascript): require proven factories for source association * fix(javascript): honor replaced Electron app path setters * fix(javascript): prove path and assignment source ownership * fix(javascript): retain native delegate eligibility through shared writes * fix(process): settle stale baseline errors after confirmed absence * fix(javascript): preserve assignment and path boundary evidence * fix(javascript): prove source-directory resolve anchors * fix: preserve application path provenance and portable schemas * fix(javascript): retain CommonJS exported setter effects * fix: isolate Linux identity observations and retain native module exports * fix(javascript): preserve published app and helper provenance * fix(javascript): normalize typed stores and native path fixtures
2026-10-27 06:33:32 -04:00 · 2026-10-20 17:25:19 +08:00
parent d532b18123
commit e9fc8fb30c
149 changed files with 16881 additions and 988 deletions
@@ -0,0 +1,79 @@
+import { createRequire } from "node:module";
+import * as path from "node:path";
+import { runInNewContext } from "node:vm";
+import { expect, it } from "vitest";
+
+import { analyzeJavaScriptStaticSource } from "./javascriptStaticAnalysis.js";
+
+const named = "import {createRequire as make} from 'node:module';";
+const namespace = "import * as mod from 'node:module';";
+const cases = [
+  {
+    name: "own call replacement",
+    prefix: named,
+    body: (base: string) =>
+      `const load=make(${base});load.call=()=>({kind:'local'});load.call(null,'node:path');`,
+    host: false,
+  },
+  {
+    name: "own apply replacement",
+    prefix: named,
+    body: (base: string) =>
+      `const load=make(${base});load.apply=()=>({kind:'local'});load.apply(null,['node:path']);`,
+    host: false,
+  },
+  {
+    name: "callable captured before method replacement",
+    prefix: named,
+    body: (base: string) =>
+      `const load=make(${base});const saved=load;load.call=()=>({kind:'local'});saved('node:path');`,
+    host: true,
+  },
+  {
+    name: "mutable default factory replacement",
+    prefix: namespace,
+    body: (base: string) =>
+      `mod.default.createRequire=()=>()=>({kind:'local'});const load=mod.default.createRequire(${base});load('node:path');`,
+    host: false,
+  },
+  {
+    name: "factory captured before its default slot replacement",
+    prefix: namespace,
+    body: (base: string) =>
+      `const make=mod.default.createRequire;mod.default.createRequire=()=>()=>({kind:'local'});const load=make(${base});load('node:path');`,
+    host: true,
+  },
+  {
+    name: "loader created before its default factory replacement",
+    prefix: namespace,
+    body: (base: string) =>
+      `const load=mod.default.createRequire(${base});mod.default.createRequire=()=>()=>({kind:'local'});load('node:path');`,
+    host: true,
+  },
+];
+
+it.each(cases)(
+  "keeps loader and selected member identity for $name",
+  ({ prefix, body, host }) => {
+    // The mutable namespace default belongs to this VM fixture. Native created
+    // require functions retain their real Node behavior without patching builtins.
+    const result = runInNewContext(body("base"), {
+      make: createRequire,
+      mod: { default: { createRequire } },
+      base: import.meta.url,
+    });
+    expect(result.join === path.join).toBe(host);
+    if (!host) expect(result.kind).toBe("local");
+    const analysis = analyzeJavaScriptStaticSource(
+      `${prefix}${body("import.meta.url")}`,
+    );
+    expect(analysis.parse_error_count).toBe(0);
+    expect(
+      analysis.references.filter(({ kind }) => kind === "require"),
+    ).toEqual(
+      host
+        ? [expect.objectContaining({ kind: "require", specifier: "node:path" })]
+        : [],
+    );
+  },
+);