mirror of
https://github.com/morluto/rea
synced 2026-10-27 22:45:19 -04:00
fix(javascript): preserve runtime path bytes and Electron ownership (#4941)
* fix(javascript): preserve literal percent runtime paths * fix(javascript): ignore resolve prefixes before the final anchor * fix(electron): retain application roots for loadFile declarations * fix(electron): resolve loadFile from enclosing application package * fix(electron): retain outer application root across package scopes * fix(electron): derive application ownership from inventoried packages * fix(electron): retain resolved package entrypoint ownership * fix(electron): preserve competing application ownership * fix(electron): retain invalid and omitted runtime ownership * fix(electron): preserve omitted module ownership and runtime paths * fix(electron): preserve proven roots before confining page paths * fix(electron): retain possible owners behind missing imports * fix(electron): distinguish absent imports and owned page candidates * fix(electron): keep unavailable JSON out of owner gaps * fix(electron): retain exact loader formats and default entry status * fix(electron): retain unavailable entrypoint ownership candidates * test(ghidra): preserve Windows Node probe prerequisites * test(ghidra): assert cancellation during profile shutdown * fix(electron): separate examined imports from frontend ownership * fix(electron): retain unavailable directory entrypoint owners * test(jeb): retain Linux ownership prerequisite in isolation * fix(javascript): retain unchecked loader ownership and literal main paths * fix(javascript): preserve runtime paths and call-site module aliases * fix(javascript): bound module alias traversal and preserve projections * fix(javascript): retain host module and nested artifact path boundaries * fix(javascript): preserve ESM and archive module loader provenance * test(javascript): distinguish unmapped containers from missing exports * fix: retain default module aliases and Electron builtin imports * fix: preserve host file URL and inward ASAR ownership * fix: preserve CommonJS file URL classification in CI fixtures * fix: retain bound module loaders and Windows entrypoint uncertainty * fix: retain ASAR uncertainty and invalidate changed Electron app roots * fix(javascript): retain ownership uncertainty across loader boundaries * fix(javascript): preserve loader sources and bound alias queries * fix(javascript): retain destructured loader sources * fix(javascript): preserve loader uncertainty at resolution boundaries * fix(javascript): preserve callable and package launch ownership * fix(javascript): preserve captured values across member reads * test(process): assert tagged filesystem cancellation failures * fix(javascript): preserve inventory bases and invocation read timing * fix(javascript): preserve ownership across indirect and unread loads * test(javascript): order fixture directory creation on Windows * test(javascript): share ordered filesystem fixture writer * fix(javascript): unify loader provenance and package validation * fix(javascript): preserve captured Node require loader values * fix(javascript): preserve loader invocation authority * fix(javascript): verify generic loader invocation authority * fix(javascript): preserve conditional loader method alternatives * fix(javascript): require proven factories for source association * fix(javascript): honor replaced Electron app path setters * fix(javascript): prove path and assignment source ownership * fix(javascript): retain native delegate eligibility through shared writes * fix(process): settle stale baseline errors after confirmed absence * fix(javascript): preserve assignment and path boundary evidence * fix(javascript): prove source-directory resolve anchors * fix: preserve application path provenance and portable schemas * fix(javascript): retain CommonJS exported setter effects * fix: isolate Linux identity observations and retain native module exports * fix(javascript): preserve published app and helper provenance * fix(javascript): normalize typed stores and native path fixtures
This commit is contained in:
@@ -7,6 +7,7 @@ import { describe, expect, it } from "vitest";
|
||||
import { analyzeJavaScriptStaticSource } from "./javascriptStaticAnalysis.js";
|
||||
import { parserPluginsForPath } from "./javascriptSourceParser.js";
|
||||
import {
|
||||
calleeName,
|
||||
staticPath,
|
||||
staticPathResolutionContext,
|
||||
} from "./javascriptStaticAnalysisHelpers.js";
|
||||
@@ -27,6 +28,22 @@ const anchoredExpressions = [
|
||||
['path[`resolve`](__dirname, "preload.js")', "preload.js"],
|
||||
['path.posix.resolve("ignored", __dirname, "preload.js")', "preload.js"],
|
||||
['path.resolve("/ignored", __dirname, "preload.js")', "preload.js"],
|
||||
['path.resolve(runtimeBase, "/app/preload.js")', "/app/preload.js"],
|
||||
['path.resolve(runtimeBase, __dirname, "preload.js")', "preload.js"],
|
||||
['path.resolve(...parts, "/app/preload.js")', "/app/preload.js"],
|
||||
['path.resolve(42, "/app/preload.js")', "/app/preload.js"],
|
||||
[
|
||||
'path.resolve(new URL("./", import.meta.url), __dirname, "preload.js")',
|
||||
"preload.js",
|
||||
],
|
||||
[
|
||||
'path.resolve(new URL("./", import.meta.url), dirname(fileURLToPath(import.meta.url)), "preload.js")',
|
||||
"preload.js",
|
||||
],
|
||||
[
|
||||
'path.posix.resolve(new URL("./", import.meta.url), "/app", "preload.js")',
|
||||
"/app/preload.js",
|
||||
],
|
||||
[
|
||||
'path.posix.resolve("ignored", dirname(fileURLToPath(import.meta.url)), "preload.js")',
|
||||
"preload.js",
|
||||
@@ -58,13 +75,9 @@ const unknownExpressions = [
|
||||
"path.posix.resolve()",
|
||||
'path.resolve("sub", "../preload.js")',
|
||||
'path.resolve("", "")',
|
||||
'path.resolve(runtimeBase, "/app/preload.js")',
|
||||
'path.resolve("/app", runtimeFile)',
|
||||
'path.resolve(runtimeBase, __dirname, "preload.js")',
|
||||
"path.resolve(__dirname, runtimeFile)",
|
||||
'path.resolve(...parts, "/app/preload.js")',
|
||||
'path.resolve("/app", ...parts)',
|
||||
'path.resolve(42, "/app/preload.js")',
|
||||
'path.resolve("/app", null)',
|
||||
"path.resolve(`/app/${runtimeFile}`)",
|
||||
'path.win32.resolve("/app", "/shared/preload.js")',
|
||||
@@ -73,6 +86,12 @@ const unknownExpressions = [
|
||||
'resolve("/app", "preload.js")',
|
||||
'__dirname + "preload.js"',
|
||||
'path.dirname(__filename) + "preload.js"',
|
||||
'new URL("./pre%2Fload.js", import.meta.url)',
|
||||
'path.join(new URL("./", import.meta.url), "preload.js")',
|
||||
'path.resolve(new URL("./", import.meta.url), "preload.js")',
|
||||
'path.join(__dirname, new URL("./pre%2Fload.js", import.meta.url))',
|
||||
'path.resolve(__dirname, new URL("./", import.meta.url), "preload.js")',
|
||||
'path.resolve("/app", new URL("./", import.meta.url), "preload.js")',
|
||||
];
|
||||
|
||||
const pathValueExpressions = [
|
||||
@@ -324,6 +343,36 @@ it.each([
|
||||
);
|
||||
});
|
||||
|
||||
it("decodes a source-relative file URL once before composing a filesystem path", () => {
|
||||
assertPathProjection(
|
||||
'fileURLToPath(new URL("./pre%252Fload.js", import.meta.url))',
|
||||
"./pre%2Fload.js",
|
||||
"filesystem-expression",
|
||||
);
|
||||
assertPathProjection(
|
||||
'path.join(dirname(fileURLToPath(import.meta.url)), "pre%2Fload.js")',
|
||||
"pre%2Fload.js",
|
||||
"filesystem-expression",
|
||||
);
|
||||
});
|
||||
|
||||
it("retains Worker URL references through their separate URL-aware producer", () => {
|
||||
const specifier = "./worker%252Fentry.js?version=1#worker";
|
||||
const analysis = analyzeJavaScriptStaticSource(`
|
||||
import { Worker } from "node:worker_threads";
|
||||
new Worker(new URL(${JSON.stringify(specifier)}, import.meta.url));
|
||||
`);
|
||||
|
||||
expect(analysis.parse_status).toBe("complete");
|
||||
expect(analysis.parse_error_count).toBe(0);
|
||||
expect(
|
||||
analysis.references
|
||||
.filter(({ kind }) => kind === "worker")
|
||||
.map(({ specifier, expression }) => ({ specifier, expression })),
|
||||
).toEqual([{ specifier, expression: null }]);
|
||||
expect(analysis.role_paths).toEqual([]);
|
||||
});
|
||||
|
||||
it.each([
|
||||
'fileURLToPath("file:///app/%2Fpreload.js")',
|
||||
'fileURLToPath("file:///app/%5Cpreload.js")',
|
||||
@@ -344,7 +393,8 @@ const parsePathExpression = (expression: string) =>
|
||||
|
||||
const analyzePathConsumers = (expression: string) => {
|
||||
const property = `preload: ${expression}`;
|
||||
const genericPrefix = "const options = { ";
|
||||
const genericPrefix =
|
||||
'import path, {dirname} from "node:path"; import {fileURLToPath} from "node:url"; const options = { ';
|
||||
const windowPrefix = "new BrowserWindow({ webPreferences: { ";
|
||||
const windowExpression = `${windowPrefix}${property} } })`;
|
||||
const utilityExpression = `utilityProcess.fork(${expression})`;
|
||||
@@ -366,8 +416,24 @@ const assertPathProjection = (
|
||||
context: JavaScriptStaticPathContext,
|
||||
) => {
|
||||
const node = parsePathExpression(expression);
|
||||
expect(staticPath(node)).toBe(path);
|
||||
expect(staticPathResolutionContext(node)).toBe(context);
|
||||
// This syntax matrix supplies identity explicitly; full-source cases prove it.
|
||||
const nodePathResolve = (
|
||||
callee: import("@babel/types").Node,
|
||||
fact?: "source-directory",
|
||||
) => {
|
||||
if (fact === "source-directory") {
|
||||
const name = calleeName(
|
||||
callee.type === "CallExpression" ? callee.callee : callee,
|
||||
);
|
||||
return (
|
||||
name === "__dirname" || name === "dirname" || name.endsWith(".dirname")
|
||||
);
|
||||
}
|
||||
const name = calleeName(callee);
|
||||
return name.endsWith(".resolve") && !name.includes("win32");
|
||||
};
|
||||
expect(staticPath(node, nodePathResolve)).toBe(path);
|
||||
expect(staticPathResolutionContext(node, nodePathResolve)).toBe(context);
|
||||
const {
|
||||
analysis,
|
||||
property,
|
||||
|
||||
Reference in New Issue
Block a user