mirror of
https://github.com/morluto/rea
synced 2026-10-27 14:42:18 -04:00
fix(javascript): preserve runtime path bytes and Electron ownership (#4941)
* fix(javascript): preserve literal percent runtime paths * fix(javascript): ignore resolve prefixes before the final anchor * fix(electron): retain application roots for loadFile declarations * fix(electron): resolve loadFile from enclosing application package * fix(electron): retain outer application root across package scopes * fix(electron): derive application ownership from inventoried packages * fix(electron): retain resolved package entrypoint ownership * fix(electron): preserve competing application ownership * fix(electron): retain invalid and omitted runtime ownership * fix(electron): preserve omitted module ownership and runtime paths * fix(electron): preserve proven roots before confining page paths * fix(electron): retain possible owners behind missing imports * fix(electron): distinguish absent imports and owned page candidates * fix(electron): keep unavailable JSON out of owner gaps * fix(electron): retain exact loader formats and default entry status * fix(electron): retain unavailable entrypoint ownership candidates * test(ghidra): preserve Windows Node probe prerequisites * test(ghidra): assert cancellation during profile shutdown * fix(electron): separate examined imports from frontend ownership * fix(electron): retain unavailable directory entrypoint owners * test(jeb): retain Linux ownership prerequisite in isolation * fix(javascript): retain unchecked loader ownership and literal main paths * fix(javascript): preserve runtime paths and call-site module aliases * fix(javascript): bound module alias traversal and preserve projections * fix(javascript): retain host module and nested artifact path boundaries * fix(javascript): preserve ESM and archive module loader provenance * test(javascript): distinguish unmapped containers from missing exports * fix: retain default module aliases and Electron builtin imports * fix: preserve host file URL and inward ASAR ownership * fix: preserve CommonJS file URL classification in CI fixtures * fix: retain bound module loaders and Windows entrypoint uncertainty * fix: retain ASAR uncertainty and invalidate changed Electron app roots * fix(javascript): retain ownership uncertainty across loader boundaries * fix(javascript): preserve loader sources and bound alias queries * fix(javascript): retain destructured loader sources * fix(javascript): preserve loader uncertainty at resolution boundaries * fix(javascript): preserve callable and package launch ownership * fix(javascript): preserve captured values across member reads * test(process): assert tagged filesystem cancellation failures * fix(javascript): preserve inventory bases and invocation read timing * fix(javascript): preserve ownership across indirect and unread loads * test(javascript): order fixture directory creation on Windows * test(javascript): share ordered filesystem fixture writer * fix(javascript): unify loader provenance and package validation * fix(javascript): preserve captured Node require loader values * fix(javascript): preserve loader invocation authority * fix(javascript): verify generic loader invocation authority * fix(javascript): preserve conditional loader method alternatives * fix(javascript): require proven factories for source association * fix(javascript): honor replaced Electron app path setters * fix(javascript): prove path and assignment source ownership * fix(javascript): retain native delegate eligibility through shared writes * fix(process): settle stale baseline errors after confirmed absence * fix(javascript): preserve assignment and path boundary evidence * fix(javascript): prove source-directory resolve anchors * fix: preserve application path provenance and portable schemas * fix(javascript): retain CommonJS exported setter effects * fix: isolate Linux identity observations and retain native module exports * fix(javascript): preserve published app and helper provenance * fix(javascript): normalize typed stores and native path fixtures
This commit is contained in:
ShuaixinHuang
@@ -0,0 +1,121 @@
|
||||
import { createRequire, wrap } from "node:module";
|
||||
import { posix } from "node:path";
|
||||
import { fileURLToPath } from "node:url";
|
||||
import { runInThisContext } from "node:vm";
|
||||
|
||||
import { expect, it } from "vitest";
|
||||
|
||||
import { analyzeJavaScriptStaticSource } from "./javascriptStaticAnalysis.js";
|
||||
|
||||
it.each([false, true])(
|
||||
"preserves only untouched authored CommonJS dirname vars: assigned=%s",
|
||||
(assigned) => {
|
||||
const setup = `const path=require('node:path/posix');var __dirname;${assigned ? '__dirname="relative";' : ""}`;
|
||||
const fixture = { exports: "" };
|
||||
const run = runInThisContext(
|
||||
wrap(`${setup}module.exports=path.join(__dirname,'preload.cjs');`),
|
||||
);
|
||||
run(
|
||||
fixture.exports,
|
||||
createRequire(import.meta.url),
|
||||
fixture,
|
||||
"/source/app/main.cjs",
|
||||
"/source/app",
|
||||
);
|
||||
expect(fixture.exports).toBe(
|
||||
assigned ? "relative/preload.cjs" : "/source/app/preload.cjs",
|
||||
);
|
||||
const analysis = analyzeJavaScriptStaticSource(
|
||||
`${setup}const{BrowserWindow}=require('electron');new BrowserWindow({webPreferences:{preload:path.join(__dirname,'preload.cjs')}});`,
|
||||
);
|
||||
expect(analysis.electron.browser_windows).toMatchObject([
|
||||
{ preload_path: assigned ? null : "preload.cjs" },
|
||||
]);
|
||||
},
|
||||
);
|
||||
|
||||
it("keeps local dirname methods from proving a source anchor", () => {
|
||||
const helper = { dirname: (_url: string) => "/other" };
|
||||
expect(
|
||||
posix.resolve(
|
||||
"/runtime/base",
|
||||
helper.dirname("file:///source/app/main.mjs"),
|
||||
"decoy.cjs",
|
||||
),
|
||||
).toBe("/other/decoy.cjs");
|
||||
const analysis = analyzeJavaScriptStaticSource(
|
||||
`import path from 'node:path';const helper={dirname:()=>'/other'};const{BrowserWindow}=require('electron');new BrowserWindow({webPreferences:{preload:path.resolve(runtimeBase,helper.dirname(import.meta.url),'decoy.cjs')}});`,
|
||||
);
|
||||
expect(analysis.electron.browser_windows).toMatchObject([
|
||||
{ preload_path: null },
|
||||
]);
|
||||
});
|
||||
|
||||
it("retains a proven Node dirname of the decoded module URL", () => {
|
||||
expect(
|
||||
posix.dirname(
|
||||
fileURLToPath("file:///source/app/main.mjs", { windows: false }),
|
||||
),
|
||||
).toBe("/source/app");
|
||||
const analysis = analyzeJavaScriptStaticSource(
|
||||
`import path from 'node:path';import{fileURLToPath}from'node:url';const{BrowserWindow}=require('electron');new BrowserWindow({webPreferences:{preload:path.resolve(runtimeBase,path.dirname(fileURLToPath(import.meta.url)),'preload.cjs')}});`,
|
||||
);
|
||||
expect(analysis.electron.browser_windows).toMatchObject([
|
||||
{ preload_path: "preload.cjs" },
|
||||
]);
|
||||
});
|
||||
|
||||
it.each([false, true])(
|
||||
"preserves a decoded module URL through its real dirname owner: local=%s",
|
||||
(local) => {
|
||||
const decoded = fileURLToPath("file:///source/app/main.mjs", {
|
||||
windows: false,
|
||||
});
|
||||
const helper = { dirname: (_file: string) => "/other" };
|
||||
expect(local ? helper.dirname(decoded) : posix.dirname(decoded)).toBe(
|
||||
local ? "/other" : "/source/app",
|
||||
);
|
||||
const analysis = analyzeJavaScriptStaticSource(`
|
||||
import path from 'node:path';import*as url from 'node:url';
|
||||
const helper={dirname:()=>'/other'};const{BrowserWindow}=require('electron');
|
||||
new BrowserWindow({webPreferences:{preload:path.resolve(runtimeBase,${local ? "helper" : "path"}.dirname(url.fileURLToPath(import.meta.url)),'preload.cjs')}});
|
||||
`);
|
||||
expect(analysis.electron.browser_windows).toMatchObject([
|
||||
{ preload_path: local ? null : "preload.cjs" },
|
||||
]);
|
||||
},
|
||||
);
|
||||
|
||||
it("does not use a URL string as a filesystem source-file anchor", () => {
|
||||
expect(posix.dirname("file:///source/app/main.mjs")).not.toBe("/source/app");
|
||||
const analysis = analyzeJavaScriptStaticSource(
|
||||
`import path from 'node:path';const{BrowserWindow}=require('electron');new BrowserWindow({webPreferences:{preload:path.resolve(runtimeBase,path.dirname(import.meta.url),'decoy.cjs')}});`,
|
||||
);
|
||||
expect(analysis.electron.browser_windows).toMatchObject([
|
||||
{ preload_path: null },
|
||||
]);
|
||||
});
|
||||
|
||||
it.each([false, true])(
|
||||
"proves the CommonJS filename dirname owner: local=%s",
|
||||
(local) => {
|
||||
const analysis = analyzeJavaScriptStaticSource(
|
||||
`const path=require('node:path');const helper={dirname:()=>'.'};const{BrowserWindow}=require('electron');new BrowserWindow({webPreferences:{preload:path.resolve(runtimeBase,${local ? "helper" : "path"}.dirname(__filename),'decoy.cjs')}});`,
|
||||
);
|
||||
expect(analysis.electron.browser_windows).toMatchObject([
|
||||
{ preload_path: local ? null : "decoy.cjs" },
|
||||
]);
|
||||
},
|
||||
);
|
||||
|
||||
it.each([false, true])(
|
||||
"preserves the utility-process dirname parameter until assigned: assigned=%s",
|
||||
(assigned) => {
|
||||
const analysis = analyzeJavaScriptStaticSource(
|
||||
`var __dirname;${assigned ? "__dirname='relative';" : ""}const path=require('node:path');const{utilityProcess}=require('electron');utilityProcess.fork(path.join(__dirname,'worker.cjs'));`,
|
||||
);
|
||||
expect(analysis.electron.utility_processes).toMatchObject([
|
||||
{ module_path: assigned ? null : "worker.cjs" },
|
||||
]);
|
||||
},
|
||||
);
|
||||
Reference in New Issue
Block a user