mirror/rea
1
0
Fork 0
mirror of https://github.com/morluto/rea synced 2026-10-26 14:25:49 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor(javascript): own paired graph evidence resolution

Browse Source
This commit is contained in:
morluto
2026-10-24 01:11:57 +08:00
parent 6cd3fa09b1
commit f276bcbf6c
4 changed files with 83 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/application/javascript/JavaScriptApplicationWorkflowService.ts
+39 -38
View File
@@ -37,6 +37,7 @@ import {
applicationGraphEvidenceInputError,
parseApplicationGraphEvidence,
parseNativeApplicationEvidence,
type ApplicationGraphEvidenceSource,
} from "./JavaScriptApplicationEvidenceGraph.js";
import {
createApplicationFeatureTraceEvidence,
@@ -81,6 +82,36 @@ const resolveWorkflowEvidence = (
: ok(raw);
};
/** Resolve both selections before authenticating either graph, retaining diagnostic inputs. */
const resolveApplicationGraphPair = (
operation: string,
input: { readonly left: unknown; readonly right: unknown },
lookup: EvidenceLookup | undefined,
): Result<
{
readonly left: ApplicationGraphEvidenceSource;
readonly right: ApplicationGraphEvidenceSource;
readonly selected: { readonly left: unknown; readonly right: unknown };
},
AnalysisError
> => {
const selectedLeft = resolveWorkflowEvidence(input.left, lookup);
if (!selectedLeft.ok) return selectedLeft;
const selectedRight = resolveWorkflowEvidence(input.right, lookup);
if (!selectedRight.ok) return selectedRight;
const left = parseApplicationGraphEvidence(selectedLeft.value, ["left"]);
if (!left.ok)
return err(applicationGraphEvidenceInputError(operation, left.error));
const right = parseApplicationGraphEvidence(selectedRight.value, ["right"]);
if (!right.ok)
return err(applicationGraphEvidenceInputError(operation, right.error));
return ok({
left: left.value,
right: right.value,
selected: { left: selectedLeft.value, right: selectedRight.value },
});
};
/** Authenticate Evidence and derive one bounded cross-layer feature trace. */
export const traceApplicationFeatureEvidence = (
rawInput: unknown,
@@ -163,23 +194,10 @@ export const compareApplicationVersionsEvidence = (
cause: request.error,
}),
);
const selectedLeft = resolveWorkflowEvidence(request.data.left, lookup);
if (!selectedLeft.ok) return selectedLeft;
const selectedRight = resolveWorkflowEvidence(request.data.right, lookup);
if (!selectedRight.ok) return selectedRight;
const input = {
...request.data,
left: selectedLeft.value,
right: selectedRight.value,
};
const leftResult = parseApplicationGraphEvidence(input.left, ["left"]);
if (!leftResult.ok)
return err(applicationGraphEvidenceInputError(operation, leftResult.error));
const rightResult = parseApplicationGraphEvidence(input.right, ["right"]);
if (!rightResult.ok)
return err(
applicationGraphEvidenceInputError(operation, rightResult.error),
);
const pair = resolveApplicationGraphPair(operation, request.data, lookup);
if (!pair.ok) return pair;
const { left, right } = pair.value;
const input = { ...request.data, ...pair.value.selected };
const leftNativeResult = parseNativeApplicationEvidence(
input.left_native_observations,
["left_native_observations"],
@@ -196,8 +214,6 @@ export const compareApplicationVersionsEvidence = (
return err(
applicationGraphEvidenceInputError(operation, rightNativeResult.error),
);
const left = leftResult.value;
const right = rightResult.value;
const leftNative = leftNativeResult.value;
const rightNative = rightNativeResult.value;
const identities = applicationVersionIdentitiesSchema.safeParse({
@@ -297,25 +313,10 @@ export const compareJavaScriptExportShapesEvidence = (
cause: request.error,
}),
);
const selectedLeft = resolveWorkflowEvidence(request.data.left, lookup);
if (!selectedLeft.ok) return selectedLeft;
const selectedRight = resolveWorkflowEvidence(request.data.right, lookup);
if (!selectedRight.ok) return selectedRight;
const input = {
...request.data,
left: selectedLeft.value,
right: selectedRight.value,
};
const leftResult = parseApplicationGraphEvidence(input.left, ["left"]);
if (!leftResult.ok)
return err(applicationGraphEvidenceInputError(operation, leftResult.error));
const rightResult = parseApplicationGraphEvidence(input.right, ["right"]);
if (!rightResult.ok)
return err(
applicationGraphEvidenceInputError(operation, rightResult.error),
);
const left = leftResult.value;
const right = rightResult.value;
const pair = resolveApplicationGraphPair(operation, request.data, lookup);
if (!pair.ok) return pair;
const { left, right } = pair.value;
const input = { ...request.data, ...pair.value.selected };
const identities = javaScriptExportShapeIdentitiesSchema.safeParse({
left: left.evidence,
right: right.evidence,