mirror of
https://github.com/morluto/rea
synced 2026-10-26 22:28:27 -04:00
morluto
cbc0dd1e7c
* fix(contracts)!: require absolute local paths for remaining caller-supplied file inputs Follow-up to the session snapshot/export tightening: the same invisible server-cwd resolution applied to open_binary target paths (parseBinaryTarget(path, process.cwd())), import_evidence_bundle bundle reads, firmware input files (resolve(raw)), browser executable launch paths (resolve-then-spawn), Electron executable/application/root paths (realpath on raw input), and the expected server path check. Each field gains the shared isAbsoluteLocalPath refinement plus a catalog-visible description, since JSON Schema cannot express the rule. Examples, scenario fixtures, and contract tests updated to absolute paths; new schema cases cover rejection/acceptance/omission per field. Explicitly unchanged (verified rooted or out of scope): inspect_plist paths (resolved against the target bundle dir), firmware output_directory (already provider-enforced), filesystem observation paths (resolved against the caller-supplied working_directory), keyed-archive member paths (archive-relative), JS evidence member paths (evidence-relative under root_alias), provider-internal execution schemas, CLI-only doctor flows, and CLI options (own resolve against the operator cwd). * fix(cli): resolve operator-relative paths before shared absolute-path validation The contract tightening rejects relative paths, but three CLI commands forward operator-relative input into the shared schemas: firmware commands pass raw args to FirmwareAnalysisService, and the Electron/browser scenario commands validate parsed scenario JSON directly. CLI paths are relative to the operator shell, so resolve them against the working directory first: resolve() in firmwareCommands, and a shared resolveCliJsonPaths JSON key-path helper (cliJsonInput) applied in electronCommands and cliBrowserScenarioCommands. MCP behavior is unchanged — MCP callers must still send absolute paths. Covers the regression with a relative-path firmware CLI acceptance test (asserts provider-stage capability_unavailable, not a validation error) and unit tests for the helper.
61 lines
2.3 KiB
TypeScript
61 lines
2.3 KiB
TypeScript
import { Cli } from "incur";
|
|
import { z } from "zod";
|
|
|
|
import { captureBrowserScenario } from "./application/BrowserScenarioCaptureService.js";
|
|
import { createBrowserScenarioProvider } from "./composition/browserScenario.js";
|
|
import { CLI_COMMANDS } from "./cliCommandNames.js";
|
|
import { parseCliJsonInput, resolveCliJsonPaths } from "./cliJsonInput.js";
|
|
import { logCliCommand } from "./cliLogging.js";
|
|
import { AnalysisInputError } from "./domain/analysisErrorCore.js";
|
|
import { projectAnalysisError } from "./domain/analysisErrorProjection.js";
|
|
import { projectInputIssues } from "./domain/inputIssueProjection.js";
|
|
import { browserScenarioSchema } from "./domain/browserScenario.js";
|
|
import type { JsonValue } from "./domain/jsonValue.js";
|
|
import type { Logger } from "./logger.js";
|
|
|
|
const OPERATION = "capture_browser_scenario";
|
|
|
|
/** Register the one-shot controlled browser scenario command. */
|
|
export const registerBrowserScenarioCommands = (
|
|
cli: ReturnType<typeof Cli.create>,
|
|
logger: Logger,
|
|
): void => {
|
|
cli.command(CLI_COMMANDS.captureBrowserScenario, {
|
|
description:
|
|
"Run one bounded Playwright browser scenario and return Evidence",
|
|
args: z.object({
|
|
inputJson: z
|
|
.string()
|
|
.describe("Inline browser scenario JSON or JSON file path"),
|
|
}),
|
|
run: ({ args }) =>
|
|
logCliCommand(logger, CLI_COMMANDS.captureBrowserScenario, async () => {
|
|
const input = await parseCliJsonInput(args.inputJson, OPERATION);
|
|
if (!input.ok) return input.error;
|
|
const scenario = browserScenarioSchema.safeParse(
|
|
resolveCliJsonPaths(input.value, [["browser", "executable_path"]]),
|
|
);
|
|
if (!scenario.success)
|
|
return cliError(
|
|
new AnalysisInputError(
|
|
OPERATION,
|
|
{ cause: scenario.error },
|
|
projectInputIssues(scenario.error.issues, input.value),
|
|
),
|
|
);
|
|
const result = await captureBrowserScenario(
|
|
createBrowserScenarioProvider(),
|
|
scenario.data,
|
|
);
|
|
return result.ok ? result.value : cliError(result.error);
|
|
}),
|
|
});
|
|
};
|
|
|
|
const cliError = (
|
|
error: Parameters<typeof projectAnalysisError>[0],
|
|
): JsonValue => ({
|
|
error: "Browser scenario capture failed",
|
|
...projectAnalysisError(error),
|
|
});
|