Files
rea/src/application/binary/BinarySessionStatus.test.ts
T
Jeff 7c6c25dda7 fix(artifacts): report target applicability in session discovery (#5763)
* fix(artifacts): report target applicability in session discovery

* fix(artifacts): preserve resolved target applicability facts

* fix(target): retain bundle metadata for explicit formats
2026-10-21 12:59:27 +08:00

447 lines
12 KiB
TypeScript

import type { BinaryTarget } from "../../domain/binaryTargetTypes.js";
import { describe, expect, it } from "vitest";
import type {
CapabilityDescriptor,
ProviderIdentity,
} from "../AnalysisProvider.js";
import {
expandProviderCapabilities,
sessionProvider,
type ProviderCapabilitySet,
} from "../../contracts/toolOutputSchemaPrimitives.js";
import { compareUnicodeCodePoints } from "../../domain/unicodeCodePointOrder.js";
import type { AnalysisProviderCandidateStatus } from "./AnalysisProviderRegistry.js";
import type {
SessionProviderRoute,
SessionProviderRouter,
} from "./SessionProviderRouter.js";
import { binarySessionStatus } from "./BinarySessionStatus.js";
import {
APPLE_DISPATCH_METADATA_ANALYSIS_PROFILE,
NATIVE_MACOS_PROVIDER_IDENTITY,
nativeMacOSCapabilities,
} from "../../native/NativeMacOSProviderMetadata.js";
const projectedStatusSchema = sessionProvider.pick({
capabilities: true,
analysis_provider_candidates: true,
});
const providerA: ProviderIdentity = {
id: "provider-a",
name: "Provider A",
version: "1.0",
};
const providerB: ProviderIdentity = {
id: "provider-b",
name: "Provider B",
version: "2.0",
};
const MUTATING_EFFECTS = {
mutates_artifact: true,
launches_process: false,
may_show_ui: false,
may_access_network: false,
may_write_filesystem: false,
changes_permissions: false,
requires_root: false,
};
type DescriptorOptions = {
readonly launchesProcess?: boolean;
} & (
| {
readonly available?: true;
readonly reason?: never;
readonly availabilityCode?: never;
}
| {
readonly available: false;
readonly reason?: string;
readonly availabilityCode?: "architecture_unsupported";
}
);
const descriptor = (
provider: ProviderIdentity,
operation: CapabilityDescriptor["operation"],
limitations: readonly string[],
options: DescriptorOptions = {},
): CapabilityDescriptor => {
const availability =
options.available === false
? {
available: false as const,
reason: options.reason ?? "Unavailable",
...(options.availabilityCode === undefined
? {}
: { availabilityCode: options.availabilityCode }),
}
: { available: true as const, reason: null };
return {
provider,
operation,
...availability,
effects: {
mutatesArtifact: true,
launchesProcess: options.launchesProcess ?? false,
mayShowUi: false,
mayAccessNetwork: false,
mayWriteFilesystem: false,
changesPermissions: false,
requiresRoot: false,
},
limitations,
};
};
const candidate = (
provider: ProviderIdentity,
capabilities: readonly CapabilityDescriptor[],
): AnalysisProviderCandidateStatus => ({
provider,
availability: {
status: "available",
code: null,
reason: null,
diagnostics: {},
},
targetSupport: {
status: "unknown",
code: null,
reason: "No target is open.",
diagnostics: {},
},
selected: true,
capabilities,
});
const project = async (
routeCapabilities: readonly CapabilityDescriptor[],
candidates: readonly AnalysisProviderCandidateStatus[],
runtimeUnavailability: ReadonlyMap<
string,
{ readonly reason: string }
> = new Map(),
target?: BinaryTarget,
) => {
const route: SessionProviderRoute = {
identity: providerA,
profile: null,
selection: undefined,
createClient: () => {
throw new Error("Projection does not create clients");
},
capabilities: new Map(
routeCapabilities.map((capability) => [capability.operation, capability]),
),
binding: null,
};
const router: Pick<SessionProviderRouter, "candidateStatuses"> = {
candidateStatuses: async () => candidates,
};
return projectedStatusSchema.parse(
await binarySessionStatus({
target,
route,
router,
runtimeUnavailability,
runId: undefined,
runtimeLineageSnapshots: [],
requestActivitySnapshots: [],
}),
);
};
const expandCanonicalCapabilities = (sets: readonly ProviderCapabilitySet[]) =>
[...expandProviderCapabilities(sets)].sort((left, right) =>
compareUnicodeCodePoints(left.operation, right.operation),
);
const selectedCapabilities = [
descriptor(providerA, "xrefs", ["Shared limitation"]),
descriptor(providerA, "procedure_info", ["Shared limitation"]),
descriptor(providerA, "read_bytes", ["Shared limitation", "beta detail"]),
];
const otherCapabilities = [
descriptor(providerB, "read_bytes", ["Different limitation"], {
launchesProcess: true,
available: false,
reason: "Architecture unsupported",
availabilityCode: "architecture_unsupported",
}),
];
const expectedRouteCapabilities: ProviderCapabilitySet[] = [
{
provider: providerA,
shared_limitations: ["Shared limitation"],
groups: [
{
operations: ["procedure_info"],
effects: ["mutates_artifact"],
limitations: [],
available: false,
reason: "Runtime operation failure",
availability_code: null,
},
{
operations: ["read_bytes"],
effects: ["mutates_artifact"],
limitations: ["beta detail"],
available: true,
reason: null,
availability_code: null,
},
{
operations: ["xrefs"],
effects: ["mutates_artifact"],
limitations: [],
available: true,
reason: null,
availability_code: null,
},
],
},
];
const expectedExpandedRouteCapabilities = [
{
provider: providerA,
operation: "procedure_info",
available: false,
reason: "Runtime operation failure",
availability_code: null,
effects: MUTATING_EFFECTS,
limitations: ["Shared limitation"],
},
{
provider: providerA,
operation: "read_bytes",
available: true,
reason: null,
availability_code: null,
effects: MUTATING_EFFECTS,
limitations: ["Shared limitation", "beta detail"],
},
{
provider: providerA,
operation: "xrefs",
available: true,
reason: null,
availability_code: null,
effects: MUTATING_EFFECTS,
limitations: ["Shared limitation"],
},
];
const expectedCandidateCapabilities: ProviderCapabilitySet[] = [
{
provider: providerA,
shared_limitations: ["Shared limitation"],
groups: [
{
operations: ["procedure_info", "xrefs"],
effects: ["mutates_artifact"],
limitations: [],
available: true,
reason: null,
availability_code: null,
},
{
operations: ["read_bytes"],
effects: ["mutates_artifact"],
limitations: ["beta detail"],
available: true,
reason: null,
availability_code: null,
},
],
},
{
provider: providerB,
shared_limitations: ["Different limitation"],
groups: [
{
operations: ["read_bytes"],
effects: ["mutates_artifact", "launches_process"],
limitations: [],
available: false,
reason: "Architecture unsupported",
availability_code: "architecture_unsupported",
},
],
},
];
const expectedCandidateStatusFacts = [
expect.objectContaining({
provider: providerA,
target_support: {
status: "unknown",
code: null,
reason: "No target is open.",
diagnostics: {},
},
capabilities: [expectedCandidateCapabilities[0]],
}),
expect.objectContaining({
provider: providerB,
capabilities: [expectedCandidateCapabilities[1]],
}),
];
const expectedExpandedCandidateCapabilities = [
[
{
provider: providerA,
operation: "procedure_info",
available: true,
reason: null,
availability_code: null,
effects: MUTATING_EFFECTS,
limitations: ["Shared limitation"],
},
{
provider: providerA,
operation: "read_bytes",
available: true,
reason: null,
availability_code: null,
effects: MUTATING_EFFECTS,
limitations: ["Shared limitation", "beta detail"],
},
{
provider: providerA,
operation: "xrefs",
available: true,
reason: null,
availability_code: null,
effects: MUTATING_EFFECTS,
limitations: ["Shared limitation"],
},
],
[
{
provider: providerB,
operation: "read_bytes",
available: false,
reason: "Architecture unsupported",
availability_code: "architecture_unsupported",
effects: { ...MUTATING_EFFECTS, launches_process: true },
limitations: ["Different limitation"],
},
],
];
describe("binary session provider capability projection", () => {
it("keeps the private dispatch reader profile out of public capability status", async () => {
const capabilities = nativeMacOSCapabilities("darwin");
const projected = await project(capabilities, [
candidate(NATIVE_MACOS_PROVIDER_IDENTITY, capabilities),
]);
const serialized = JSON.stringify(projected);
expect(serialized).not.toContain(
APPLE_DISPATCH_METADATA_ANALYSIS_PROFILE.provider.version,
);
expect(serialized).not.toContain(
APPLE_DISPATCH_METADATA_ANALYSIS_PROFILE.digest,
);
expect(projectedStatusSchema.parse(projected)).toEqual(projected);
});
it("preserves provider scope and route overlays while factoring exact prefixes", async () => {
const selectedBefore = structuredClone(selectedCapabilities);
const otherBefore = structuredClone(otherCapabilities);
const status = await project(
selectedCapabilities,
[
candidate(providerA, selectedCapabilities),
candidate(providerB, otherCapabilities),
],
new Map([["procedure_info", { reason: "Runtime operation failure" }]]),
);
expect(selectedCapabilities).toEqual(selectedBefore);
expect(otherCapabilities).toEqual(otherBefore);
expect(status.capabilities).toEqual(expectedRouteCapabilities);
expect(expandCanonicalCapabilities(status.capabilities)).toEqual(
expectedExpandedRouteCapabilities,
);
expect(status.analysis_provider_candidates).toEqual(
expectedCandidateStatusFacts,
);
const selectedCandidate = status.analysis_provider_candidates[0];
const otherCandidate = status.analysis_provider_candidates[1];
expect(selectedCandidate).toBeDefined();
expect(otherCandidate).toBeDefined();
expect(
expandCanonicalCapabilities(selectedCandidate?.capabilities ?? []),
).toEqual(expectedExpandedCandidateCapabilities[0]);
expect(
expandCanonicalCapabilities(otherCandidate?.capabilities ?? []),
).toEqual(expectedExpandedCandidateCapabilities[1]);
});
it("keeps empty route and candidate capability collections empty", async () => {
const status = await project([], [candidate(providerA, [])]);
expect(status.capabilities).toEqual([]);
expect(status.analysis_provider_candidates[0]?.capabilities).toEqual([]);
});
it("preserves repeated limitations in their original order", async () => {
const capabilities = [
descriptor(providerA, "procedure_info", [
"Repeated",
"Repeated",
"left detail",
]),
descriptor(providerA, "xrefs", ["Repeated", "Repeated", "right detail"]),
];
const status = await project(capabilities, []);
expect(status.capabilities[0]).toMatchObject({
shared_limitations: ["Repeated", "Repeated"],
groups: [
{ operations: ["procedure_info"], limitations: ["left detail"] },
{ operations: ["xrefs"], limitations: ["right detail"] },
],
});
expect(
expandCanonicalCapabilities(status.capabilities).map(
({ limitations }) => limitations,
),
).toEqual([
["Repeated", "Repeated", "left detail"],
["Repeated", "Repeated", "right detail"],
]);
});
});
it.each(["elf", "pe"] as const)(
"reports format rejection for %s dylib discovery",
async (format) => {
const target: BinaryTarget = {
kind: "executable",
format,
path: "/fixture",
sha256: "a".repeat(64),
architecture: "x86_64",
availableArchitectures: ["x86_64"],
...(format === "pe"
? { executableRole: "application" as const, managed: false }
: {}),
} as BinaryTarget;
const status = await project(
[descriptor(providerA, "trace_dylib_resolution", [])],
[],
new Map(),
target,
);
expect(expandCanonicalCapabilities(status.capabilities)).toMatchObject([
{
operation: "trace_dylib_resolution",
available: false,
availability_code: "target_format_unsupported",
},
]);
},
);