Files
rea/src/application/ClientConfigurationCleanup.ts
T
morluto 56679dd2ae fix(files): preserve physical read provenance through cleanup
Keep raw physical read diagnostics alongside explicit operation provenance on the same cleanup owner. Preserve provenance after successful close retry for opted-in readers, restore legacy error projections, and prevent borrowed cleanup-shaped failures from authorizing foreign resource retries.

Refs #5686
2026-10-21 06:45:34 +08:00

117 lines
3.8 KiB
TypeScript

import {
ArtifactResourceRetryFailure,
type ArtifactResourceOwner,
type ArtifactResourceScope,
} from "../artifacts/ArtifactResourceScope.js";
import type { AnalysisCleanupLease } from "../artifacts/AnalysisCleanupLease.js";
import { ArtifactReaderFailure } from "../artifacts/ArtifactReader.js";
import type { AnalysisCleanupObservation } from "../domain/analysisErrorBase.js";
import type { RegularFileOperationOutcome } from "../filesystem/OwnedRegularFile.js";
import {
RegularFileCleanupFailure,
retryRegularFileCleanupFailures,
} from "./RegularFileRead.js";
/** Completion and exact staging owner retained when publication cleanup fails. */
export class ClientConfigurationPublicationFailure<
Value = unknown,
> extends ArtifactResourceRetryFailure {
constructor(
readonly path: string,
readonly outcome: RegularFileOperationOutcome<Value>,
readonly cleanupCause: unknown,
readonly owner: Extract<
ArtifactResourceOwner,
{ readonly kind: "staged-output" }
>,
readonly cleanupLease: AnalysisCleanupLease,
) {
super(
[{ owner, lease: cleanupLease }],
"Configuration publication cleanup remains incomplete",
{
cause: new AggregateError(
[...(outcome.kind === "failed" ? [outcome.cause] : []), cleanupCause],
"Configuration operation and staging cleanup failures",
),
cleanup: ArtifactReaderFailure.cleanupObservation(
cleanupCause,
owner.resource,
),
},
);
}
}
type ClientConfigurationCleanupFailure =
| RegularFileCleanupFailure
| ClientConfigurationPublicationFailure;
export const isClientConfigurationCleanupFailure = (
cause: unknown,
): cause is ClientConfigurationCleanupFailure =>
cause instanceof RegularFileCleanupFailure ||
cause instanceof ClientConfigurationPublicationFailure;
/** Adopt only capabilities carried by explicit operation outcomes, never opaque causes. */
export const retryClientConfigurationCleanup = async (
failure: ClientConfigurationCleanupFailure,
resources: ArtifactResourceScope,
): Promise<{
readonly primary: unknown;
readonly failures: readonly RegularFileCleanupFailure[];
readonly cleanup?: AnalysisCleanupObservation;
}> => {
const failures: RegularFileCleanupFailure[] = [];
const observations: AnalysisCleanupObservation[] = [];
let current = failure;
let primary: unknown;
for (;;) {
let nested: unknown;
if (current instanceof RegularFileCleanupFailure) {
const retried = await retryRegularFileCleanupFailures(current, resources);
failures.push(...retried.failures);
if (retried.cleanup !== undefined) observations.push(retried.cleanup);
primary = retried.primary;
const last = retried.failures.at(-1)!;
nested =
last.operationFailure === undefined && last.outcome.kind === "failed"
? last.outcome.cause
: undefined;
} else {
const released = await resources.release({
kind: "lease",
resource: current.owner.resource,
lease: current.cleanupLease,
});
if (released.kind === "failed")
observations.push(
ArtifactReaderFailure.cleanupObservation(
released.cause,
current.owner.resource,
),
);
primary =
current.outcome.kind === "failed"
? current.outcome.cause
: current.cleanupCause;
nested =
current.outcome.kind === "failed" ? current.outcome.cause : undefined;
}
if (!isClientConfigurationCleanupFailure(nested)) break;
current = nested;
}
return {
primary,
failures,
...(observations.length === 0
? {}
: {
cleanup: {
reason: observations.map(({ reason }) => reason).join("; "),
resources: observations.flatMap(({ resources }) => resources),
},
}),
};
};