mirror of
https://github.com/morluto/rea
synced 2026-10-28 06:46:47 -04:00
4aa51bfe19
* feat(process): add owned debugger shutdown lifecycle * feat(reverse): add local inspection commands * feat(gdb): add persistent debugger integration * feat(cutter): add Cutter bridge integration * test(reverse): enforce complete integration coverage * fix(process): preserve debugger shutdown ownership * fix(reverse): retain evidence across interrupted commands * fix(gdb): honor captured provider environment * test(process): cover debugger shutdown retries * fix(reverse): retain evidence for interrupted providers * test(process): cover debugger shutdown retries * fix(reverse): retain evidence for interrupted providers * fix(server): snapshot provider environment at creation * fix(reverse): close review gaps with complete coverage * fix(reverse): address inspection review findings * fix(gdb): bound sessions and retain cleanup ownership * fix(ci): require reverse-tools quality lane * fix(process): unref inherited debugger output pipes * fix(reverse): address remaining PR 1960 findings * fix(gdb): address remaining PR 1961 findings * fix(reverse): account for unrestricted provider execution * fix(process): retain debugger ownership until safe shutdown * fix(process): preserve replacement debugger sessions * fix(reverse): preserve admission and output provenance * fix(process): retain exited debugger until output settles * fix(mcp): bound provider admission and debugger cleanup * fix(reverse): preserve failure provenance and classify E2BIG * fix(gdb): preserve startup cleanup and detach safety * fix(process): retain debugger ownership after detach failure * fix(reverse): preserve mutation and failure provenance * fix(gdb): address debugger review findings * fix(reverse): rebind sessions after external mutation * fix(process): cap debugger output after exit * fix(gdb): protect one-shot detach verification * feat(debugger): add reverse tool coverage gate * test(debugger): cover integrated failure paths * fix(gdb): bound and preserve session observations * fix(gdb): address review regressions * style: format merged integration files * fix(reverse): preserve session and output evidence * refactor(gdb): share repeated test and partial result setup * fix(gdb): invalidate TTY proof for Python aliases * fix(reverse): retain failure output byte counts * test(process): synchronize late debugger output * fix(gdb): invalidate TTY proof for wrapped commands * fix(gdb): recognize wit command abbreviation * test(reverse): wait for cancelled descendant readiness * test(reverse): bound descendant cancellation cleanup * style(reverse): format integration tests and adapters * style: format reverse engineering integration files * test(reverse): remove duplicate environment harness * test(gdb): share session startup assertions * fix(gdb): invalidate output proof for command abbreviations * test(reverse): share composition edge case scenarios * fix(ci): recognize verification and mutation tool entries * test(rizin): cover successful fake inferior detach * test(cli): align full output failure envelope * test(cli): isolate reverse command lifecycle service * test(process): share debugger output fixture setup * fix(binary): preserve high-bit Windows signature bytes * style(binary): format Windows signature parser * test(mcp): preserve call coverage in unchanged comparison * fix(ci): include reverse tools Vitest configs in lint cache * fix(mcp): preserve target content on delivery errors * ci: align duplication ceiling with expanded suite * test(reverse): allow signal admission mutants * fix(reverse): bound retained cleanup failures to process owners * fix(test): replace drifting mutation ranges with owned selectors * fix(reverse): admit persistent commands and retain cleanup ownership * fix(cutter): recover timed-out commands from exact receipts * fix(cutter): reject unsupported bridge request kinds * fix(ci): repair client format and shared verification fixtures * fix(native): preserve debugger cleanup ownership and bridge authentication * test(native): retain diagnostics without perfect coverage requirements * chore(licenses): refresh locked dependency inventory and notices * fix(test): exclude transient command locks from mutation sandboxes * fix(gdb): admit only platforms with safe detach verification * fix(cutter): retain bounded completion receipts until acknowledgement * fix(cutter): acknowledge commands rejected before UI dispatch * test(reverse): fail cancellation checks before fixture teardown * test(gdb): clean up the retained broken-stdin fixture owner * docs(test): clarify focused provider verification scope * fix(rizin): retain close cleanup failures * fix(gdb): wait for inferior stop and bound MI buffering * fix(cutter): retain failed receipt acknowledgements * fix(rizin): return retained session identity on rebind failure * fix(gdb): preserve startup cancellation and lossy status * fix(rizin): retain launch provenance and assemble frames once * fix(cutter): recover receipts across callers and bound discovery * docs: describe debugger evidence and bridge recovery * fix(process): keep cleanup incomplete while writers remain Stopping a debugger no longer reports success when inherited output streams stay open, so BinarySession cannot reopen a binary a child is still changing. Concurrent Cutter cleanup retries share one receipt acknowledgement instead of treating a consumed receipt as failure. * fix(debuggers): recover cleanup with captured process identities * fix(analysis): retire sessions after unrestricted commands * fix(cli): preserve completed evidence after cleanup recovery * fix(cutter): bound frame collection and coalesce cleanup * fix(windows): resolve selected provider paths absolutely * fix(gdb): report decoding loss in failed startup evidence * fix(rizin): scope decoding loss to collected command frames * test(mcp): cover snapshot retirement in reverse tools CI --------- Co-authored-by: Daniel Gonçalves Araujo <47118053+dandgabr@users.noreply.github.com> Co-authored-by: REA Maintainers <noreply@github.com> Co-authored-by: OpenAI Codex <codex@users.noreply.github.com> Co-authored-by: Cursor Agent <cursoragent@cursor.com>
289 lines
9.1 KiB
TypeScript
289 lines
9.1 KiB
TypeScript
import type {
|
|
AnalysisExecution,
|
|
AnalysisOperation,
|
|
ExecutionOptions,
|
|
} from "./AnalysisProvider.js";
|
|
import { projectAnalysisError } from "../domain/analysisErrorProjection.js";
|
|
import { AnalysisCancelledError } from "../domain/analysisErrorCore.js";
|
|
import type { AnalysisError } from "../domain/analysisErrorBase.js";
|
|
import { parseRelatedAddresses } from "../domain/hopperValues.js";
|
|
import type { JsonValue } from "../domain/jsonValue.js";
|
|
import { err, ok, type Result } from "../domain/result.js";
|
|
import type { EnhancedResult } from "./EnhancedToolTypes.js";
|
|
import { resolveProcedureAddress } from "./ProcedureAddressResolution.js";
|
|
import type { RelationshipCoverage } from "../domain/relationshipCoverage.js";
|
|
|
|
type AnalysisCall = (
|
|
name: AnalysisOperation,
|
|
arguments_: Readonly<Record<string, JsonValue>>,
|
|
signal?: AbortSignal,
|
|
selectorOrigin?: ExecutionOptions["selectorOrigin"],
|
|
) => Promise<Result<JsonValue, AnalysisError>>;
|
|
|
|
type RelationshipCall = (
|
|
name: AnalysisOperation,
|
|
arguments_: Readonly<Record<string, JsonValue>>,
|
|
signal?: AbortSignal,
|
|
selectorOrigin?: ExecutionOptions["selectorOrigin"],
|
|
) => Promise<Result<AnalysisExecution, AnalysisError>>;
|
|
|
|
export interface CallPathTraceInput {
|
|
readonly start: string;
|
|
readonly goal?: string | undefined;
|
|
readonly direction: "forward" | "backward";
|
|
}
|
|
|
|
interface TraceState {
|
|
readonly visited: Map<
|
|
string,
|
|
{ readonly depth: number; readonly path: string[] }
|
|
>;
|
|
readonly queue: string[];
|
|
readonly edges: Map<
|
|
string,
|
|
{
|
|
readonly source_address: string;
|
|
readonly target_address: string;
|
|
readonly discovery_depth: number;
|
|
}
|
|
>;
|
|
readonly failures: Array<{
|
|
readonly address: string;
|
|
readonly error: ReturnType<typeof projectAnalysisError>;
|
|
}>;
|
|
readonly residual: Set<string>;
|
|
readonly limitations: Set<string>;
|
|
readonly relationshipCoverage: Map<string, RelationshipCoverage>;
|
|
queueIndex: number;
|
|
traversalPath: string[];
|
|
}
|
|
|
|
interface AddressExpansion {
|
|
readonly input: CallPathTraceInput;
|
|
readonly state: TraceState;
|
|
readonly address: string;
|
|
readonly current: { readonly depth: number; readonly path: string[] };
|
|
readonly signal?: AbortSignal;
|
|
}
|
|
|
|
interface DiscoveredEdge {
|
|
readonly address: string;
|
|
readonly relatedAddress: string;
|
|
readonly discoveryDepth: number;
|
|
}
|
|
|
|
/** Trace direct caller/callee relationships until the graph is exhausted or the goal is reached. */
|
|
export const traceCallPath = async (
|
|
call: AnalysisCall,
|
|
callRelationship: RelationshipCall,
|
|
input: CallPathTraceInput,
|
|
signal?: AbortSignal,
|
|
): EnhancedResult => {
|
|
const start = await resolveProcedureAddress(call, input.start, signal);
|
|
if (!start.ok) return start;
|
|
let goal: string | undefined;
|
|
if (input.goal !== undefined) {
|
|
const resolved = await resolveProcedureAddress(call, input.goal, signal);
|
|
if (!resolved.ok) return resolved;
|
|
goal = resolved.value;
|
|
}
|
|
const resolvedInput = {
|
|
start: start.value,
|
|
...(goal === undefined ? {} : { goal }),
|
|
direction: input.direction,
|
|
};
|
|
if (isAborted(signal))
|
|
return err(new AnalysisCancelledError("trace_call_path"));
|
|
const state = createTraceState(resolvedInput);
|
|
while (
|
|
state.queueIndex < state.queue.length &&
|
|
state.traversalPath.length === 0
|
|
) {
|
|
if (isAborted(signal))
|
|
return err(new AnalysisCancelledError("trace_call_path"));
|
|
const address = state.queue[state.queueIndex++];
|
|
if (address === undefined) break;
|
|
const current = state.visited.get(address);
|
|
if (current === undefined) continue;
|
|
const expanded = await expandAddress(callRelationship, {
|
|
input: resolvedInput,
|
|
state,
|
|
address,
|
|
current,
|
|
...(signal === undefined ? {} : { signal }),
|
|
});
|
|
if (!expanded.ok) return expanded;
|
|
if (expanded.value) break;
|
|
}
|
|
if (isAborted(signal))
|
|
return err(new AnalysisCancelledError("trace_call_path"));
|
|
return ok(projectTrace(resolvedInput, state));
|
|
};
|
|
|
|
const createTraceState = (input: CallPathTraceInput): TraceState => ({
|
|
visited: new Map([[input.start, { depth: 0, path: [input.start] }]]),
|
|
queue: [input.start],
|
|
edges: new Map(),
|
|
failures: [],
|
|
residual: new Set(),
|
|
limitations: new Set(),
|
|
relationshipCoverage: new Map(),
|
|
queueIndex: 0,
|
|
traversalPath: input.goal === input.start ? [input.start] : [],
|
|
});
|
|
|
|
const expandAddress = async (
|
|
call: RelationshipCall,
|
|
expansion: AddressExpansion,
|
|
): Promise<Result<boolean, AnalysisError>> => {
|
|
const { input, state, address, current, signal } = expansion;
|
|
const relation = input.direction === "forward" ? "callees" : "callers";
|
|
const tool =
|
|
input.direction === "forward" ? "procedure_callees" : "procedure_callers";
|
|
const result = await call(tool, { procedure: address }, signal, "provider");
|
|
if (!result.ok) {
|
|
if (
|
|
result.error._tag === "AnalysisCancelledError" ||
|
|
signal?.aborted === true
|
|
)
|
|
return result;
|
|
}
|
|
if (isAborted(signal))
|
|
return err(new AnalysisCancelledError("trace_call_path"));
|
|
if (!result.ok) {
|
|
state.failures.push({
|
|
address,
|
|
error: projectAnalysisError(result.error),
|
|
});
|
|
state.residual.add(`Call relationships were unavailable for ${address}.`);
|
|
return ok(false);
|
|
}
|
|
const related = parseRelatedAddresses(result.value.result, relation, tool);
|
|
if (!related.ok) {
|
|
state.failures.push({
|
|
address,
|
|
error: projectAnalysisError(related.error),
|
|
});
|
|
state.residual.add(`Call relationships were unreadable for ${address}.`);
|
|
return ok(false);
|
|
}
|
|
for (const limitation of result.value.limitations)
|
|
state.limitations.add(limitation);
|
|
const coverage = result.value.relationshipCoverage ?? {
|
|
status: "unknown",
|
|
reason: "Provider did not report relationship coverage.",
|
|
};
|
|
state.relationshipCoverage.set(address, coverage);
|
|
for (const diagnostic of "diagnostics" in coverage &&
|
|
Array.isArray(coverage.diagnostics)
|
|
? coverage.diagnostics
|
|
: [])
|
|
state.limitations.add(diagnostic);
|
|
if (coverage.status === "partial")
|
|
for (const limitation of coverage.limitations)
|
|
state.residual.add(
|
|
`Call relationships for ${address} are limited: ${limitation}`,
|
|
);
|
|
else if (coverage.status === "unknown")
|
|
state.residual.add(
|
|
`Call relationship coverage is unknown for ${address}: ${coverage.reason}`,
|
|
);
|
|
for (const relatedAddress of sortedUniqueAddresses(related.value)) {
|
|
recordEdge(input, state, {
|
|
address,
|
|
relatedAddress,
|
|
discoveryDepth: current.depth + 1,
|
|
});
|
|
const path = state.visited.get(relatedAddress)?.path ?? [
|
|
...current.path,
|
|
relatedAddress,
|
|
];
|
|
if (state.visited.has(relatedAddress)) {
|
|
if (relatedAddress === input.goal) {
|
|
state.traversalPath = path;
|
|
return ok(true);
|
|
}
|
|
continue;
|
|
}
|
|
state.visited.set(relatedAddress, {
|
|
depth: current.depth + 1,
|
|
path,
|
|
});
|
|
if (relatedAddress === input.goal) {
|
|
state.traversalPath = path;
|
|
return ok(true);
|
|
}
|
|
state.queue.push(relatedAddress);
|
|
}
|
|
return ok(false);
|
|
};
|
|
|
|
const recordEdge = (
|
|
input: CallPathTraceInput,
|
|
state: TraceState,
|
|
edge: DiscoveredEdge,
|
|
): void => {
|
|
const sourceAddress =
|
|
input.direction === "forward" ? edge.address : edge.relatedAddress;
|
|
const targetAddress =
|
|
input.direction === "forward" ? edge.relatedAddress : edge.address;
|
|
const edgeKey = `${sourceAddress}\u0000${targetAddress}`;
|
|
if (state.edges.has(edgeKey)) return;
|
|
state.edges.set(edgeKey, {
|
|
source_address: sourceAddress,
|
|
target_address: targetAddress,
|
|
discovery_depth: edge.discoveryDepth,
|
|
});
|
|
};
|
|
|
|
const projectTrace = (input: CallPathTraceInput, state: TraceState) => ({
|
|
start: input.start,
|
|
goal: input.goal ?? null,
|
|
direction: input.direction,
|
|
goal_status:
|
|
input.goal === undefined
|
|
? "not_requested"
|
|
: state.traversalPath.length > 0
|
|
? "reached"
|
|
: state.residual.size > 0
|
|
? "unknown"
|
|
: "not_reached",
|
|
nodes: [...state.visited.entries()]
|
|
.map(([address, { depth }]) => ({ address, depth }))
|
|
.sort(
|
|
(left, right) =>
|
|
left.depth - right.depth || compareAddress(left.address, right.address),
|
|
),
|
|
edges: [...state.edges.values()].sort(
|
|
(left, right) =>
|
|
left.discovery_depth - right.discovery_depth ||
|
|
compareAddress(left.source_address, right.source_address) ||
|
|
compareAddress(left.target_address, right.target_address),
|
|
),
|
|
traversal_path: state.traversalPath,
|
|
failures: state.failures,
|
|
traversal: {
|
|
nodes_visited: state.visited.size,
|
|
},
|
|
relationship_coverage: Object.fromEntries(
|
|
[...state.relationshipCoverage.entries()].sort(([left], [right]) =>
|
|
compareAddress(left, right),
|
|
),
|
|
),
|
|
truncated: state.residual.size > 0,
|
|
residual_unknowns: [...state.residual],
|
|
limitations: [
|
|
"Direct provider call relationships may omit unresolved indirect calls.",
|
|
...state.limitations,
|
|
],
|
|
});
|
|
|
|
const compareAddress = (left: string, right: string): number =>
|
|
left < right ? -1 : left > right ? 1 : 0;
|
|
|
|
const sortedUniqueAddresses = (addresses: readonly string[]): string[] =>
|
|
[...new Set(addresses)].sort(compareAddress);
|
|
|
|
const isAborted = (signal: AbortSignal | undefined): boolean =>
|
|
signal?.aborted === true;
|