mirror of
https://github.com/morluto/rea
synced 2026-10-25 22:08:11 -04:00
91b8f587cd
Decode caller-selected protocols from existing recordings through shared CLI/MCP Evidence. Page literal output lines after complete decoding; preserve explicit full output, source identity and failed cleanup ownership. Verified real sigrok-cli 0.7.2 workflows, published UART/SPI/I2C recordings, independent UART values, selector limits, SDK schemas and cleanup regressions. Co-authored-by: Olorinm <59321404+Olorinm@users.noreply.github.com> Assisted-by: Kogasa (gensokyo-skills:kogasa-surprise-testing)
100 lines
3.6 KiB
TypeScript
100 lines
3.6 KiB
TypeScript
import { z } from "incur";
|
|
import type { SignalRecordingService } from "../application/signals/SignalRecordingService.js";
|
|
import { AnalysisError } from "../domain/analysisErrorBase.js";
|
|
import { analysisErrorWithCleanupFailure } from "../domain/analysisErrorCleanup.js";
|
|
import { ProviderCleanupError } from "../domain/providerCleanupError.js";
|
|
import { resolve } from "node:path";
|
|
import { createSignalRecordingService } from "../composition/signals.js";
|
|
import {
|
|
signalRecordingOptionsSchema,
|
|
signalRecordingSelectorBudgetIssue,
|
|
withinSignalRecordingSelectorBudget,
|
|
} from "../domain/signals/signalRecording.js";
|
|
import { CLI_COMMANDS } from "../cliCommandNames.js";
|
|
import { logCliCommand } from "../cliLogging.js";
|
|
import { projectAnalysisError } from "../domain/analysisErrorProjection.js";
|
|
import type { Logger } from "pino";
|
|
import type { CliInstance } from "./types.js";
|
|
import { withCommandCancellation } from "./commandCancellation.js";
|
|
export const registerSignalCommands = (
|
|
cli: CliInstance,
|
|
logger: Logger,
|
|
environment: Readonly<NodeJS.ProcessEnv>,
|
|
service: Pick<
|
|
SignalRecordingService,
|
|
"decode" | "close"
|
|
> = createSignalRecordingService(environment),
|
|
): void => {
|
|
cli.command(CLI_COMMANDS.decodeSignalRecording, {
|
|
description:
|
|
"Decode an existing signal recording with caller-supplied sigrok",
|
|
args: z.object({ path: z.string().describe("Local signal recording") }),
|
|
options: z
|
|
.object({
|
|
...signalRecordingOptionsSchema.shape,
|
|
line_limit: z
|
|
.number()
|
|
.int()
|
|
.positive()
|
|
.optional()
|
|
.describe("Returned output lines per page; default 50"),
|
|
all_lines: z
|
|
.boolean()
|
|
.default(false)
|
|
.describe(
|
|
"Return all remaining output lines instead of a bounded page",
|
|
),
|
|
})
|
|
.superRefine((options, context) => {
|
|
if (options.all_lines && options.line_limit !== undefined)
|
|
context.addIssue({
|
|
code: "custom",
|
|
path: ["all_lines"],
|
|
message: "all_lines and line_limit are mutually exclusive",
|
|
});
|
|
})
|
|
.refine(
|
|
withinSignalRecordingSelectorBudget,
|
|
signalRecordingSelectorBudgetIssue,
|
|
),
|
|
run: ({ args, options: { all_lines, ...options } }) =>
|
|
withCommandCancellation((signal) =>
|
|
logCliCommand(logger, CLI_COMMANDS.decodeSignalRecording, async () => {
|
|
const result = await service.decode(
|
|
{
|
|
...options,
|
|
...(all_lines ? { line_limit: null } : {}),
|
|
path: resolve(args.path),
|
|
},
|
|
{ signal },
|
|
);
|
|
// A one-shot command must retry retained cleanup before discarding its owner.
|
|
try {
|
|
await service.close();
|
|
} catch (cause) {
|
|
const cleanup =
|
|
cause instanceof AnalysisError
|
|
? cause
|
|
: new ProviderCleanupError(
|
|
"sigrok-recording",
|
|
[],
|
|
{ reason: String(cause) },
|
|
{ cause, operation: "decode_signal_recording" },
|
|
);
|
|
if (result.ok) cleanup.retainPartialObservation(result.value);
|
|
return projectAnalysisError(
|
|
result.ok
|
|
? cleanup
|
|
: analysisErrorWithCleanupFailure(
|
|
result.error,
|
|
cleanup,
|
|
"decode_signal_recording",
|
|
),
|
|
);
|
|
}
|
|
return result.ok ? result.value : projectAnalysisError(result.error);
|
|
}),
|
|
),
|
|
});
|
|
};
|