mirror of
https://github.com/morluto/rea
synced 2026-10-26 06:16:17 -04:00
4aa51bfe19
* feat(process): add owned debugger shutdown lifecycle * feat(reverse): add local inspection commands * feat(gdb): add persistent debugger integration * feat(cutter): add Cutter bridge integration * test(reverse): enforce complete integration coverage * fix(process): preserve debugger shutdown ownership * fix(reverse): retain evidence across interrupted commands * fix(gdb): honor captured provider environment * test(process): cover debugger shutdown retries * fix(reverse): retain evidence for interrupted providers * test(process): cover debugger shutdown retries * fix(reverse): retain evidence for interrupted providers * fix(server): snapshot provider environment at creation * fix(reverse): close review gaps with complete coverage * fix(reverse): address inspection review findings * fix(gdb): bound sessions and retain cleanup ownership * fix(ci): require reverse-tools quality lane * fix(process): unref inherited debugger output pipes * fix(reverse): address remaining PR 1960 findings * fix(gdb): address remaining PR 1961 findings * fix(reverse): account for unrestricted provider execution * fix(process): retain debugger ownership until safe shutdown * fix(process): preserve replacement debugger sessions * fix(reverse): preserve admission and output provenance * fix(process): retain exited debugger until output settles * fix(mcp): bound provider admission and debugger cleanup * fix(reverse): preserve failure provenance and classify E2BIG * fix(gdb): preserve startup cleanup and detach safety * fix(process): retain debugger ownership after detach failure * fix(reverse): preserve mutation and failure provenance * fix(gdb): address debugger review findings * fix(reverse): rebind sessions after external mutation * fix(process): cap debugger output after exit * fix(gdb): protect one-shot detach verification * feat(debugger): add reverse tool coverage gate * test(debugger): cover integrated failure paths * fix(gdb): bound and preserve session observations * fix(gdb): address review regressions * style: format merged integration files * fix(reverse): preserve session and output evidence * refactor(gdb): share repeated test and partial result setup * fix(gdb): invalidate TTY proof for Python aliases * fix(reverse): retain failure output byte counts * test(process): synchronize late debugger output * fix(gdb): invalidate TTY proof for wrapped commands * fix(gdb): recognize wit command abbreviation * test(reverse): wait for cancelled descendant readiness * test(reverse): bound descendant cancellation cleanup * style(reverse): format integration tests and adapters * style: format reverse engineering integration files * test(reverse): remove duplicate environment harness * test(gdb): share session startup assertions * fix(gdb): invalidate output proof for command abbreviations * test(reverse): share composition edge case scenarios * fix(ci): recognize verification and mutation tool entries * test(rizin): cover successful fake inferior detach * test(cli): align full output failure envelope * test(cli): isolate reverse command lifecycle service * test(process): share debugger output fixture setup * fix(binary): preserve high-bit Windows signature bytes * style(binary): format Windows signature parser * test(mcp): preserve call coverage in unchanged comparison * fix(ci): include reverse tools Vitest configs in lint cache * fix(mcp): preserve target content on delivery errors * ci: align duplication ceiling with expanded suite * test(reverse): allow signal admission mutants * fix(reverse): bound retained cleanup failures to process owners * fix(test): replace drifting mutation ranges with owned selectors * fix(reverse): admit persistent commands and retain cleanup ownership * fix(cutter): recover timed-out commands from exact receipts * fix(cutter): reject unsupported bridge request kinds * fix(ci): repair client format and shared verification fixtures * fix(native): preserve debugger cleanup ownership and bridge authentication * test(native): retain diagnostics without perfect coverage requirements * chore(licenses): refresh locked dependency inventory and notices * fix(test): exclude transient command locks from mutation sandboxes * fix(gdb): admit only platforms with safe detach verification * fix(cutter): retain bounded completion receipts until acknowledgement * fix(cutter): acknowledge commands rejected before UI dispatch * test(reverse): fail cancellation checks before fixture teardown * test(gdb): clean up the retained broken-stdin fixture owner * docs(test): clarify focused provider verification scope * fix(rizin): retain close cleanup failures * fix(gdb): wait for inferior stop and bound MI buffering * fix(cutter): retain failed receipt acknowledgements * fix(rizin): return retained session identity on rebind failure * fix(gdb): preserve startup cancellation and lossy status * fix(rizin): retain launch provenance and assemble frames once * fix(cutter): recover receipts across callers and bound discovery * docs: describe debugger evidence and bridge recovery * fix(process): keep cleanup incomplete while writers remain Stopping a debugger no longer reports success when inherited output streams stay open, so BinarySession cannot reopen a binary a child is still changing. Concurrent Cutter cleanup retries share one receipt acknowledgement instead of treating a consumed receipt as failure. * fix(debuggers): recover cleanup with captured process identities * fix(analysis): retire sessions after unrestricted commands * fix(cli): preserve completed evidence after cleanup recovery * fix(cutter): bound frame collection and coalesce cleanup * fix(windows): resolve selected provider paths absolutely * fix(gdb): report decoding loss in failed startup evidence * fix(rizin): scope decoding loss to collected command frames * test(mcp): cover snapshot retirement in reverse tools CI --------- Co-authored-by: Daniel Gonçalves Araujo <47118053+dandgabr@users.noreply.github.com> Co-authored-by: REA Maintainers <noreply@github.com> Co-authored-by: OpenAI Codex <codex@users.noreply.github.com> Co-authored-by: Cursor Agent <cursoragent@cursor.com>
150 lines
4.5 KiB
TypeScript
150 lines
4.5 KiB
TypeScript
import { mkdir, writeFile } from "node:fs/promises";
|
|
import { dirname, join } from "node:path";
|
|
|
|
import { expect, it } from "vitest";
|
|
|
|
import { createTestTempDirectory } from "../../fixtures/temporaryDirectory.js";
|
|
import { systemDoctorHost } from "../../../src/application/Doctor.js";
|
|
|
|
it("threads the selected host and environment into system diagnostics", async () => {
|
|
const environment = {
|
|
HOME: "/selected/home",
|
|
HOPPER_LAUNCHER_PATH: "/selected/bin/hopper",
|
|
PATH: "/selected/bin",
|
|
};
|
|
const calls: Array<{
|
|
command: string;
|
|
arguments: readonly string[];
|
|
environment: NodeJS.ProcessEnv | undefined;
|
|
}> = [];
|
|
const host = systemDoctorHost({
|
|
platform: "linux",
|
|
architecture: "x64",
|
|
environment,
|
|
execFileOutput: async (command, arguments_, options) => {
|
|
calls.push({ command, arguments: arguments_, environment: options?.env });
|
|
if (command === "sw_vers")
|
|
return {
|
|
stdout: "15.0\n",
|
|
stderr: "",
|
|
stdoutBytes: 5,
|
|
stderrBytes: 0,
|
|
};
|
|
if (command === "ldd")
|
|
return {
|
|
stdout: "linux-vdso.so.1",
|
|
stderr: "",
|
|
stdoutBytes: Buffer.byteLength("linux-vdso.so.1"),
|
|
stderrBytes: 0,
|
|
};
|
|
if (command === "which")
|
|
return {
|
|
stdout: "/selected/bin/rea\n",
|
|
stderr: "",
|
|
stdoutBytes: 18,
|
|
stderrBytes: 0,
|
|
};
|
|
throw new Error(`Unexpected diagnostic command: ${command}`);
|
|
},
|
|
});
|
|
|
|
expect(host.homeDirectory).toBe("/selected/home");
|
|
expect(host.platform).toBe("linux");
|
|
expect(host.architecture).toBe("x64");
|
|
await host.installationPaths?.();
|
|
await host.macosVersion();
|
|
await host.executable(process.execPath);
|
|
|
|
expect(calls.map(({ command }) => command)).toEqual([
|
|
"which",
|
|
"sw_vers",
|
|
"ldd",
|
|
]);
|
|
expect(
|
|
calls.every(({ environment: observed }) => observed === environment),
|
|
).toBe(true);
|
|
});
|
|
|
|
it("does not report a directory as an available executable", async () => {
|
|
const host = systemDoctorHost({
|
|
platform: "darwin",
|
|
architecture: "arm64",
|
|
environment: {},
|
|
execFileOutput: () => Promise.reject(new Error("unexpected command")),
|
|
});
|
|
|
|
await expect(host.executable(dirname(process.execPath))).resolves.toBe(false);
|
|
await expect(host.executable(process.execPath)).resolves.toBe(true);
|
|
});
|
|
|
|
it.each([
|
|
[{ default: { appdir: "/Applications" } }, "/Applications"],
|
|
[
|
|
{
|
|
default: { appdir: "/Applications" },
|
|
env: { appdir: "/Env Apps" },
|
|
explicit: { appdir: "~/Tools" },
|
|
},
|
|
"HOME/Tools",
|
|
],
|
|
[
|
|
{ default: { appdir: "/Applications" }, env: { appdir: "/Env Apps" } },
|
|
"/Env Apps",
|
|
],
|
|
])(
|
|
"locates the Hopper cask from its Caskroom receipt without a cask command (%j)",
|
|
async (config, expectedAppdir) => {
|
|
const root = await createTestTempDirectory("rea-doctor-caskroom-");
|
|
const caskroom = join(root, "Caskroom");
|
|
const metadata = join(caskroom, "hopper-disassembler", ".metadata");
|
|
await mkdir(metadata, { recursive: true });
|
|
await writeFile(join(metadata, "config.json"), JSON.stringify(config));
|
|
const calls: (readonly string[])[] = [];
|
|
const host = systemDoctorHost({
|
|
platform: "darwin",
|
|
environment: { HOME: join(root, "home") },
|
|
execFileOutput: async (_command, arguments_) => {
|
|
calls.push(arguments_);
|
|
return {
|
|
stdout: `${caskroom}\n`,
|
|
stderr: "",
|
|
stdoutBytes: Buffer.byteLength(`${caskroom}\n`),
|
|
stderrBytes: 0,
|
|
};
|
|
},
|
|
});
|
|
|
|
expect(await host.brewHopperPath()).toBe(
|
|
join(
|
|
expectedAppdir.replace("HOME", join(root, "home")),
|
|
"Hopper Disassembler.app/Contents/MacOS/hopper",
|
|
),
|
|
);
|
|
// A cask argument makes Homebrew fetch and cache its API data.
|
|
expect(calls).toEqual([["--caskroom"]]);
|
|
},
|
|
);
|
|
|
|
it("reports no Homebrew Hopper when the cask has no receipt", async () => {
|
|
const caskroom = await createTestTempDirectory("rea-doctor-caskroom-");
|
|
const calls: (readonly string[])[] = [];
|
|
const host = systemDoctorHost({
|
|
platform: "darwin",
|
|
environment: { HOME: caskroom },
|
|
execFileOutput: async (_command, arguments_) => {
|
|
calls.push(arguments_);
|
|
return {
|
|
stdout: `${caskroom}\n`,
|
|
stderr: "",
|
|
stdoutBytes: Buffer.byteLength(`${caskroom}\n`),
|
|
stderrBytes: 0,
|
|
};
|
|
},
|
|
});
|
|
|
|
expect(await host.brewHopperPath()).toBeUndefined();
|
|
expect(new Set(calls.map((arguments_) => arguments_.join(" ")))).toEqual(
|
|
new Set(["--caskroom"]),
|
|
);
|
|
});
|