mirror of
https://github.com/morluto/rea
synced 2026-10-27 22:45:19 -04:00
Kaoru0822
fc791bb606
* fix: select caller paths through symlinks and .. as the filesystem does CLI adapters, binary target resolution, the reverse-engineering service and the objdump and Rizin command builders made caller-selected paths absolute with path.resolve, which collapses `link/..` lexically. On POSIX the filesystem follows `link` first, so these commands inspected, hashed or launched a different file and returned internally consistent Evidence for it. absoluteCallerPath now owns that step: on POSIX it prefixes a relative path with the working directory and keeps an absolute path as spelled; on Windows, where `..` resolves lexically, it keeps win32.resolve. Fixes #3864 Fixes #3911 Fixes #3912 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix: keep firmware, WASM list and output-root paths on the selected file Review follow-up. The CLI already passed firmware and WASM paths through absoluteCallerPath, but snapshotFirmware and SafeOutputTree.create re-resolved them lexically, and the WASM glue and candidate lists still used resolve, so those inputs could still select a sibling file or create output beside the intended directory. absoluteCallerPath now also drops `.` segments and repeated or trailing separators on POSIX, which never change the named file, so selected paths such as `./module.wasm` keep matching their glue references exactly. Every `..` is still left for the filesystem. SafeOutputTree keeps host path syntax; its platform argument selects only the Windows name policy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix: keep directory requirements and relative cwd in caller paths Review follow-up. absoluteCallerPath stripped a trailing `/` or `/.`, so `file/` selected the regular file instead of failing with ENOTDIR; it now keeps one trailing separator. A relative cwd option was appended to the root; it is now made absolute without collapsing `..`. WASM glue matching resolved local literals lexically, so a module selected through `link/..` matched only by basename; the adapter now compares both sides through absoluteCallerPath and still reports each candidate as given. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
27 lines
894 B
TypeScript
27 lines
894 B
TypeScript
import type { ObjdumpInput } from "../domain/reverseEngineering.js";
|
|
import { absoluteCallerPath } from "../filesystem/callerPath.js";
|
|
|
|
export const OBJDUMP_PROVIDER_IDENTITY = {
|
|
id: "gnu.objdump",
|
|
name: "GNU objdump",
|
|
version: null,
|
|
} as const;
|
|
|
|
/** Build GNU objdump argv without invoking a shell or following DWARF links by default. */
|
|
export const objdumpCommand = (input: ObjdumpInput): readonly string[] => {
|
|
if (input.operation === "architectures") return ["-i"];
|
|
const argumentsByOperation = {
|
|
file_headers: ["-f"],
|
|
section_headers: ["-h"],
|
|
symbols: ["-t"],
|
|
relocations: ["-r"],
|
|
dwarf: ["-W", input.follow_debug_links ? "-WK" : "-WN"],
|
|
disassemble: ["-d"],
|
|
disassemble_all: ["-D"],
|
|
} satisfies Record<typeof input.operation, readonly string[]>;
|
|
return [
|
|
...argumentsByOperation[input.operation],
|
|
absoluteCallerPath(input.path),
|
|
];
|
|
};
|