Files
rea/tests/composition/runtime-observation/javascriptRuntimeReconciliation.test.ts
T
morluto ffe0574e17 fix(artifacts)!: retain cleanup owners through client shutdown
Keep failed reader, root descriptor, and output-tree cleanup with the caller. Drain admitted work before close, retry the same retained owners, and block new resource work while cleanup is incomplete. Preserve primary failures and complete inventory observations.

Thread ownership through JavaScript reconstruction, the CLI's one-shot scope, MCP server shutdown, verifier scripts, and test fixtures. Remove redundant ownership flags and the unused validated test wrapper.

Validate with 850 passing focused tests across 90 suites (two skipped), targeted classification and cleanup retries, static and unused-code checks, and real macOS CLI/MCP directory, ZIP, and DMG workflows. Native Windows and deep-analysis providers were not verified.

BREAKING CHANGE: Direct artifact inventory/extraction and JavaScript analysis APIs require an explicit caller-owned ArtifactResourceScope. CLI and MCP input contracts are unchanged.
2026-10-11 04:43:02 +08:00

580 lines
18 KiB
TypeScript

import { mkdir, writeFile } from "node:fs/promises";
import { join } from "node:path";
import { expect, it } from "vitest";
import { createTestTempDirectory } from "../../fixtures/temporaryDirectory.js";
import { createElectronEvidence } from "../../../src/application/javascript/ElectronEvidence.js";
import { createElectronActiveEvidence } from "../../../src/application/javascript/ElectronActiveEvidence.js";
import { analyzeJavaScriptApplication } from "../../support/javascriptApplicationScope.js";
import { reconcileJavaScriptRuntimeEvidence } from "../../../src/application/javascript/JavaScriptRuntimeReconciliationService.js";
import { createEvidence } from "../../../src/domain/evidence.js";
import {
parseRuntimeReconciliationInput,
reconcileJavaScriptRuntime,
} from "../../../src/domain/javascript/javascriptRuntimeReconciliation.js";
import { reconcileJavaScriptRuntimeInputSchema } from "../../../src/domain/javascript/javascriptRuntimeReconciliationSchemas.js";
import { javascriptRuntimeReconciliationResultSchema } from "../../../src/domain/javascript/javascriptRuntimeReconciliationSchemas.js";
import { electronActiveObservationInputSchema } from "../../../src/domain/javascript/electronActiveObservation.js";
import { inspectElectronPageInputSchema } from "../../../src/domain/javascript/electronObservation.js";
import { createWebTextArtifact } from "../../../src/domain/webContentArtifact.js";
import { createElectronActiveObservationFixtureResult } from "../../../src/domain/javascript/electronActiveObservation.fixture.js";
const reconcileInput = (input: unknown) =>
reconcileJavaScriptRuntime(
parseRuntimeReconciliationInput(
reconcileJavaScriptRuntimeInputSchema.parse(input),
),
);
const SOURCE = `const worker = new Worker("./worker.js");\nexport const observed = worker;\n`;
it("preserves source-capture input paths for runtime Evidence", async () => {
const root = await applicationFixture();
const application = await analyzeFixture(root);
const runtime = electronRuntimeEvidence(root, SOURCE);
const invalidRuntime = createEvidence(undefined, runtime.provider, {
predicateType: runtime.predicate_type,
operation: runtime.operation,
parameters: { ...runtime.parameters, include_script_sources: false },
result: runtime.normalized_result,
confidence: runtime.confidence,
authority: runtime.authority,
});
const result = reconcileJavaScriptRuntimeEvidence({
static_layers: [{ role: "application", analysis: application }],
runtime_observations: [invalidRuntime],
});
expect(result).toMatchObject({
ok: false,
error: {
_tag: "AnalysisInputError",
issues: [
{
path: [
"runtime_observations",
0,
"parameters",
"include_script_sources",
],
reason: "invalid_value",
message:
"Runtime Evidence contains source without source-capture selection",
},
],
},
});
});
it("reconciles runtime scripts inside dot-prefixed child directories", async () => {
const root = await applicationFixture();
await mkdir(join(root, "..cache"));
await writeFile(join(root, "..cache", "app.js"), SOURCE);
const result = reconcileInput({
static_layers: [
{ role: "application", analysis: await analyzeFixture(root) },
],
runtime_observations: [
electronRuntimeEvidence(root, SOURCE, {
scriptFile: "..cache/app.js",
includeWorker: false,
}),
],
});
expect(result.reconciliations).toEqual(
expect.arrayContaining([
expect.objectContaining({
entity_kind: "script",
status: "matched",
basis: "content-and-location",
}),
]),
);
});
it("matches renderer, frame, script bytes, and worker without claiming execution", async () => {
const fixture = await applicationFixture();
const staticEvidence = await analyzeFixture(fixture);
const runtimeEvidence = electronRuntimeEvidence(fixture, SOURCE);
const result = reconcileInput({
static_layers: [{ role: "application", analysis: staticEvidence }],
runtime_observations: [runtimeEvidence],
});
expect(() =>
javascriptRuntimeReconciliationResultSchema.parse(result),
).not.toThrow();
expect(result.source_map_authority).toMatchObject({
used_for_primary_matching: false,
static_layer_count: 1,
runtime_script_declarations: 0,
});
expect(result.summary).toMatchObject({
runtime_targets: 1,
runtime_frames: 1,
runtime_scripts: 1,
runtime_workers: 1,
matched: 2,
ambiguous: 2,
unmatched: 0,
});
expect(result.reconciliations).toEqual(
expect.arrayContaining([
expect.objectContaining({
entity_kind: "script",
status: "matched",
basis: "content-and-location",
}),
expect.objectContaining({
entity_kind: "worker",
status: "matched",
basis: "artifact-path",
}),
expect.objectContaining({
entity_kind: "target",
status: "ambiguous",
reason: "ambiguous-static-candidates",
}),
]),
);
const matched = result.reconciliations.find(
({ status }) => status === "matched",
);
if (matched === undefined)
throw new TypeError("Expected one matched runtime reconciliation");
expect(
javascriptRuntimeReconciliationResultSchema.safeParse({
...result,
reconciliations: [{ ...matched, static_node_id: null }],
}).success,
).toBe(false);
expect(result.static_load_states).toEqual(
expect.arrayContaining([
expect.objectContaining({
kind: "javascript-asset",
status: "loaded",
}),
]),
);
expect(result.limitations.join(" ")).toMatch(
/not reported as executed|not code reachability/u,
);
expect(
result.graph.edges
.filter(({ relation }) => relation === "observed_as")
.every(
({ evidence }) =>
evidence.authority === "cross-layer-reconciliation" &&
evidence.state === "inferred",
),
).toBe(true);
const worker = result.reconciliations.find(
({ entity_kind: kind }) => kind === "worker",
);
const frame = result.reconciliations.find(
({ entity_kind: kind }) => kind === "frame",
);
expect(result.graph.edges).toContainEqual(
expect.objectContaining({
source_node_id: frame?.runtime_node_id,
target_node_id: worker?.runtime_node_id,
relation: "contains",
}),
);
});
it("keeps static load states unknown when one scoped capture omits scripts", async () => {
const fixture = await applicationFixture();
const staticEvidence = await analyzeFixture(fixture);
const result = reconcileInput({
static_layers: [{ role: "application", analysis: staticEvidence }],
runtime_observations: [
electronRuntimeEvidence(fixture, SOURCE, {
includeWorker: false,
targetId: "target-complete",
}),
electronRuntimeEvidence(fixture, SOURCE, {
includeWorker: false,
scriptsUnavailable: true,
targetId: "target-incomplete",
}),
],
});
expect(
result.runtime_captures.map(
({ scripts_complete_within_scope }) => scripts_complete_within_scope,
),
).toEqual(expect.arrayContaining([false, true]));
expect(result.summary.static_not_observed).toBe(0);
expect(result.static_load_states).toEqual(
expect.arrayContaining([
expect.objectContaining({
status: "unknown",
reason: "static-or-runtime-coverage-incomplete",
}),
]),
);
});
it("reports a captured digest disagreement instead of accepting a path match", async () => {
const fixture = await applicationFixture();
const staticEvidence = await analyzeFixture(fixture);
const runtimeEvidence = electronRuntimeEvidence(
fixture,
"export const observed = 'different';\n",
);
const result = reconcileInput({
static_layers: [{ role: "application", analysis: staticEvidence }],
runtime_observations: [runtimeEvidence],
});
const script = result.reconciliations.find(
({ entity_kind: kind }) => kind === "script",
);
expect(script).toMatchObject({
status: "unmatched",
reason: "captured-content-disagrees-with-static-location",
});
expect(script?.candidate_static_nodes).toHaveLength(1);
});
it("reconciles active Electron as a partial target-only runtime capture", async () => {
const fixture = await applicationFixture();
const staticEvidence = await analyzeFixture(fixture);
const applicationPath = join(fixture, "main.js");
const input = {
...electronActiveObservationInputSchema.parse({
executable_path: process.execPath,
application_path: applicationPath,
application_root: fixture,
actions: [],
}),
application_root: fixture,
};
const runtimeEvidence = createElectronActiveEvidence(
input,
createElectronActiveObservationFixtureResult(applicationPath),
{
id: "rea-playwright-electron-active",
name: "REA Playwright active Electron observation provider",
version: "1",
},
);
const result = reconcileInput({
static_layers: [{ role: "application", analysis: staticEvidence }],
runtime_observations: [runtimeEvidence],
});
expect(result.runtime_captures).toMatchObject([
{
kind: "electron-active",
scripts: 0,
frames: 0,
workers: 0,
scripts_complete_within_scope: false,
},
]);
expect(result.coverage.status).toBe("partial");
expect(result.limitations.join(" ")).toMatch(
/incomplete|not reported as executed/u,
);
});
it("commits complete Electron actions independently from selected arguments", async () => {
const fixture = await applicationFixture();
const applicationPath = join(fixture, "main.js");
const makeInput = (secret: string, selector: string) => ({
...electronActiveObservationInputSchema.parse({
executable_path: process.execPath,
application_path: applicationPath,
application_root: fixture,
args: ["--token", secret],
actions: [
{ step_id: "click", kind: "click", selector },
{ step_id: "settle", kind: "wait", duration_ms: 37 },
{
step_id: "open",
kind: "deep-link",
delivery: "second-instance",
url: "rea-fixture://open/item?token=selected",
},
],
}),
application_root: fixture,
});
const provider = {
id: "rea-playwright-electron-active",
name: "REA Playwright active Electron observation provider",
version: "1",
};
const first = createElectronActiveEvidence(
makeInput("first-secret", "#first-secret"),
createElectronActiveObservationFixtureResult(applicationPath),
provider,
);
const second = createElectronActiveEvidence(
makeInput("first-secret", "#second-secret"),
createElectronActiveObservationFixtureResult(applicationPath),
provider,
);
expect(first.parameters.scenario_sha256).not.toBe(
second.parameters.scenario_sha256,
);
expect(JSON.stringify(first)).toContain("first-secret");
expect(first.parameters.actions).toEqual([
{
step_id: "click",
kind: "click",
selector: "#first-secret",
window_index: 0,
},
{ step_id: "settle", kind: "wait", duration_ms: 37 },
{
step_id: "open",
kind: "deep-link",
delivery: "second-instance",
url: "rea-fixture://open/item?token=selected",
},
]);
expect(first.parameters.args).toEqual(["--token", "first-secret"]);
});
it("imports an operator-provided cache layer through an explicit file mapping", async () => {
const application = await applicationFixture();
const cache = await createTestTempDirectory("rea-runtime-cache-static-");
const runtimeCache = await createTestTempDirectory("rea-runtime-cache-live-");
const cacheSource = SOURCE;
await mkdir(join(cache, "mapped"));
await Promise.all([
writeFile(join(cache, "mapped", "chunk.js"), cacheSource),
writeFile(join(cache, "outside.js"), "export const outside = true;\n"),
writeFile(join(runtimeCache, "chunk.js"), cacheSource),
writeFile(join(runtimeCache, "index.html"), "<script></script>"),
]);
const applicationEvidence = await analyzeFixture(application);
const cacheEvidence = await analyzeFixture(cache);
const runtimeEvidence = electronRuntimeEvidence(runtimeCache, cacheSource, {
scriptFile: "chunk.js",
includeWorker: false,
});
const result = reconcileInput({
static_layers: [
{ role: "application", analysis: applicationEvidence },
{
role: "cache",
analysis: cacheEvidence,
runtime_mappings: [
{
kind: "file-root",
root: runtimeCache,
artifact_prefix: "mapped",
},
],
},
],
runtime_observations: [runtimeEvidence],
});
const script = result.reconciliations.find(
({ entity_kind: kind }) => kind === "script",
);
const cacheLayer = result.static_layers.find(({ role }) => role === "cache");
expect(script).toMatchObject({
status: "matched",
basis: "content-and-location",
static_layer_id: cacheLayer?.layer_id,
});
const outside = result.graph.nodes.find(
(node) =>
node.kind === "javascript-asset" &&
node.observations.some(
({ properties }) => properties.path === "outside.js",
),
);
expect(
result.static_load_states.find(
({ static_node_id: nodeId }) => nodeId === outside?.node_id,
),
).toMatchObject({
status: "unknown",
reason: "layer-outside-runtime-scope",
});
const sharedFile = result.graph.nodes.find(
({ observations }) =>
observations.some(({ properties }) => properties.path === "app.js") &&
observations.some(
({ properties }) => properties.path === "mapped/chunk.js",
),
);
expect(
sharedFile?.observations.map(({ properties }) => properties.path),
).toEqual(expect.arrayContaining(["app.js", "mapped/chunk.js"]));
});
const applicationFixture = async (): Promise<string> => {
const root = await createTestTempDirectory("rea-runtime-reconciliation-");
await Promise.all([
writeFile(
join(root, "package.json"),
JSON.stringify({
name: "rea-runtime-reconciliation-fixture",
version: "1.0.0",
renderer: "index.html",
}),
),
writeFile(join(root, "index.html"), "<script src='./app.js'></script>"),
writeFile(join(root, "app.js"), SOURCE),
writeFile(join(root, "worker.js"), "self.onmessage = () => undefined;\n"),
]);
return root;
};
const analyzeFixture = async (root: string) => {
const result = await analyzeJavaScriptApplication({
input_path: root,
});
if (!result.ok) throw result.error;
return result.value;
};
const electronRuntimeEvidence = (
root: string,
source: string,
options: {
readonly scriptFile?: string;
readonly includeWorker?: boolean;
readonly targetId?: string;
readonly sourceIncluded?: boolean;
readonly workersUnavailable?: boolean;
readonly scriptsUnavailable?: boolean;
} = {},
) => {
const scriptFile = options.scriptFile ?? "app.js";
const includeWorker = options.includeWorker ?? true;
const targetId = options.targetId ?? "target-main";
const sourceIncluded = options.sourceIncluded ?? true;
const input = inspectElectronPageInputSchema.parse({
cdp_endpoint: "http://127.0.0.1:9223",
target_id: targetId,
observation_ms: 100,
include_script_sources: sourceIncluded,
});
return createElectronEvidence(
"inspect_electron_page",
input,
{
browser: {
product: "Electron/fixture",
protocol_version: "1.3",
revision: "fixture",
user_agent: "Electron fixture",
js_version: "13",
},
target: {
target_id: targetId,
type: "page",
title: "Fixture",
file_path: join(root, "index.html"),
attached: false,
},
capture_window: {
started_at: "2026-07-15T00:00:00.000Z",
ended_at: "2026-07-15T00:00:00.100Z",
observation_ms: 100,
},
completeness: captureCompleteness(options),
frames: [
{
frame_id: "frame-main",
parent_frame_id: null,
file_path: join(root, "index.html"),
},
],
dom: { total_nodes: 0, nodes: [] },
scripts: {
total: 1,
items: [
{
script_key: `electron_script_${"1".repeat(64)}`,
frame_id: "frame-main",
file_path: join(root, scriptFile),
cdp_hash: "fixture",
length: Buffer.byteLength(source),
is_module: true,
language: "JavaScript",
source: {
included: true as const,
artifact: createWebTextArtifact(source, "text/javascript"),
},
},
],
},
resources: [],
workers: includeWorker
? [
{
target_id: "worker-main",
type: "worker",
file_path: join(root, "worker.js"),
attached: false,
opener_target_id: targetId,
parent_frame_id: "frame-main",
},
]
: [],
limitations: ["Synthetic passive capture fixture."],
},
{
id: "rea-cdp-electron",
name: "REA Electron file-page CDP observation provider",
version: "1",
},
);
};
const completeCapture = () => ({
status: "complete_within_window" as const,
conditions: ["complete_within_window" as const],
policy_filtered_sections: [],
attach_limited_sections: [],
truncated_sections: [],
unavailable_sections: [],
excluded: [],
dropped_events: {
scripts: 0,
network_requests: 0,
console_events: 0,
websocket_connections: 0,
websocket_frames: 0,
webmcp_tools: 0,
timeline_events: 0,
total: 0,
},
});
const captureCompleteness = (options: {
readonly workersUnavailable?: boolean;
readonly scriptsUnavailable?: boolean;
}) => {
const unavailableSections = [
...(options.scriptsUnavailable ? (["scripts"] as const) : []),
...(options.workersUnavailable ? (["workers"] as const) : []),
];
if (unavailableSections.length === 0) return completeCapture();
return {
...completeCapture(),
status: "attach_limited" as const,
conditions: ["attach_limited" as const],
attach_limited_sections: unavailableSections,
unavailable_sections: unavailableSections,
};
};