mirror of
https://github.com/morluto/rea
synced 2026-10-26 06:16:17 -04:00
morluto
cbc0dd1e7c
* fix(contracts)!: require absolute local paths for remaining caller-supplied file inputs Follow-up to the session snapshot/export tightening: the same invisible server-cwd resolution applied to open_binary target paths (parseBinaryTarget(path, process.cwd())), import_evidence_bundle bundle reads, firmware input files (resolve(raw)), browser executable launch paths (resolve-then-spawn), Electron executable/application/root paths (realpath on raw input), and the expected server path check. Each field gains the shared isAbsoluteLocalPath refinement plus a catalog-visible description, since JSON Schema cannot express the rule. Examples, scenario fixtures, and contract tests updated to absolute paths; new schema cases cover rejection/acceptance/omission per field. Explicitly unchanged (verified rooted or out of scope): inspect_plist paths (resolved against the target bundle dir), firmware output_directory (already provider-enforced), filesystem observation paths (resolved against the caller-supplied working_directory), keyed-archive member paths (archive-relative), JS evidence member paths (evidence-relative under root_alias), provider-internal execution schemas, CLI-only doctor flows, and CLI options (own resolve against the operator cwd). * fix(cli): resolve operator-relative paths before shared absolute-path validation The contract tightening rejects relative paths, but three CLI commands forward operator-relative input into the shared schemas: firmware commands pass raw args to FirmwareAnalysisService, and the Electron/browser scenario commands validate parsed scenario JSON directly. CLI paths are relative to the operator shell, so resolve them against the working directory first: resolve() in firmwareCommands, and a shared resolveCliJsonPaths JSON key-path helper (cliJsonInput) applied in electronCommands and cliBrowserScenarioCommands. MCP behavior is unchanged — MCP callers must still send absolute paths. Covers the regression with a relative-path firmware CLI acceptance test (asserts provider-stage capability_unavailable, not a validation error) and unit tests for the helper.
47 lines
1.7 KiB
TypeScript
47 lines
1.7 KiB
TypeScript
import { executableFormatHintSchema } from "../domain/dosCom.js";
|
|
import { isAbsoluteLocalPath } from "../domain/localPath.js";
|
|
import { z } from "zod";
|
|
import { analysisProviderSelectorSchema } from "./providerSelection.js";
|
|
|
|
/** Caller-supplied analysis snapshot path; must name its destination absolutely. */
|
|
const snapshotPathSchema = z
|
|
.string()
|
|
.min(1)
|
|
.refine(isAbsoluteLocalPath, {
|
|
message:
|
|
"snapshot_path must be an absolute local filesystem path (for example /tmp/rea/analysis.json or C:\\rea\\analysis.json)",
|
|
})
|
|
.describe(
|
|
"Absolute local filesystem path for the analysis snapshot; relative paths are rejected.",
|
|
);
|
|
|
|
/** Caller-supplied analysis target path; must name the target absolutely. */
|
|
const binaryTargetPathSchema = z
|
|
.string()
|
|
.min(1)
|
|
.refine(isAbsoluteLocalPath, {
|
|
message:
|
|
"path must be an absolute local filesystem path (for example /tmp/fixture.bin or C:\\analysis\\fixture.bin)",
|
|
})
|
|
.describe(
|
|
"Absolute local filesystem path for the analysis target; relative paths are rejected.",
|
|
);
|
|
|
|
/** Input contract for opening a target with an optional staged snapshot. */
|
|
export const openBinaryInputSchema = z.object({
|
|
path: binaryTargetPathSchema,
|
|
format: executableFormatHintSchema
|
|
.optional()
|
|
.describe(
|
|
"Explicit headerless DOS COM interpretation; omission preserves header-based detection",
|
|
),
|
|
provider_id: analysisProviderSelectorSchema.optional(),
|
|
snapshot_path: snapshotPathSchema.optional(),
|
|
});
|
|
|
|
/** Input contract for closing a target after an optional atomic snapshot. */
|
|
export const closeBinaryInputSchema = z.object({
|
|
snapshot_path: snapshotPathSchema.optional(),
|
|
overwrite: z.boolean().default(false),
|
|
});
|