mirror of
https://github.com/morluto/rea
synced 2026-10-26 14:25:49 -04:00
Muhammad Hamza
4cfc61147b
capture-process recorded exit.code 0 for a target a scenario event killed with SIGKILL or SIGTERM, beside the nonzero exit.signal. The result builder and the retained observation each kept any nonnegative PTY exit code for an exited capture without consulting the signal; only finalization checked it. Project the exit once in captureExitObservation, whose normal exit code is null when a nonzero signal ended the target, and use the same rule for finalization. Normal exits keep their codes, including 0 and 3, and deadline exits remain null. Fixes #6445
95 lines
3.0 KiB
TypeScript
95 lines
3.0 KiB
TypeScript
import { writeFile } from "node:fs/promises";
|
|
import { join } from "node:path";
|
|
import { expect } from "vitest";
|
|
|
|
import { toolContract } from "../../../src/contracts/toolContracts.js";
|
|
import { parseEvidence } from "../../../src/domain/evidence.js";
|
|
import { parseProcessCapture } from "../../../src/domain/process/processCaptureParsing.js";
|
|
import { runCliJson } from "../../fixtures/cliJsonProcess.js";
|
|
import { connectLocalToolsMcp } from "../../fixtures/localToolsMcp.js";
|
|
import { createTestTempDirectory } from "../../fixtures/temporaryDirectory.js";
|
|
import { itWithCaptureCapability as captureTest } from "../../boundary/process/processCaptureCapability.js";
|
|
|
|
const hang = ["-e", "setTimeout(() => {}, 5000)"];
|
|
|
|
captureTest(
|
|
"records no normal exit code for a target a scenario signal terminated",
|
|
async () => {
|
|
const root = await createTestTempDirectory("rea-process-signal-exit-");
|
|
for (const [name, additions, expected] of [
|
|
[
|
|
"SIGKILL",
|
|
{ events: [{ type: "signal", at_ms: 200, signal: "SIGKILL" }] },
|
|
{ code: null, signal: 9, reason: "exited" },
|
|
],
|
|
[
|
|
"SIGTERM",
|
|
{ events: [{ type: "signal", at_ms: 200, signal: "SIGTERM" }] },
|
|
{ code: null, signal: 15, reason: "exited" },
|
|
],
|
|
[
|
|
"exit 3",
|
|
{ arguments: ["-e", "process.exit(3)"] },
|
|
{ code: 3, signal: 0, reason: "exited" },
|
|
],
|
|
[
|
|
"exit 0",
|
|
{ arguments: ["-e", "process.exit(0)"] },
|
|
{ code: 0, signal: 0, reason: "exited" },
|
|
],
|
|
["deadline", { timeout_ms: 300 }, { code: null, reason: "timeout" }],
|
|
] as const) {
|
|
const scenarioPath = join(root, `${name.replace(" ", "-")}.json`);
|
|
await writeFile(
|
|
scenarioPath,
|
|
JSON.stringify({
|
|
executable: process.execPath,
|
|
arguments: hang,
|
|
timeout_ms: 5_000,
|
|
settle_ms: 300,
|
|
...additions,
|
|
}),
|
|
);
|
|
const document = await runCliJson([
|
|
"capture-process",
|
|
scenarioPath,
|
|
"--format",
|
|
"json",
|
|
]);
|
|
const capture = parseProcessCapture(
|
|
parseEvidence(document).normalized_result,
|
|
);
|
|
expect(capture.exit, name).toMatchObject(expected);
|
|
}
|
|
},
|
|
60_000,
|
|
);
|
|
|
|
captureTest(
|
|
"records no normal exit code for a signal-terminated target through MCP",
|
|
async () => {
|
|
const { call } = await connectLocalToolsMcp();
|
|
const response = await call("capture_process_scenario", {
|
|
executable: process.execPath,
|
|
arguments: hang,
|
|
timeout_ms: 5_000,
|
|
settle_ms: 300,
|
|
events: [{ type: "signal", at_ms: 200, signal: "SIGKILL" }],
|
|
});
|
|
expect(response.isError).not.toBe(true);
|
|
const capture = parseProcessCapture(
|
|
parseEvidence(
|
|
toolContract("capture_process_scenario").outputSchema.parse(
|
|
response.structuredContent,
|
|
),
|
|
).normalized_result,
|
|
);
|
|
expect(capture.exit).toMatchObject({
|
|
code: null,
|
|
signal: 9,
|
|
reason: "exited",
|
|
});
|
|
},
|
|
30_000,
|
|
);
|