mirror of
https://github.com/morluto/rea
synced 2026-10-26 06:16:17 -04:00
9548953b47
Carry the command identity already parsed during registration inspection into maintenance selection. Keep activation, validity and public status output separate. Validation: fresh build/catalog and full static checks; registration status, update maintenance and setup cleanup ownership suites passed (90 tests).
202 lines
6.4 KiB
TypeScript
202 lines
6.4 KiB
TypeScript
import { z } from "zod";
|
|
import { RegularFileCleanupFailure } from "../filesystem/OwnedRegularFile.js";
|
|
|
|
import {
|
|
readClientRegistrationInspections,
|
|
type ClientRegistrationStatus,
|
|
} from "./ClientRegistrationStatus.js";
|
|
import {
|
|
existingSkillDestinations,
|
|
type SkillPathIssue,
|
|
} from "./SetupSkill.js";
|
|
import type { SetupAction } from "./SetupTypes.js";
|
|
import type { Result } from "../domain/result.js";
|
|
import type { ArtifactResourceScope } from "../artifacts/ArtifactResourceScope.js";
|
|
|
|
/** Existing REA integrations selected for maintenance, without discovering new targets. */
|
|
export interface MaintenanceScope {
|
|
readonly clients: readonly string[];
|
|
readonly skill: boolean;
|
|
readonly unresolved?: readonly ClientRegistrationStatus[];
|
|
readonly skillIssues?: readonly SkillPathIssue[];
|
|
readonly skillDestinations?: readonly {
|
|
readonly client: string;
|
|
readonly path: string;
|
|
}[];
|
|
}
|
|
|
|
/** Unapplied maintenance evidence produced by the updated setup executable. */
|
|
export type IntegrationMaintenance =
|
|
| { readonly status: "current"; readonly plannedActions: readonly [] }
|
|
| {
|
|
readonly status: "planned";
|
|
readonly scope: MaintenanceScope;
|
|
readonly command: readonly string[];
|
|
readonly plannedActions: readonly SetupAction[];
|
|
}
|
|
| {
|
|
readonly status: "unavailable";
|
|
readonly remediation: string;
|
|
readonly scope?: MaintenanceScope;
|
|
};
|
|
|
|
const setupPlanSchema = z.object({
|
|
status: z.literal("planned"),
|
|
plannedActions: z.array(
|
|
z.object({
|
|
id: z.string(),
|
|
kind: z.enum(["configure_client", "install_skill"]),
|
|
label: z.string(),
|
|
target: z.string(),
|
|
detail: z.string(),
|
|
external: z.literal(false),
|
|
operation: z.enum(["create", "update", "install"]),
|
|
backupPath: z.string().optional(),
|
|
commands: z.array(z.string()).optional(),
|
|
}),
|
|
),
|
|
});
|
|
|
|
/** Discover owned registrations and REA skills without writes. */
|
|
export const existingMaintenanceScope = async (
|
|
home: string,
|
|
entryPoint: string,
|
|
environment: Readonly<NodeJS.ProcessEnv>,
|
|
resources?: ArtifactResourceScope,
|
|
): Promise<MaintenanceScope> => {
|
|
const registrations = await readClientRegistrationInspections(
|
|
home,
|
|
entryPoint,
|
|
{
|
|
environment,
|
|
...(resources === undefined ? {} : { resources }),
|
|
},
|
|
);
|
|
const clients: string[] = [];
|
|
const unresolved: ClientRegistrationStatus[] = [];
|
|
for (const {
|
|
status: registration,
|
|
activation,
|
|
commandIdentity,
|
|
} of registrations) {
|
|
if (registration.state === "unknown" || registration.state === "invalid") {
|
|
unresolved.push(registration);
|
|
continue;
|
|
}
|
|
if (
|
|
activation !== "enabled" ||
|
|
(registration.state !== "aligned" && registration.state !== "stale") ||
|
|
commandIdentity !== "owned"
|
|
)
|
|
continue;
|
|
clients.push(registration.client);
|
|
}
|
|
const skills = await existingSkillDestinations(
|
|
home,
|
|
environment,
|
|
process.platform,
|
|
resources,
|
|
);
|
|
return {
|
|
clients,
|
|
skill: skills.destinations.length > 0,
|
|
skillDestinations: skills.destinations,
|
|
...(skills.issues.length === 0 ? {} : { skillIssues: skills.issues }),
|
|
...(unresolved.length === 0 ? {} : { unresolved }),
|
|
};
|
|
};
|
|
|
|
/** Ask the verified new executable to plan only existing REA integrations. */
|
|
export const planIntegrationMaintenance = async (
|
|
home: string,
|
|
entryPoint: string,
|
|
environment: Readonly<NodeJS.ProcessEnv>,
|
|
execute: (command: readonly string[]) => Promise<Result<string, string>>,
|
|
resources?: ArtifactResourceScope,
|
|
): Promise<IntegrationMaintenance> => {
|
|
try {
|
|
const scope = await existingMaintenanceScope(
|
|
home,
|
|
entryPoint,
|
|
environment,
|
|
resources,
|
|
);
|
|
if (
|
|
(scope.unresolved?.length ?? 0) > 0 ||
|
|
(scope.skillIssues?.length ?? 0) > 0
|
|
)
|
|
return {
|
|
status: "unavailable",
|
|
scope,
|
|
remediation: `Integration maintenance is unresolved: ${[
|
|
...(scope.unresolved ?? []).map(
|
|
({ client, config_path, remediation }) =>
|
|
`${client} (${config_path}): ${remediation ?? "Registration identity is unresolved"}`,
|
|
),
|
|
...(scope.skillIssues ?? []).map(
|
|
({ client, path, detail }) =>
|
|
`${client ?? "skill"} (${path}): ${detail}`,
|
|
),
|
|
].join(" ")}`,
|
|
};
|
|
const skillDestinations = scope.skillDestinations ?? [];
|
|
if (scope.clients.length === 0 && !scope.skill)
|
|
return { status: "current", plannedActions: [] };
|
|
const command = [
|
|
process.execPath,
|
|
entryPoint,
|
|
"setup",
|
|
...scope.clients.flatMap((client) => ["--client", client]),
|
|
...skillDestinations.flatMap(({ client }) => ["--skill-client", client]),
|
|
`--skill=${String(scope.skill)}`,
|
|
];
|
|
const execution = await execute([...command, "--dry-run", "--json"]);
|
|
if (!execution.ok)
|
|
return { status: "unavailable", remediation: execution.error };
|
|
const plan = setupPlanSchema.safeParse(JSON.parse(execution.value));
|
|
if (!plan.success)
|
|
return {
|
|
status: "unavailable",
|
|
remediation: `The updated setup executable returned an invalid maintenance plan: ${plan.error.message}`,
|
|
};
|
|
if (plan.data.plannedActions.length === 0)
|
|
return { status: "current", plannedActions: [] };
|
|
const allowedIds = new Set(
|
|
scope.clients.map((client) => `configure_client:${client}`),
|
|
);
|
|
const skillTargets = new Set(skillDestinations.map(({ path }) => path));
|
|
if (
|
|
plan.data.plannedActions.some((action) =>
|
|
action.kind === "install_skill"
|
|
? !skillTargets.has(action.target)
|
|
: !allowedIds.has(action.id),
|
|
)
|
|
)
|
|
return {
|
|
status: "unavailable",
|
|
remediation:
|
|
"The updated setup plan included an integration outside the existing REA maintenance scope.",
|
|
};
|
|
return {
|
|
status: "planned",
|
|
scope,
|
|
command,
|
|
plannedActions: plan.data.plannedActions.map(
|
|
({ backupPath, commands, ...action }) => ({
|
|
...action,
|
|
...(backupPath === undefined ? {} : { backupPath }),
|
|
...(commands === undefined ? {} : { commands }),
|
|
}),
|
|
),
|
|
};
|
|
} catch (cause: unknown) {
|
|
// Without a supplied scope, the typed failure is the caller's cleanup capability.
|
|
if (resources === undefined && cause instanceof RegularFileCleanupFailure)
|
|
throw cause;
|
|
return {
|
|
status: "unavailable",
|
|
remediation: cause instanceof Error ? cause.message : String(cause),
|
|
};
|
|
}
|
|
};
|