mirror of
https://github.com/morluto/rea
synced 2026-10-27 14:42:18 -04:00
090b454350
* fix(javascript-semantics): keep emitted data out of dispatch listener fields
The EventEmitter operation collector read argument position 1 as the
listener for every event method, so a dispatch such as
bus.emit("ready", data) reported the data binding and its range as the
listener. Only registration and removal name a listener there; emit
passes its remaining arguments to listeners that already exist. Read the
listener argument only for register and remove operations.
Fixes #2574
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* fix(javascript-semantics): read listener arguments only for listener-taking methods
removeAllListeners accepts only an optional event name, so gating the
listener argument on operation kind still reported an ignored second
argument as a listener. Gate on the methods whose argument position 1
names a listener instead: the registration methods, off, and
removeListener.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
---------
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
204 lines
5.5 KiB
TypeScript
204 lines
5.5 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
|
|
import { analyzeJavaScriptSemantics } from "./javascriptSemanticAnalysis.js";
|
|
|
|
describe("JavaScript semantic analysis: runtime boundaries 1", () => {
|
|
it("recovers EventEmitter candidates and imported timer handle cancellation", () => {
|
|
const ir = analyzeJavaScriptSemantics(`
|
|
import {
|
|
setTimeout as later,
|
|
clearTimeout as cancel,
|
|
} from "node:timers";
|
|
function run(bus, dynamicName) {
|
|
const handle = later(work, 25);
|
|
bus.on("ready", handler);
|
|
bus.once(dynamicName, handler);
|
|
bus.emit("ready");
|
|
bus.off("ready", handler);
|
|
cancel(handle);
|
|
}
|
|
`);
|
|
|
|
expect(
|
|
ir.eventOperations.map(({ kind, method, eventName, resolution }) => ({
|
|
kind,
|
|
method,
|
|
eventName,
|
|
resolution,
|
|
})),
|
|
).toEqual([
|
|
{
|
|
kind: "register",
|
|
method: "on",
|
|
eventName: "ready",
|
|
resolution: "complete",
|
|
},
|
|
{
|
|
kind: "register",
|
|
method: "once",
|
|
eventName: null,
|
|
resolution: "unresolved",
|
|
},
|
|
{
|
|
kind: "dispatch",
|
|
method: "emit",
|
|
eventName: "ready",
|
|
resolution: "complete",
|
|
},
|
|
{
|
|
kind: "remove",
|
|
method: "off",
|
|
eventName: "ready",
|
|
resolution: "complete",
|
|
},
|
|
]);
|
|
expect(ir.timerOperations).toEqual([
|
|
expect.objectContaining({
|
|
kind: "schedule",
|
|
method: "setTimeout",
|
|
delayMilliseconds: 25,
|
|
resolution: "complete",
|
|
}),
|
|
expect.objectContaining({
|
|
kind: "cancel",
|
|
method: "clearTimeout",
|
|
delayMilliseconds: null,
|
|
resolution: "complete",
|
|
linkedTimerId: ir.timerOperations[0]?.timerId,
|
|
}),
|
|
]);
|
|
expect(ir.functionFingerprints[0]?.components.effects).toEqual([
|
|
"event",
|
|
"timer",
|
|
]);
|
|
});
|
|
|
|
it("does not treat shadowed timer globals as Node timers", () => {
|
|
const ir = analyzeJavaScriptSemantics(`
|
|
function run(setTimeout, clearTimeout) {
|
|
const handle = setTimeout(work, 1);
|
|
clearTimeout(handle);
|
|
}
|
|
`);
|
|
|
|
expect(ir.timerOperations).toEqual([]);
|
|
});
|
|
|
|
it("does not invent request fields or option keys from dynamic properties", () => {
|
|
const ir = analyzeJavaScriptSemantics(`
|
|
const key = resolveKey();
|
|
fetch("https://example.test", { [key]: 1, body: "x" });
|
|
spawn("/bin/tool", { [key]: vars });
|
|
`);
|
|
expect(
|
|
ir.requestOperations.flatMap(({ fields }) =>
|
|
fields.map(({ name }) => name),
|
|
),
|
|
).toEqual(["body"]);
|
|
expect(
|
|
ir.childProcessSpawns.some(
|
|
({ environmentSupplied }) => environmentSupplied,
|
|
),
|
|
).toBe(false);
|
|
});
|
|
|
|
it("retains every added semantic effect family", () => {
|
|
const ir = analyzeJavaScriptSemantics(
|
|
`
|
|
import { spawn } from "node:child_process";
|
|
import { open } from "node:fs/promises";
|
|
Promise.resolve(1);
|
|
bus.on("ready", handler);
|
|
setTimeout(work, 1);
|
|
spawn("/bin/tool");
|
|
const endpoint = process.env.API_URL;
|
|
fetch("https://example.test");
|
|
JSON.parse(raw);
|
|
open(path);
|
|
`,
|
|
);
|
|
|
|
expect(ir.coverage.status).toBe("complete");
|
|
expect(ir.promiseOperations).toHaveLength(1);
|
|
expect(ir.eventOperations).toHaveLength(1);
|
|
expect(ir.timerOperations).toHaveLength(1);
|
|
expect(ir.childProcessSpawns).toHaveLength(1);
|
|
expect(ir.configurationOperations).toHaveLength(1);
|
|
expect(ir.requestOperations).toHaveLength(1);
|
|
expect(ir.boundaryOperations).toHaveLength(1);
|
|
expect(ir.resourceOperations).toHaveLength(1);
|
|
expect(ir.objectOperations.length).toBeGreaterThan(0);
|
|
});
|
|
});
|
|
|
|
describe("JavaScript semantic analysis: event dispatch data", () => {
|
|
it("keeps emitted data out of dispatch listener fields", () => {
|
|
const ir = analyzeJavaScriptSemantics(`
|
|
import { EventEmitter } from "node:events";
|
|
const bus = new EventEmitter();
|
|
const data = 1;
|
|
const handler = () => {};
|
|
bus.on("ready", handler);
|
|
bus.emit("ready", data);
|
|
bus.emit("ready");
|
|
bus.off("ready", handler);
|
|
bus.removeAllListeners("ready", data);
|
|
`);
|
|
const handler = ir.bindings.find(({ name }) => name === "handler");
|
|
expect(handler).toBeDefined();
|
|
expect(
|
|
ir.eventOperations.map(
|
|
({ kind, method, listenerBindingId, listenerLocation }) => ({
|
|
kind,
|
|
method,
|
|
listenerBindingId,
|
|
hasListenerLocation: listenerLocation !== null,
|
|
}),
|
|
),
|
|
).toEqual([
|
|
{
|
|
kind: "register",
|
|
method: "on",
|
|
listenerBindingId: handler?.bindingId,
|
|
hasListenerLocation: true,
|
|
},
|
|
{
|
|
kind: "dispatch",
|
|
method: "emit",
|
|
listenerBindingId: null,
|
|
hasListenerLocation: false,
|
|
},
|
|
{
|
|
kind: "dispatch",
|
|
method: "emit",
|
|
listenerBindingId: null,
|
|
hasListenerLocation: false,
|
|
},
|
|
{
|
|
kind: "remove",
|
|
method: "off",
|
|
listenerBindingId: handler?.bindingId,
|
|
hasListenerLocation: true,
|
|
},
|
|
{
|
|
kind: "remove",
|
|
method: "removeAllListeners",
|
|
listenerBindingId: null,
|
|
hasListenerLocation: false,
|
|
},
|
|
]);
|
|
expect(
|
|
ir.eventOperations.map(({ eventName, resolution }) => [
|
|
eventName,
|
|
resolution,
|
|
]),
|
|
).toEqual([
|
|
["ready", "complete"],
|
|
["ready", "complete"],
|
|
["ready", "complete"],
|
|
["ready", "complete"],
|
|
["ready", "complete"],
|
|
]);
|
|
});
|
|
});
|