Files
rea/src/domain/javascript/javascriptSemanticObjectReferences.test.ts
T
morluto 880b3a510b fix(javascript): bound static getter reference expansion
Replace recursive getter histories with a query-owned worklist and memo. Bound
precise expansion at 512 states and widen growing receiver cycles; retain
escaped roots and constructed children rather than silently dropping suffixes.
Carry the resource limit through semantic coverage, worker transport and graph
Evidence while preserving direct writes, imports and unrelated literal facts.

The small source probe reduced 65/326 paths to one widened reference for five
and six getters. The original large Claude artifact was not rerun. Validate
receiver/alias/mutation controls and compiled CLI/MCP consumers.

Refs #3839, #3848

Co-authored-by: Yi Han <yhan606@aucklanduni.ac.nz>
2026-10-16 06:06:00 +08:00

142 lines
4.7 KiB
TypeScript

import * as t from "@babel/types";
import { expect, it } from "vitest";
import { indexJavaScriptBindingsSteps } from "./javascriptSemanticAnalysis.js";
import {
semanticClassPropertyReferences,
semanticObjectPropertyReferences,
} from "./javascriptSemanticObjectReferences.js";
import { completeSemanticSteps } from "./javascriptSemanticTraversal.js";
import { parseJavaScriptSource } from "./javascriptSourceParser.js";
import { getterExpansionSource } from "../../../tests/fixtures/javascriptGetterExpansion.js";
const objectAndState = (source: string) => {
const parsed = parseJavaScriptSource(source, "object.js");
if (parsed === null) throw new Error("Expected a parsed fixture");
const declaration = parsed.program.body[0];
if (!t.isVariableDeclaration(declaration))
throw new Error("Expected a declaration");
const init = declaration.declarations[0]?.init;
if (!t.isObjectExpression(init)) throw new Error("Expected an object");
return {
object: init,
source,
state: completeSemanticSteps(indexJavaScriptBindingsSteps(parsed.program)),
};
};
const spelled = (
fixture: ReturnType<typeof objectAndState>,
key: string | number | null,
) =>
semanticObjectPropertyReferences(fixture.object, [key], fixture.state).map(
({ node, path }) => [
fixture.source.slice(node.start ?? 0, node.end ?? 0),
JSON.stringify(path),
],
);
it("resolves exact keys with source-order overrides, spreads and accessors", () => {
const fixture = objectAndState(
`const o = { a: 1, ...base, b: 2, a: 3, [dynamic]: 4, __proto__: proto, ...{ b: 5 }, get c() { return 6; }, c: 7 };`,
);
// Expectations match the full source-order scan these exact keys replace.
expect(spelled(fixture, "a")).toEqual([
["{ b: 5 }", '["a"]'],
["4", "[]"],
["3", "[]"],
]);
expect(spelled(fixture, "b")).toEqual([
["{ b: 5 }", '["b"]'],
["4", "[]"],
]);
expect(spelled(fixture, "c")).toEqual([
["7", "[]"],
["4", "[]"],
]);
expect(spelled(fixture, "missing")).toEqual([
["{ b: 5 }", '["missing"]'],
["proto", '["missing"]'],
["4", "[]"],
["base", '["missing"]'],
]);
// A wildcard key still scans every property.
expect(spelled(fixture, null)).toEqual([
["7", "[]"],
["{ b: 5 }", '[{"excludedKeys":["c"]}]'],
["proto", "[null]"],
["4", "[]"],
["3", "[]"],
["2", "[]"],
["base", '[{"excludedKeys":["a","b","c"]}]'],
]);
// Numeric keys use the same exact spelling as string keys.
expect(
spelled(objectAndState(`const o = { 1: "one", 2: "two" };`), 1),
).toEqual([['"one"', "[]"]]);
});
it("preserves references through a small static getter permutation", () => {
const getters = Array.from(
{ length: 5 },
(_, index) =>
`static get field${index}() { return this[key].field${index}; }`,
).join("\n");
const source = `const key = getKey(); const shared = {}; class Request {
${getters}
static get state() { return shared; }
}`;
const parsed = parseJavaScriptSource(source, "getters.js");
if (parsed === null) throw new Error("Expected a parsed fixture");
const klass = parsed.program.body.find((node): node is t.ClassDeclaration =>
t.isClassDeclaration(node),
);
if (klass === undefined) throw new Error("Expected a class declaration");
const state = completeSemanticSteps(
indexJavaScriptBindingsSteps(parsed.program),
);
const references = semanticClassPropertyReferences(
{ owner: klass, kind: "static" },
["field0"],
state,
);
expect(
references.some(
({ node }) => source.slice(node.start ?? 0, node.end ?? 0) === "shared",
),
).toBe(true);
const distinctReferences = new Set(
references.map(({ node, path, escapes }) =>
JSON.stringify([node.start, node.end, path, escapes]),
),
);
expect(references).toHaveLength(distinctReferences.size);
});
it("widens a large static getter permutation to one escaped reference", () => {
const source = getterExpansionSource(30).replaceAll("get ", "static get ");
const parsed = parseJavaScriptSource(source, "getters.js");
if (parsed === null) throw new Error("Expected a parsed fixture");
const klass = parsed.program.body.find((node): node is t.ClassDeclaration =>
t.isClassDeclaration(node),
);
if (klass === undefined) throw new Error("Expected a class declaration");
const state = completeSemanticSteps(
indexJavaScriptBindingsSteps(parsed.program),
);
const references = semanticClassPropertyReferences(
{ owner: klass, kind: "static" },
["field0"],
state,
);
expect(references).toHaveLength(1);
expect(references[0]).toMatchObject({
node: { type: "Identifier", name: "shared" },
path: [],
escapes: true,
});
expect([...state.getterResourceLimits]).toEqual(["getter-expansion"]);
});