mirror of
https://github.com/morluto/rea
synced 2026-10-26 22:28:27 -04:00
e5965adb29
* feat(cli): accept JavaScript source selections from a JSON array or file Add --source-paths-json to analyze and analyze-javascript-application. It takes an inline JSON array or a JSON file path of exact inventoried paths and appends them after any --source-path values, so a long selection no longer has to fit on one command line (cmd.exe through npx on Windows stops at 8,191 characters). Entries stay artifact-relative and go through the existing source_paths validation; the native lane rejects the option like --source-path. Refs #4987 * fix(cli): cancel --source-paths-json file reads with the command Pass the command's abort signal through parseCliJsonInput to readJsonInputFile, so SIGINT/SIGTERM stop a selection-file read instead of waiting for it to finish. A cancelled read now propagates its abort rather than being reported as a file read failure. * test(cli): preserve ASAR identity for JSON file selections * docs(cli): record source-selection task costs and identity verification --------- Co-authored-by: KJLavender <KJLavender@users.noreply.github.com> Co-authored-by: Kaoru0822 <208281322+kaoru0822-kitauji@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: gensokyo-dev <342580529+gensokyo-dev@users.noreply.github.com>
154 lines
5.6 KiB
TypeScript
154 lines
5.6 KiB
TypeScript
import type { AnalysisViewRequest } from "../domain/analysisView/analysisView.js";
|
|
import { publishCliAnalysisEvidence } from "./analysisEvidenceDelivery.js";
|
|
import { JAVASCRIPT_APPLICATION_PROVIDER } from "../domain/investigationProviders.js";
|
|
import { createProgressReporter } from "../application/ProgressReporter.js";
|
|
import { ArtifactReaderFailure } from "../artifacts/ArtifactReader.js";
|
|
import { ArtifactResourceScope } from "../artifacts/ArtifactResourceScope.js";
|
|
import { analysisErrorWithCleanupFailure } from "../domain/analysisErrorCleanup.js";
|
|
import { projectAnalysisError } from "../domain/analysisErrorProjection.js";
|
|
import type { JsonValue } from "../domain/jsonValue.js";
|
|
import { ProviderCleanupError } from "../domain/providerCleanupError.js";
|
|
import { analysisInputErrorFromIssues } from "../domain/inputIssueProjection.js";
|
|
import { javaScriptSourcePathsSchema } from "../domain/javascript/javascriptSourceSelection.js";
|
|
import { parseCliJsonInput } from "../cliJsonInput.js";
|
|
|
|
const OPERATION = "analyze_javascript_application";
|
|
|
|
/**
|
|
* Combine repeated `--source-path` values with `--source-paths-json`, an inline
|
|
* JSON array or a JSON file. A file keeps large selections below the host
|
|
* command-line limit; entries remain exact application-relative paths and are
|
|
* not resolved against the working directory.
|
|
*/
|
|
export const cliJavaScriptSourcePaths = async (
|
|
sourcePath: readonly string[] | undefined,
|
|
sourcePathsJson: string | undefined,
|
|
signal?: AbortSignal,
|
|
): Promise<
|
|
| { readonly ok: true; readonly value: readonly string[] | undefined }
|
|
| { readonly ok: false; readonly error: JsonValue }
|
|
> => {
|
|
if (sourcePathsJson === undefined) return { ok: true, value: sourcePath };
|
|
const input = await parseCliJsonInput(sourcePathsJson, OPERATION, signal);
|
|
if (!input.ok) return input;
|
|
const parsed = javaScriptSourcePathsSchema.safeParse(input.value);
|
|
if (!parsed.success)
|
|
return {
|
|
ok: false,
|
|
error: cliError(
|
|
analysisInputErrorFromIssues(
|
|
OPERATION,
|
|
parsed.error.issues.map((issue) => ({
|
|
...issue,
|
|
path: ["source_paths_json", ...issue.path],
|
|
})),
|
|
{ source_paths_json: input.value },
|
|
),
|
|
),
|
|
};
|
|
return { ok: true, value: [...(sourcePath ?? []), ...parsed.data] };
|
|
};
|
|
|
|
/**
|
|
* One scope for every JavaScript analysis in this process. A healthy worker
|
|
* stays parked between commands; {@link closeCliJavaScriptResources} stops it.
|
|
* Pending cleanup is still retried before each command returns.
|
|
*/
|
|
let retainedScope: ArtifactResourceScope | undefined;
|
|
/** One shutdown shared by the exit callback and the dispatch `finally`. */
|
|
let closing: Promise<void> | undefined;
|
|
|
|
const cliAnalysisScope = (): ArtifactResourceScope => {
|
|
retainedScope ??= new ArtifactResourceScope();
|
|
return retainedScope;
|
|
};
|
|
|
|
/**
|
|
* Stop the process-owned JavaScript worker. Callers that overlap share the
|
|
* attempt in flight. The scope stays owned when shutdown fails, so the next
|
|
* call retries instead of treating the worker as already released.
|
|
*/
|
|
export const closeCliJavaScriptResources = (): Promise<void> => {
|
|
if (closing !== undefined) return closing;
|
|
const scope = retainedScope;
|
|
if (scope === undefined) return Promise.resolve();
|
|
let published: Promise<void>;
|
|
published = scope
|
|
.close()
|
|
.then(() => {
|
|
if (retainedScope === scope) retainedScope = undefined;
|
|
})
|
|
.finally(() => {
|
|
if (closing === published) closing = undefined;
|
|
});
|
|
closing = published;
|
|
return published;
|
|
};
|
|
|
|
/** Execute the shared CLI boundary for static JavaScript analysis. */
|
|
export const runCliJavaScriptApplicationAnalysis = async (
|
|
input: unknown,
|
|
environment: Readonly<Record<string, string | undefined>>,
|
|
signal?: AbortSignal,
|
|
delivery?: {
|
|
readonly detail: "complete" | "summary";
|
|
readonly evidenceOutput: string | undefined;
|
|
readonly view?: AnalysisViewRequest;
|
|
},
|
|
): Promise<JsonValue> => {
|
|
const { analyzeJavaScriptApplication } =
|
|
await import("../application/javascript/JavaScriptApplicationService.js");
|
|
const progress = createProgressReporter(
|
|
async (update) => {
|
|
process.stderr.write(`${JSON.stringify({ rea_progress: update })}\n`);
|
|
},
|
|
{ minimumIntervalMs: 0 },
|
|
);
|
|
const resources = cliAnalysisScope();
|
|
const result = await analyzeJavaScriptApplication(input, resources, {
|
|
environment,
|
|
progress,
|
|
...(signal === undefined ? {} : { signal }),
|
|
});
|
|
try {
|
|
// Retry failed owners without stopping a healthy parked worker.
|
|
await resources.retryCleanup();
|
|
} catch (cause: unknown) {
|
|
const cleanup = ArtifactReaderFailure.cleanupObservation(
|
|
cause,
|
|
"JavaScript application resources",
|
|
);
|
|
const failure = new ProviderCleanupError(
|
|
JAVASCRIPT_APPLICATION_PROVIDER.id,
|
|
cleanup.resources,
|
|
{ reason: cleanup.reason },
|
|
{ cause, operation: "analyze_javascript_application" },
|
|
);
|
|
return cliError(
|
|
result.ok
|
|
? failure
|
|
: analysisErrorWithCleanupFailure(
|
|
result.error,
|
|
failure,
|
|
"analyze_javascript_application",
|
|
),
|
|
);
|
|
}
|
|
const value = result.ok ? result.value : cliError(result.error);
|
|
return delivery === undefined
|
|
? value
|
|
: publishCliAnalysisEvidence(value, {
|
|
...delivery,
|
|
providerId: JAVASCRIPT_APPLICATION_PROVIDER.id,
|
|
operation: "analyze_javascript_application",
|
|
signal: signal ?? new AbortController().signal,
|
|
});
|
|
};
|
|
|
|
const cliError = (
|
|
error: Parameters<typeof projectAnalysisError>[0],
|
|
): JsonValue => ({
|
|
error: "JavaScript application analysis failed",
|
|
...projectAnalysisError(error),
|
|
});
|