Files
rea/tests/acceptance/pcapOutputUtf8CliMcp.test.ts
T
morluto 51e5938776 fix(pcap): retain UTF-8 decoding failures across tool output
Validate supervised text once before version or capture interpretation. Exercise POSIX client probes through compiled CLI and stdio MCP; capture-summary native bounds remain host-specific.

Fixes #6775
2026-10-24 00:11:41 +08:00

123 lines
4.0 KiB
TypeScript

import { expect } from "vitest";
import { toolContract } from "../../src/contracts/toolContracts.js";
import { parseEvidence } from "../../src/domain/evidence.js";
import { pcapResultSchemas } from "../../src/domain/pcap/pcapAnalysis.js";
import { connectLocalToolsMcp } from "../fixtures/localToolsMcp.js";
import { createTestTempDirectory } from "../fixtures/temporaryDirectory.js";
import {
writeStubTools,
type PcapStubToolsOptions,
} from "../fixtures/pcap/pcapTestTools.js";
import { cliTest } from "../support/cli/cliFixture.js";
const invalidVersionCases = [
{
tool: "tshark",
stream: "stdout",
options: { invalidTsharkVersionStream: "stdout" },
},
{
tool: "tshark",
stream: "stderr",
options: { invalidTsharkVersionStream: "stderr" },
},
{
tool: "capinfos",
stream: "stdout",
options: { invalidCapinfosVersionStream: "stdout" },
},
{
tool: "capinfos",
stream: "stderr",
options: { invalidCapinfosVersionStream: "stderr" },
},
] as const;
const environmentFor = (
root: string,
tools: { readonly tshark: string; readonly capinfos: string },
) => ({
HOME: root,
USERPROFILE: root,
XDG_CONFIG_HOME: root,
XDG_CACHE_HOME: root,
REA_LOG_LEVEL: "silent",
REA_TSHARK_COMMAND: tools.tshark,
REA_CAPINFOS_COMMAND: tools.capinfos,
});
cliTest.skipIf(process.platform === "win32")(
"returns the same unreadable-output diagnostic for invalid version streams through CLI and stdio MCP",
async ({ cli }) => {
for (const scenario of invalidVersionCases) {
const root = await createTestTempDirectory("rea-pcap-version-utf8-");
const tools = await writeStubTools(
root,
scenario.options as PcapStubToolsOptions,
);
const environment = environmentFor(root, tools);
const cliResponse = await cli.run({
arguments: ["inspect-pcap-client", "--json"],
environment,
});
expect(cliResponse.exitCode, cliResponse.stdout).toBe(1);
expect(cliResponse.json).toMatchObject({
code: "unreadable_output",
details: {
diagnostics: {
stage: "version",
invalid_utf8_streams: [scenario.stream],
},
},
});
const { client, call } = await connectLocalToolsMcp(environment);
try {
const reply = await call("inspect_pcap_client", {});
expect(reply.isError).toBe(true);
const content = reply.content.find((item) => item.type === "text");
if (content?.type !== "text") throw new Error("Missing MCP error text");
expect(JSON.parse(content.text)).toEqual({ error: cliResponse.json });
} finally {
await client.close();
}
}
},
);
cliTest.skipIf(process.platform === "win32")(
"preserves literal replacement characters in version output through CLI and stdio MCP",
async ({ cli }) => {
const root = await createTestTempDirectory("rea-pcap-version-literal-");
const tools = await writeStubTools(root, { literalTsharkVersion: true });
const environment = environmentFor(root, tools);
const outputSchema = toolContract("inspect_pcap_client").outputSchema;
const cliResponse = await cli.run({
arguments: ["inspect-pcap-client", "--json"],
environment,
});
expect(cliResponse.exitCode, cliResponse.stdout).toBe(0);
const cliEvidence = parseEvidence(outputSchema.parse(cliResponse.json));
const cliClient = pcapResultSchemas.inspect_pcap_client.parse(
cliEvidence.normalized_result,
).client;
const { client, call } = await connectLocalToolsMcp(environment);
try {
const reply = await call("inspect_pcap_client", {});
expect(reply.isError).not.toBe(true);
const mcpEvidence = parseEvidence(
outputSchema.parse(reply.structuredContent),
);
const mcpClient = pcapResultSchemas.inspect_pcap_client.parse(
mcpEvidence.normalized_result,
).client;
expect(cliClient).toEqual(mcpClient);
expect(cliClient.tshark_version).toBe("TShark (Wireshark) 4.6.6�-stub");
} finally {
await client.close();
}
},
);